From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] [gdb/remote] Reimplement escape_buffer
Date: Tue, 24 Mar 2026 16:34:05 +0100 [thread overview]
Message-ID: <2e9318db-e4b9-4eaa-a879-e71a2927b04f@suse.de> (raw)
In-Reply-To: <87fr5q8kok.fsf@tromey.com>
On 3/23/26 7:28 PM, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>
> Tom> Anyway, the way to make this work using putstrn is:
> Tom> ...
> Tom> @@ -10515,6 +10515,7 @@ static std::string
> Tom> escape_buffer (const char *buf, int n)
> Tom> {
> Tom> string_file stb;
> Tom> + scoped_restore reset = make_scoped_restore (&sevenbit_strings, true);
>
> I think this would be fine, maybe with some suitable comment.
I've submitted a v3 (
https://sourceware.org/pipermail/gdb-patches/2026-March/226183.html ).
Thanks,
- Tom
prev parent reply other threads:[~2026-03-24 15:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-21 9:44 Tom de Vries
2026-03-23 14:12 ` Tom Tromey
2026-03-23 17:20 ` Tom de Vries
2026-03-23 18:28 ` Tom Tromey
2026-03-24 15:34 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e9318db-e4b9-4eaa-a879-e71a2927b04f@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox