Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Vrany <jan@vrany.io>
To: undisclosed-recipients:;
Subject: Re: [RFC PATCH 7/8] gdb/ctf: don't use psymtabs, create symtabs directly
Date: Tue, 03 Feb 2026 13:00:23 +0000	[thread overview]
Message-ID: <2e8e28fbfa4894f3f28fe86f698406c4e880753f.camel@vrany.io> (raw)

On Tue, 2026-02-03 at 07:00 +0000, simon.marchi wrote:
> https://inbox.sourceware.org/gdb-patches/20260203065435.3092465-8-simon.marchi@polymtl.ca/
> 
> 
> In order to access the symtabs, elfctf_build_symtabs installs the
> expanded_symbols_functions quick_symbol_functions implementation, which
> essentially searches in the existing symtabs.  I am pretty sure this is
> not 100% correct, because this would search unrelated symtabs, if for
> instance the CTF debug info co-existed with DWARF info.  But it's good
> enough for a prototype.

True, but does that matter? Should that matter?

Also it seems to me that this version does not allow for both CTF and
DWARF in single objfile: 

(from patch "gdb/ctf: don't use psymtabs, create symtabs directly")

   /* Read the CTF section only if there is no DWARF info.  */
   if (!always_read_ctf && !has_dwarf2 && ei.ctfsect)
-    {
-      elfctf_build_psymtabs (objfile);
-    }
+    elfctf_build_symtabs (objfile);
 
   /* Copy relocations are used by some ABIs using the ELF format, so
      set the objfile flag indicating this fact.  */

Thanks, 

Jan


             reply	other threads:[~2026-02-03 13:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03 13:00 Jan Vrany [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-02-03  6:45 [RFC PATCH 0/8] Make CTF reader build full symtabs, get rid of psymtab simon.marchi
2026-02-03  6:45 ` [RFC PATCH 7/8] gdb/ctf: don't use psymtabs, create symtabs directly simon.marchi
2026-02-12 17:54   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e8e28fbfa4894f3f28fe86f698406c4e880753f.camel@vrany.io \
    --to=jan@vrany.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox