From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GfHxE3TJq2r9VBYAWB0awg (envelope-from ) for ; Thu, 17 Sep 2026 07:05:24 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=puY6be0d; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=puY6be0d; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3C9EB1E06B; Thu, 17 Sep 2026 07:05:24 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2A2421E01F for ; Thu, 17 Sep 2026 07:05:23 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6F03E4BAE7C1 for ; Thu, 17 Sep 2026 11:05:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6F03E4BAE7C1 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=puY6be0d; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=puY6be0d Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11010050.outbound.protection.outlook.com [52.101.69.50]) by sourceware.org (Postfix) with ESMTPS id 50BD54BA7998 for ; Thu, 17 Sep 2026 11:04:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 50BD54BA7998 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 50BD54BA7998 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=52.101.69.50 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1789643088; cv=pass; b=xGwjvO1HcS035v0dr6B/lhRF3Dtna96HOxsHC4aqo6ko5yRrCLGXZ0VTUDUB1vactdlv3raV/k2fG09J6oSZJSU7JAufE1PEM5rNksIvIF1kG6uzbO77r5Wc6pPAVzqVY3MxiJsbwM9hGa/ssin9LMpzeg2P4PO+yg7X7mqc1ac= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1789643088; c=relaxed/simple; bh=EIhXvLxn4O2vNmk62nZVoxbAqPgCLNTAaF78ZUddKP4=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=PgpFHmH9tqwaUl05Kl4y3zeEyXEbAhTzrSLvxS6XrKz2L2Rsw8cFRKHKaOgCGVKraZHsWwh6YvpV+ydBPDfPrzYWh0Fb7HOrSybQdOxCGBH20NuLs2ehVYFgscyHDzqdPKUDdTUbFByqzrKks5CPXrv+oAt5TKfrI/k1erclIPo= ARC-Authentication-Results: i=3; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=puY6be0d; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=puY6be0d DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 50BD54BA7998 ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=J2NQHG7Ur/Ka1IGFtX0zowJ50Kgv/QQtGlQp1gzakK/8bbw0UxI41VOw+HmbUaIH2eYpmjdsUbJp2e7J85pdwQ7Y7CQnCoizsD4jd7etCplbSyBIVX5dR5nOCpxPkTOLP82aMHp3cjX6Aba9A3gpkBaFz8la6LtG4KRYBD695Q1GZTwosL0Rlt6Tz9nAPXdGtrBcukbnG1YT/4McHGhwh946LQyXlt5Xtox4z9oME0kQGqTY/SdvXLnuSzEoUX3lC2V+jsPthnjAId0ROBtSnK797a/Q2CYWPq6BU6d1D1Jb/hXLWxuuvtk2+P+b3VSkX/UblLtcpBdAiulv3GhZeg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UE3rIUe+rfdr0ddoRHvs7jdBcXlcJmUDONUBfesB1Cg=; b=hDu0VZTZs6wBYzC4PuAlWjNc+XM+70B1NNep6KwugnjDe82ITLMkIMRK0qTUbcjIAt50jKw6qXDBnAdmAZeArsZDNBcC1Xd4SyYZqJscd4AJF5fvnHG9a87YYo5CSjbtfSDz2tvVDc2RbMnxaLkTN09NoiWlwqdCMowi6SfQGGBPPxke8CWlSyx0M8kpPeCfERsxPDV63uBkEytQ/8EYRTPFqxouIP5IdFmPIhuTUPIasT0Bq277ijbGgsuwyMcngD34GvlNWB4NvpoydKDEN+m55VIJSz1DvoceSDJ8mS55HXALe7EzelpGmG1FAA1cfGKMnPsOXem5zpj0kcNLtw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=redhat.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UE3rIUe+rfdr0ddoRHvs7jdBcXlcJmUDONUBfesB1Cg=; b=puY6be0da4BBKNVyBVUNacGXz3VRuBPXVVEojQe7dTRtwncl/2mp0cP87uWvu7zpshGO1wJmM5mN1bfJnHS0qVvM0804FN8u/OUOifa81P9PG1kfH6PcM8MblzHyfvUFMX0g1609ffOtkqpXho67LLzltoGYkz+nxgsXuNEil+c= Received: from GV3PEPF0001DC35.SWEP280.PROD.OUTLOOK.COM (2603:10a6:158:400::2eb) by DBBPR08MB10433.eurprd08.prod.outlook.com (2603:10a6:10:52f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.5; Thu, 17 Sep 2026 11:04:32 +0000 Received: from CPH1EPF0000052C.eurprd05.prod.outlook.com (2603:10a6:388::187) by GV3PEPF0001DC35.outlook.office365.com (2603:10a6:158:400::2eb) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.382.15 via Frontend Transport; Thu, 17 Sep 2026 11:04:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by CPH1EPF0000052C.mail.protection.outlook.com (10.167.241.167) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.451.8 via Frontend Transport; Thu, 17 Sep 2026 11:04:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jZ65eyJanW3X9Zj4yyWFDCtgQuXNmW625tbmUTZRpbDEM/mHzgXWBgi6PBjLlhXPM1RZBSMGvDiMSJYy32xhqQw6GuhnPMtBZCUsOhSZPIhxUMRJBzhAF4/JRkUd0IU6u0BzgzDb+SAc3wZuJE1K/2VfeJphertnXFZCUkYoykYas6Sgwy5dt2KdGFZErseQQVOyAffrufcQnWnUneB0plkULINVdDM7wgf9KP0IdcRPzVCGINcgFexfEPqh3JvfU+oGYPEAEFGHxzAeU33KjrrcdVefBRReWZ+65bNl5je+q0t3l/N2EEPWKx+dUSHN09IKlh1KG0uv8u42YDZ4kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UE3rIUe+rfdr0ddoRHvs7jdBcXlcJmUDONUBfesB1Cg=; b=FcD3Su0DYPQmpALAs9ZULlnuZmD8eAOyrjamg2hunYj2eQ0w8is3ZZ3Ra1ETQmX+v9eG9Uxn5uRi4a00DCyMnjaTu26GOJDC1eg2RX+8GFxTpKIwshTQ2dRWxkW8MhTKATHqOmIWjFm1CevNmV7Yz4JTjnuzzXh3tkn5VOkpQJXg8SJEPCYr1mFyvM/JxcdfE6zmI2IeNEoo7u89kTfKkStL5iZrjrfwi1UX3vCu1+xmV3xHOxhioC5cCgkPG+7VBRrcBV8Q/XETDZveg8heUyPUwv019WrVE2Oo40itOh+OEAqMqfDZyewrAMV9OqOXdbjsZkwKDZWvJESamZDtgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UE3rIUe+rfdr0ddoRHvs7jdBcXlcJmUDONUBfesB1Cg=; b=puY6be0da4BBKNVyBVUNacGXz3VRuBPXVVEojQe7dTRtwncl/2mp0cP87uWvu7zpshGO1wJmM5mN1bfJnHS0qVvM0804FN8u/OUOifa81P9PG1kfH6PcM8MblzHyfvUFMX0g1609ffOtkqpXho67LLzltoGYkz+nxgsXuNEil+c= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB8659.eurprd08.prod.outlook.com (2603:10a6:20b:563::10) by FRZPR08MB10967.eurprd08.prod.outlook.com (2603:10a6:d10:136::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Thu, 17 Sep 2026 11:03:59 +0000 Received: from AS8PR08MB8659.eurprd08.prod.outlook.com ([fe80::96bf:2de3:5eab:70ae]) by AS8PR08MB8659.eurprd08.prod.outlook.com ([fe80::96bf:2de3:5eab:70ae%5]) with mapi id 15.21.0428.008; Thu, 17 Sep 2026 11:03:59 +0000 Message-ID: <2e62f65f-fc95-4e97-b1e2-06bb4e68e755@arm.com> Date: Thu, 17 Sep 2026 12:03:57 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/6] target_fileio_read_stralloc: add an optional length parameter To: Andrew Burgess , gdb-patches@sourceware.org Cc: Simon Marchi , Thiago Jung Bauermann , Luis Machado , Luis Machado , Christina Joos , Kevin Buettner References: <20260825100912.514232-1-matthieu.longo@arm.com> <20260825100912.514232-2-matthieu.longo@arm.com> <87ld99e5oy.fsf@redhat.com> Content-Language: en-US From: Matthieu Longo In-Reply-To: <87ld99e5oy.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PA7P264CA0249.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:371::16) To AS8PR08MB8659.eurprd08.prod.outlook.com (2603:10a6:20b:563::10) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB8659:EE_|FRZPR08MB10967:EE_|CPH1EPF0000052C:EE_|DBBPR08MB10433:EE_ X-MS-Office365-Filtering-Correlation-Id: 080cc22f-afc1-4e59-f141-08df14ab7375 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; ARA:13230040|376014|1800799024|23010399003|366016|22082099003|18002099003|3023799007|4143699003|10067099003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info-Original: ROlv6tQLdBU4o1/q1uaCEIAkctWkMJS7tLv3nhyDycHrESzNrFZTDW2oDhYpBRMcrUCTOx5c8aMA/JUL3OtrMlPDnM+pjOu72D/XTKnjMrlcVRCD+kDEELVa0f1lB1S4xz4ViGR1laevD2dU2PdEko/2WcqhiMI22d+aOPCNF2t1Q70ohR3z5kzvKY7i3wAqiIX94Xjxz6/sg2h8bgPiIhaCsGw6sxbBsf+pW/0TXLMS5HjBvxbJU09dv+LYYPIbhzEJp1B+pdtpxDmZpcGoxhxybC3JiW2ZsTWUK3RdfjzcHkUMCDnQpLUsPRWf/4fLMTfoyqQaGvA2LxM9Mwgv9M4dBJBha5TVrVuOErRtfx8TBrk6sZ81+cxTmpgpJt6dyk+5QP97LnwyvJY9TIqSOCQf5xTHLxjz2STbKTsWJZBBEGrwEiDautZVFkqOJUP1M+uZC4UJ29JMJlM5EiYWqT2vaNl5erv6zyxYKqlotXbdeT7dQ2EHYnFMf4zESeX3Dtrdgd2C+bKnvuGCIXhpFd8NJrUu0CP5+KL8lKNWtVj5+FeMtSxxSIgibZkKJog90Lek9JOhaenA+7Wz//KYLpbVEVLjTlMVc/PhTfYxdr2HoCwzGHLf8ADe4iaejNKXP2FNtXPrIUVTt6Uc96mZsCdYBNvWQ89Rn4fA1kaLoTY= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR08MB8659.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(23010399003)(366016)(22082099003)(18002099003)(3023799007)(4143699003)(10067099003)(11063799006)(56012099006); DIR:OUT; SFP:1101; X-Exchange-RoutingPolicyChecked: MS7bJe6u8V6gMV8mYc3MfMredXSBmtS9rwJgLwDuRYeuEl/PT9uK6hLjSb0fHm88l5Sg51GqsovyVSSwbzbL1reiCNdX9AzMoE2lZ7elWyldsZUp2/IVhPFXOR3rAOHUTn3UzrV2AwHFH8ksNerKVEDJeZ3rHFrttpGCn5v40KMIR92ZrkRDCtbAUOEboxvckLrgrGZvbkYeaT3rt9QBn5Dk5H1jPYhHMrptwwm75GnBh0i4anqkKn0QctwwzZEZwM3hqQakbPuWwkZ7jOetAalEdPlWg6SDaClgnWTXs2r+qSryx5bdhKM8LnaCSOQWy8m5SIU7XlyGWXpg0cV8QQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: FRZPR08MB10967 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: CPH1EPF0000052C.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: daf0c229-c874-4564-4890-08df14ab5fcf X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|23010399003|376014|82310400026|36860700016|35042699022|14060799003|18002099003|22082099003|3023799007|11063799006|10067099003|56012099006|4143699003; X-Microsoft-Antispam-Message-Info: OGbXgnMxAka7C3HvJ8K4iwr9Jvp2UOUG8SuZfZ2LETXL33uviDSTUipmqFzym9ROdVwlY4E3k14NZ76vhFDDMgC0gfh/ATCJvC+Xn1JWw5Sk5tpIaWIy8TboOAVWQgIoeACmCRhzdDtz5hpC8xtg1/odVC9qzpgFjK5rC1amN31bNsy/IKmf+XmDKBW0ETm1gZE6H2TP7So707F1ujTVOiBan3D/HEe0DSOTRjHbVMLCmMFTfCw0tNMzz7OGwmVwJYHEy4bnpiOWfqJ52bc2HicN2KNiVueauQFwHe7L9IX4k5jwEP4/sk6jAJPMzOpTAhS3ox2jgQeooWwdAj+Oqk7Sqfx6KECdBqxLy1p1MVHWwR0B5KDVJPwctLDk/DlZwfkfDrFI/2YM+ArDC8PK3FvPkbcJUNeEfg3NofsnehOL+25UmHdLTuqBEbbgio3sDED5gnH0PG1mqqhd6aYaPU1j2A/ARYCrGedmaGG4mNXLE3Gq/qqlVvPBYy2wck5JvGWIESKYANVRJACB3NVygSrm4U18kKcYG2bQUaxptgPele30k9b4fc38XBntQI7LWMJz6gDZq3X9JI/XbUF6Ocmx/jsUHwuyu5/n4FJ76VxsK+rXIR81yQgWKDNbWkNnSQcl/AUQ4Lz673xM2pQCzn9+6yyPwBShlRCQzavM9JCWR9FRo/NUK5PmtWruaDrQZxxgpgw118uCl+I2pDiI/Q== X-Forefront-Antispam-Report: CIP:4.158.2.129; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:outbound-uk1.az.dlp.m.darktrace.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(1800799024)(23010399003)(376014)(82310400026)(36860700016)(35042699022)(14060799003)(18002099003)(22082099003)(3023799007)(11063799006)(10067099003)(56012099006)(4143699003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: OWhMiJ6USKVexVtXo7dAGAhMDByowBeJcPboi7FKYvTCFj/cUpX6fvm/M2l1Y6lizHw45hCxhX2skNTXyy00GiR/L/R9Pjz4E4WxcmFQ+MCgM3R8lfHb696jpYROPcKxQTuWLLxBPUn6ogSi++D/BIyeUkINB+4283Mv3+UKXUj8L7ayPRga2LFnZq9XuWDU++IumPqTCFehsZRscRX3quOdeHb+guSLnrXVCDwxJw+yaMv/C3bORDDZVdzeuloUZfH/amqb+DwWZ5B7gdPCEPL5WV00bUbLMUMFhArFflB8shcM0PITQ56WIRGle86jX4GL/G1sGoQpFE4WxjSRQjVYLM/blry0gtrxtEZT2RnEljMtv1i7zjQEY7gbzbToIB6dyGkKpCo0G6ppsChZRYzQAgJ8EE+3BZolBeHteNv/Ao8+hBMfy/3+az5gWtyD X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2026 11:04:31.7327 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 080cc22f-afc1-4e59-f141-08df14ab7375 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[4.158.2.129]; Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: CPH1EPF0000052C.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB10433 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 10/09/2026 11:55, Andrew Burgess wrote: > Matthieu Longo writes: > >> Extend target_fileio_read_stralloc with an optional output parameter >> that returns the number of bytes read, excluding the terminating NUL >> byte. >> >> Most callers only need the returned NUL-terminated buffer and can >> ignore the new parameter, but callers that need the number of bytes >> read can now obtain it without recomputing it. >> >> While updating the function, make a couple of minor cleanups by using >> '\0' instead of 0 for character literals and clarifying the function >> documentation. > > This looks fine with on minor nit, see below... > >> >> Reviewed-By: Thiago Jung Bauermann >> --- >> gdb/target.c | 11 ++++++++--- >> gdb/target.h | 20 ++++++++++++-------- >> 2 files changed, 20 insertions(+), 11 deletions(-) >> >> diff --git a/gdb/target.c b/gdb/target.c >> index 5d937f3ae85..ebf0f30092c 100644 >> --- a/gdb/target.c >> +++ b/gdb/target.c >> @@ -3547,7 +3547,8 @@ target_fileio_read_alloc (struct inferior *inf, const char *filename, >> /* See target.h. */ >> >> gdb::unique_xmalloc_ptr >> -target_fileio_read_stralloc (struct inferior *inf, const char *filename) >> +target_fileio_read_stralloc (struct inferior *inf, const char *filename, >> + LONGEST *len) >> { >> gdb_byte *buffer; >> char *bufstr; >> @@ -3556,17 +3557,21 @@ target_fileio_read_stralloc (struct inferior *inf, const char *filename) >> transferred = target_fileio_read_alloc_1 (inf, filename, &buffer, 1); >> bufstr = (char *) buffer; >> >> + /* Note: on failure, target_fileio_read_alloc_1 returns -1. */ > > There is no needs for a 'Note:' prefix. By definition, comments are > things about which we should take note. Just: > > /* On failure target_fileio_read_alloc_1 returns -1. */ > > Is fine. > > With that fixed: > > Approved-By: Andrew Burgess > > thanks, > Andrew Fixed and merged. Thanks, Matthieu