From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id /GjgFvzI7WYrojEAWB0awg (envelope-from ) for ; Fri, 20 Sep 2024 15:11:56 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CVMJuHx4; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3103A1E353; Fri, 20 Sep 2024 15:11:56 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-12.8 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8CF4E1E08F for ; Fri, 20 Sep 2024 15:11:55 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 291C03858435 for ; Fri, 20 Sep 2024 19:11:55 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 38DDE3858D39 for ; Fri, 20 Sep 2024 19:11:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 38DDE3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 38DDE3858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726859497; cv=none; b=f9jcLZMfYHS1DjClOultJn+w2KdPDazEZoOqnFpHeg8ZK8dKdBiG8xv4oEmOAwyjZvfTWHLw/cemBYC5FKdD32uMQijTaP3ur00cN8VGEC44PMdfXOTGO+Q1lGIVqkq4emvpLaiTXWLgdA0vcNdpr966OEne1bVTEzcNn/jE9fs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726859497; c=relaxed/simple; bh=J89IcRD0WVgnQoKCYW3IE5ZSjO0NfMlApHfXswefBZY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=SFbiaiwwl9+UOtmB6FYn0zi+6LhlrDGven+a5OksQYkdJ/CzOA/PNh9Q/gqhVAm0X7YOxHKZRvWmM7EVuk2vytVCMZM8VqyRf/pcvRRdTo9aon3PXWT3goggVyDrqeTrEqiqkkEL1xVS03JLg6eVNdfz3kebbctvhK8FHHnR8qE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726859494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8aBSZih9DR0Cq+yg+lTU4dwgIG4KLySR6OfZ53Jg3fg=; b=CVMJuHx4DX4XUuCXjfQ3RkvozQYIrHJE7znQhcN56iSsNCan70KtyHYZNXPmZneZmq2jvw szgT/cFJARq0o03C4byJBVYbl7NCWXF5DxJeppZS64jwz2iy25RHYWsfXm7J3J1FSdc5KN NocBMUw6ZDP5QZTQP7CMoSI0pn3VoNw= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-609-pYyeMUrmMnG23SqCHjSWOQ-1; Fri, 20 Sep 2024 15:11:34 -0400 X-MC-Unique: pYyeMUrmMnG23SqCHjSWOQ-1 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-45828d941f1so41975491cf.3 for ; Fri, 20 Sep 2024 12:11:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726859493; x=1727464293; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8aBSZih9DR0Cq+yg+lTU4dwgIG4KLySR6OfZ53Jg3fg=; b=la52w+PMaL3ZsSrVIeA70NqSsXp32TbGqCPssZr46b5dXSzQoOxLoGgtD993L0JHsb qQeVk3jHVfuh4RXe61o6zjFX0lHTCHE9NdwvTUHRB9Cn7Kizs85uwQfFg6dzuBLdqsqK x4bBgI/izSRKPlwzCPpf8icNZaVWYYCpWeqf3PqEhpHVy6SV8yyqrCoxbFVMOyuBxT/r 5LsM0NtZ00pMbJcytto5vDrooem7KOn4aUGYWdsiuYKjswvnKzJfB/bk6DKGvXjhql2z iEAD9Y8e9027MXKuILkwSmmlWfdUGvyFeiqjhdNgTuXtLzc12QVO3TNU/tWMniyOXrix p1gg== X-Gm-Message-State: AOJu0Yy8fxn4fpBZTFknuHM2kFlPQ6HppUKEJiJa/xbsVikZPcNcrhOi XPNd+Ob+GMvmTyvNW/r+VVjEGUKDPHWoecmH+w9xpNhnoAYp6yil39cVRSq08bwyTTMmpTnytZU AqgJI5AQWZePEnGpZ9tO84lgYvQ5MDqZ+XNX0gDVVMKlRqifuk5SNdDtGqXY= X-Received: by 2002:a05:622a:4d1:b0:458:1957:b925 with SMTP id d75a77b69052e-45b204e0743mr73234521cf.8.1726859492028; Fri, 20 Sep 2024 12:11:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGJ4sXSRa1ui01MmS46msrVJP/1X190H/OEpartiziJH0dQb+gP3Flhq4shk+ID3Laz75j6oQ== X-Received: by 2002:a05:622a:4d1:b0:458:1957:b925 with SMTP id d75a77b69052e-45b204e0743mr73234131cf.8.1726859491668; Fri, 20 Sep 2024 12:11:31 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:92c5::1000? ([2804:14d:8084:92c5::1000]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-45b1788c181sm21285611cf.52.2024.09.20.12.11.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Sep 2024 12:11:31 -0700 (PDT) Message-ID: <2e594120-cf6a-4c4b-9413-5b0cdb0456f4@redhat.com> Date: Fri, 20 Sep 2024 16:11:29 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/testsuite: rework bp-cond-failure to not depend on inlining To: Tom Tromey , Keith Seitz Cc: gdb-patches@sourceware.org References: <20240919124204.1465834-1-blarsen@redhat.com> <1940030f-122d-4656-a293-44e5b5a98c92@redhat.com> <87setunoiq.fsf@tromey.com> From: Guinevere Larsen In-Reply-To: <87setunoiq.fsf@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/20/24 3:55 PM, Tom Tromey wrote: >>>>>> "Keith" == Keith Seitz writes: > Keith> On 9/20/24 9:20 AM, Guinevere Larsen wrote: >>> I've given some more thought and I think a couple of comments could >>> help anyway. Here's my suggestion, thought? > Keith> I am pleased to have an explanation there. Thank you! > > FWIW I read through this and it all seems fine to me as well. > Thanks for your review Keith. > > Approved-By: Tom Tromey > > Tom > Thanks, pushed! -- Cheers, Guinevere Larsen She/Her/Hers