From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id JMrSJAj0ymjQLAgAWB0awg (envelope-from ) for ; Wed, 17 Sep 2025 13:46:48 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=dzXKhBsk; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 84C011E04C; Wed, 17 Sep 2025 13:46:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8D0AD1E04C for ; Wed, 17 Sep 2025 13:46:47 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EFD423858C30 for ; Wed, 17 Sep 2025 17:46:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EFD423858C30 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=dzXKhBsk Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id 5CC203858415 for ; Wed, 17 Sep 2025 17:42:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5CC203858415 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5CC203858415 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::62b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758130961; cv=none; b=NmI8BsoVqab40NLBP1/D3TrBSqHGdW4yXh+aSIretvEGbdIRLKfR8rUTqrL7c7eRY56XNNWClridFp+5RCTa8vOhAXHOmtXXGHrerQF0VOb6REVsmhK/Uz4ds+cWoUbHXS1+ZH/U6UTUsNQMiCrTiS771mFEX0Jokn60zN2OSJQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758130961; c=relaxed/simple; bh=B3iAGOhZyVZjgCHf1M4BtsQqrw9qV61iblMdpN2HO1o=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=JZpbewfCLyx93+noH0tuDSwKnMzXPrVEinkGiSOWxIR39mNJWvcXLtK54NHsdo/sPB9CXavOVv+mwJJ60Ex7pmOI5cKhVbcoqrvnxW2g67RjMYeR8fN4KWzeKZ4PjysydYscs4VBY2tOpnc/CuiHKOVbPp+ZRQ+XhuCotfu7YAw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5CC203858415 Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-b0411b83aafso9200566b.1 for ; Wed, 17 Sep 2025 10:42:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758130960; x=1758735760; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YPy84lejrM+ZE6x9oeg976aP6vO/ZVDLMVmkTcDBxNc=; b=dzXKhBskc2tepzsSvi3t3F2up95Pl/o3IUQ3bJ2h70PMg8uZgT79Jx0b/dDsoquiEx Ai95buGE8YG/m5NaoK3p6KptNaK6IWlqk1Q7wnrVR0324kfy+FDBf3V3B6a2QbixKCcF 25HLZ3f/LjMKKESzsrE3CQBaSdqzUwVnKudwZXYU0rwOs3s/RYe5qKMOlLlqLROJvD5r wdtM6wKGJutBDwtXYzT7ScT0H2CU8nMSTMmVWIWg5vYV0kr9z9s0QNbjASVLAEUmBJFS FELofXew+FqQCcReZ02hmK+53sBiAFLH1EjpDcJ4ZiyJtYjgXQJIEIgMcD74EfEXBwdH 6G3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758130960; x=1758735760; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YPy84lejrM+ZE6x9oeg976aP6vO/ZVDLMVmkTcDBxNc=; b=hZURdyv3vW9hymdhmod5eIJcGtWHhex8smr7mV6LE9q5Rywd9yN51GLjduj/MkJoT+ Rl5KsxgfoUjS4LUN6mQ48GHfFzVEtA9wjnZkML/KKfjHza6QzL8e6kCpXfqQA95AVetj yLkBLpbGfd33RjITKR4FhXji8E8Fn4cN6+l6frzv5pouMR+JpV9EW+xJ6Q9Tb3hYV0ch aUyBKMbebOlULFCmpXhl5eIyw6RXD7qKOV05ZxF8R1I/uNCRXfY92EQtga7CARyhrOaO zcCQNz1T66tD3iETpVIFNCxHblF+R9LiLCmPRyUJM0pEQnQ/B9Cwtjs61gTnp4u0f3xC kAqQ== X-Forwarded-Encrypted: i=1; AJvYcCUTJWGP1fw9BQ8Hh7+aTOB0vMVaoUVu1rT4kstw1+haIVsgB0agIEKriR0jrKEGOeIqm6GPqut4MfS3UQ==@sourceware.org X-Gm-Message-State: AOJu0YzBuyTNXwnM2xnRTJkGkVRWIl1RY7/iRShH+1v7S415U7IZOJZ5 rfxh7tbQHUmfz7w5R/3d7mitEz70XMxsqAeXTgzCoNxlFVkpT8Dcnils X-Gm-Gg: ASbGncuRFCiwecz9SK9jPaM7GmUAbPPnpiMKnyCCN/1kxUO+biystJEBGByXnaYCc4n dewc67b6upyStCdkvogg9mL4lY84D2TlPGtpfEl8Wj9YwN+n6zK8cEzMG7N6R21d/a00T+l8aSF a87IiUS2hv913ISfDf/JB9XRP/Wsz+DAvETfhuI2cwUZAdt5DzjWBHosSPJWmC5AB+roKXAcITA xKkjOc1eS6BHA9ahLTwjgyZvP4nGUxTSJDDtSiyIBwMsGzn36OpUuBixUdIDLGvPOzlbt9m7Q0I QQHNnDaLj9B2jfAdwb4568udsNl5ShxEERG5bZ/PFwQlXpBwXtXk/ziQWn4VFinGpG3geIVTP3l gPm9WxwMu9NRH4AbIoXINjSmSJmy1HZIgkfV7Pn3XzQ9fqQ== X-Google-Smtp-Source: AGHT+IFfMzIp3c8nyqNIPFoWt2HxWb492XFr12WqTtVuW2J0G8XLggcKkUxrLIxtW1h/lTH5UCVljQ== X-Received: by 2002:a17:906:f592:b0:b0d:61a0:9a28 with SMTP id a640c23a62f3a-b1baf60b87cmr296557766b.6.1758130959980; Wed, 17 Sep 2025 10:42:39 -0700 (PDT) Received: from [192.168.0.38] ([86.12.216.189]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b1fc74af9f3sm16287266b.38.2025.09.17.10.42.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Sep 2025 10:42:39 -0700 (PDT) Message-ID: <2e586040-adbc-4a66-96ef-8f6364af4abb@gmail.com> Date: Wed, 17 Sep 2025 18:42:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] GDB: aarch64: Use GCS features to calculate hash of struct aarch64_features To: Thiago Jung Bauermann , gdb-patches@sourceware.org Cc: Joel Brobecker References: <20250917010349.263373-1-thiago.bauermann@linaro.org> Content-Language: en-US From: Luis In-Reply-To: <20250917010349.263373-1-thiago.bauermann@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi! On 17/09/2025 02:03, Thiago Jung Bauermann wrote: > Luis noticed that when adding the gcs and gcs_linux members to struct > aarch64_features in my Guarded Control Stack patch series, I neglected to > modify struct hash::operator() to take them into account > when computing its hash. > > This can cause GDB to use the wrong aarch64_features object during a > debugging session. > > Regression tested on aarch64-linux-gnu. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33440 > Suggested-by: Luis > --- > > This should also be backported to the branch. Unfortunately I'm not able > to set the target milestone in Bugzilla. > > gdb/arch/aarch64.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/gdb/arch/aarch64.h b/gdb/arch/aarch64.h > index 679d845df74e..0fcdba7fb7d6 100644 > --- a/gdb/arch/aarch64.h > +++ b/gdb/arch/aarch64.h > @@ -94,6 +94,10 @@ namespace std > > /* SME2 feature. */ > h = h << 1 | features.sme2; > + > + h = h << 1 | features.gcs; > + h = h << 1 | features.gcs_linux; > + > return h; > } > }; Thanks for the patch, this is OK for both master and the branch. Approved-By: Luis Machado