From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106815 invoked by alias); 25 Feb 2018 23:52:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106806 invoked by uid 89); 25 Feb 2018 23:52:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=HTo:D*COM, HTo:D*GMAIL.COM, H*M:40fe, HERE X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 25 Feb 2018 23:52:36 +0000 Received: from [10.0.0.11] (192-222-251-162.qc.cable.ebox.net [192.222.251.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id AE3CF1E584; Sun, 25 Feb 2018 18:52:34 -0500 (EST) Subject: Re: [PATCH 0/7 v2] Class-fy partial_die_info To: Yao Qi , gdb-patches@sourceware.org References: <1519313796-2397-1-git-send-email-yao.qi@linaro.org> From: Simon Marchi Message-ID: <2e05d08d-9e11-40fe-05d1-25a093a6cd47@simark.ca> Date: Sun, 25 Feb 2018 23:52:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1519313796-2397-1-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-02/txt/msg00370.txt.bz2 On 2018-02-22 10:36 AM, Yao Qi wrote: > When I fix some issues related to dwarf, I class-fy partial_die_info as > part of the fix. The class-fication bits can go upstream first. > > This is the v2 of this patch series, v1 can be found > https://sourceware.org/ml/gdb-patches/2018-01/msg00505.html Changes > in v2 are, > > - Don't move the location of partial_die_info::fixup_called, as it may > increase the memory usage, > - Add some comments to read_partial_die, > > *** BLURB HERE *** > > Yao Qi (7): > Re-write partial_die_info allocation in load_partial_dies > Don't check abbrev is NULL in read_partial_die > Change find_partial_die_in_comp_unit to dwarf2_cu::find_partial_die > Class-fy partial_die_info > Remove one argument abbrev_len in read_partial_die > Move fixup_partial_die to partial_die_info::fixup > Move read_partial_die to partial_die_info::read > > gdb/dwarf2read.c | 337 ++++++++++++++++++++++++++++++------------------------- > 1 file changed, 183 insertions(+), 154 deletions(-) > I went through the series again, I sent a comment on patch 2, otherwise LGTM. Simon