From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QqkpG470dGoiVA4AWB0awg (envelope-from ) for ; Thu, 06 Aug 2026 16:54:38 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=fmG/GG4a; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 418A71E09B; Thu, 06 Aug 2026 16:54:38 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2 autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7E7E81E09B for ; Thu, 06 Aug 2026 16:54:37 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0A5204BB58A2 for ; Thu, 6 Aug 2026 20:54:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0A5204BB58A2 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=fmG/GG4a Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 1B8474B9DB68 for ; Thu, 6 Aug 2026 20:54:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1B8474B9DB68 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1B8474B9DB68 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786049653; cv=none; b=U9BWwtCHj025SiPuwPUT1fiCDM8Rz04Sm4uqMMh6OEtVqLrv+A9rxUhnudPqXoYVU94hlBEz4Z9Medsm+Tj9wPHJVsM1IcyWHJ1OsiAN0SbprdrlL15x9w0Wf7Zbd87+zoXrwy7AqDl1KPQ+UsYnvrKp/j5A7jV5iWhF+ayTwv0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786049653; c=relaxed/simple; bh=LQx27dg1+nkXaeaRxp4Bnn2Tcpzt6ncwHX1Xr1swU5M=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=Kw2VElh6TnUNOHbBFFFtzhrakbPoR0gzbh6Pid17Rtgn9BA3EDN5OP+Js0dZDcwOb/VrUjKEb6dBv4AI+7RrRydA+dUyEWb+0AEt12YUAtqpwWc32ngdrpbuzUFdRh75kLR236XvYEQWVFQohVPQFehHQhXxs9wiGZiaatDlEQY= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=fmG/GG4a DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1B8474B9DB68 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786049652; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4bwWWYATLdy6pmVLGHoQpumfGWozSj//Scdrzxr2w/A=; b=fmG/GG4aK7yJBMYXrLKWfdPPSDc+4ZNsFf55Z8qIxOCwygBJLcHRfmj0rFnS9P5Kzv8JUB rVwwZoO7QIPd057ZhKQ1o3Ob36F0CXpv0pecvwGVGUkfqu5ZoY2wM4PJudxGw3Lw4/lJYA 2HR6QacbYqfL4Sp+VaSUjpoKJShRW+I= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-125-OzxQlfgvNQiz_jLy6hP8lg-1; Thu, 06 Aug 2026 16:54:11 -0400 X-MC-Unique: OzxQlfgvNQiz_jLy6hP8lg-1 X-Mimecast-MFC-AGG-ID: OzxQlfgvNQiz_jLy6hP8lg_1786049650 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-496bbcf7d1eso16330155e9.0 for ; Thu, 06 Aug 2026 13:54:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786049650; x=1786654450; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=4bwWWYATLdy6pmVLGHoQpumfGWozSj//Scdrzxr2w/A=; b=G2js8eLMAfkzBthW93MeRU3BpC0CaXe9+gQDfYB8otlsSDo7qTDZeAzM3lkHnV4ZOL pQWnIXAuEqDNrpwzfunaQkJfOCdj88NJ/CbTkqDBQD/GYIElaUyow2xo9PVaKGN0inM7 +J9fOk3AzYNBvgG6ymsBjP6w2v8BfkMzn2rmj/uC50vWjPOpkXqp/eYeJprkybS6/Iqk plwCynTARTxKfR7ASmo79MmPgxG4RqJJZSr2zCjBbzqn7x13DCH/+oH3yExOXikqbYOy P3rY/ryiq+Wr1oEuysxqjQlp4jKmYN7wEjcrTgAEWZmUXj06sUlSgLhmnaboFj+b3L4+ PDNA== X-Gm-Message-State: AOJu0YwtlcMTjG28k2+0ZMkVWH9QqNg6A6VztfE0Xo5xS9qvrQDwGhZE drmhJZVNfJMzmkf8gmzQfS5R6AY92gN/6zczs48MRlbvWbZr0zpIGQJd9nDy33h9RTUL75uCpyz 6s6eUg5rBqwLno8NCLttlwRKafRmK6gYu0GmJ7i82Cz0Rx2XDMmIEFlka0Qm3gEf1beJJLQaRC7 vRoeBR/TAFTVogx8M7g0bfIFcvraROmpU0/dKkvCb28izwOQ4= X-Gm-Gg: AR+sD12o8Ik03NElZM/Jslj/nxyed8O51AkfGKHnTcki3ak2Ft7jUXugty0D+1InHJF dKySTDLMK6KW2T1MeUHz/jyjITg9Bx3rQPfVTfJ2adMI3ocdTJrFadXUE/M+ZEGKIkbpmJfV3qP iyHt1ns1c0o4Q/eqcrSTL2dDgi5fGyn0NUEB4z2hESWPaYgEuiWyJujBRArgkt+VxRYwLMLidHG ESR4xURBVF43EWR6Y048sDscKmVEeFr+xwEpzrQP/9GyzOgqwJDpOXHka3txPVTb3f3ViDT//vt EDjvfnZDzAD67EeNhD4xsGmXdc+aQ44x6PjsvBUVMpq0ylWiVkQAvzGo+bHwK5AHOKh8qZtXy42 3ClCWAHn+vakLoCGaz0TO1cpR X-Received: by 2002:a05:600c:c3cf:10b0:499:49f2:bb86 with SMTP id 5b1f17b1804b1-4994e71af2bmr217663845e9.6.1786049649801; Thu, 06 Aug 2026 13:54:09 -0700 (PDT) X-Received: by 2002:a05:600c:c3cf:10b0:499:49f2:bb86 with SMTP id 5b1f17b1804b1-4994e71af2bmr217663445e9.6.1786049649287; Thu, 06 Aug 2026 13:54:09 -0700 (PDT) Received: from localhost (227.114.208.46.dyn.plus.net. [46.208.114.227]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499542183b2sm98000775e9.4.2026.08.06.13.54.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2026 13:54:08 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 1/2] gdb: use inferior::threads instead of all_threads and a PID filter Date: Thu, 6 Aug 2026 21:54:00 +0100 Message-Id: <2dbabbed902e38a1d4534fd7ecd3362331f71ea8.1786049312.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 3ugfV4dIt9tH367-C4Mx3hkFfGiu070EzNTaAwIderc_1786049650 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I noticed a few places where we iterated over `all_threads ()` but then immediately filtered by PID. It would be better to instead iterate over `inferior::threads ()` and remove the PID filtering. These should be equivalent as a single inferior should contain every thread with a given PID, and should only contain threads with that given PID. While editing the `for (...)` loops I have replaced 'auto' with 'thread_info' for additional type clarity. There should be no user visible changes after this commit. --- gdb/mi/mi-main.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/gdb/mi/mi-main.c b/gdb/mi/mi-main.c index 8b6da41ffeb..903c6a5f411 100644 --- a/gdb/mi/mi-main.c +++ b/gdb/mi/mi-main.c @@ -359,14 +359,11 @@ mi_cmd_exec_interrupt (const char *command, const char *const *argv, int argc) scoped_disable_commit_resumed disable_commit_resumed ("interrupting all threads of thread group"); - for (auto &thread : all_threads ()) + for (thread_info &thread : inf->threads ()) { if (thread.state () != THREAD_RUNNING) continue; - if (thread.ptid.pid () != inf->pid) - continue; - target_stop (thread.ptid); } } @@ -603,14 +600,13 @@ print_one_inferior (struct inferior *inferior, bool recurse, if (inferior->pid != 0) { - for (auto &ti : all_threads ()) - if (ti.ptid.pid () == inferior->pid) - { - int core = target_core_of_thread (ti.ptid); + for (thread_info &ti : inferior->threads ()) + { + int core = target_core_of_thread (ti.ptid); - if (core != -1) - cores.insert (core); - } + if (core != -1) + cores.insert (core); + } } if (!cores.empty ()) -- 2.25.4