From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id lr26Eku75mOkgy8AWB0awg (envelope-from ) for ; Fri, 10 Feb 2023 16:46:51 -0500 Received: by simark.ca (Postfix, from userid 112) id 4011E1E222; Fri, 10 Feb 2023 16:46:51 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=PycVuX7q; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id ECDD61E128 for ; Fri, 10 Feb 2023 16:46:50 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 44BCA385482D for ; Fri, 10 Feb 2023 21:46:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 44BCA385482D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1676065610; bh=7VrPDgeicgNQG9jx8V1cKiLAqLlVHadaFPklUKzQuNI=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=PycVuX7qlwOC4Ac5NtOosC57ugfzDxqiAU4xuHC5ASuxKXIRJDyAGtyGO0BXP4j4T hLd6kNfIBAuPN09XAajEh515misRl0HZZnPHK+2oy2szQOxv8CQ1af7XchedJ+Bpyp m7CCpWG8+ML2XtNMICuDzaMCPHeI9g24ddy2zIkM= Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 1F4153858414 for ; Fri, 10 Feb 2023 21:46:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1F4153858414 Received: from [172.16.0.192] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 5818F1E0D3; Fri, 10 Feb 2023 16:46:30 -0500 (EST) Message-ID: <2daa1736-57cb-3c5a-f1cd-48f5aa03d010@simark.ca> Date: Fri, 10 Feb 2023 16:46:30 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v5] gdb/gcore: interrupt all threads before generating the corefile Content-Language: fr To: Lancelot SIX , gdb-patches@sourceware.org Cc: lsix@lancelotsix.com References: <20230130165110.1440365-1-lancelot.six@amd.com> In-Reply-To: <20230130165110.1440365-1-lancelot.six@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 1/30/23 11:51, Lancelot SIX wrote: > Hi, this V5 follows > https://sourceware.org/pipermail/gdb-patches/2022-December/194504.html. > > Changes since V4: > > - Update gdb/NEWS to fall into the "Changes since GDB 13" section. > - Use "build_executable" instead of "prepare_for_testing" in the test > to avoid one useless start of GDB. > - Updated the test's description. > - Updated the copyright year to include 2023. > > Best, > Lancelot. Hi Lancelot, It seems like this version does not address the comment I made on v4, the "what if a thread is doing an inline step" when we call this. Maybe another way to look at it is, if the inferior was resumed with schedlock on. Only one thread is "executing", and any_thread_of_inferior could fall on a non-executing thread. Also, we'd want to end in the same state as where we started. Can you check that case (with schedlock)? I have the feeling that it's not handled. Simon