From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94116 invoked by alias); 27 Nov 2017 17:14:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93825 invoked by uid 89); 27 Nov 2017 17:14:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 27 Nov 2017 17:14:19 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 31D6B13AAE for ; Mon, 27 Nov 2017 17:14:18 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7A97760600; Mon, 27 Nov 2017 17:14:17 +0000 (UTC) Subject: Re: [PATCH 39/40] Breakpoints in symbols with ABI tags (PR c++/19436) To: Keith Seitz , gdb-patches@sourceware.org References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-40-git-send-email-palves@redhat.com> From: Pedro Alves Message-ID: <2d861c5e-dc35-a06f-7c80-06e0f78df9ba@redhat.com> Date: Mon, 27 Nov 2017 17:14:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-11/txt/msg00693.txt.bz2 On 08/09/2017 08:34 PM, Keith Seitz wrote: > On 06/02/2017 05:22 AM, Pedro Alves wrote: >> gdb/ChangeLog: >> yyyy-mm-dd Pedro Alves >> >> * completer.h (completion_match_for_lcd) > mark_ignored_range>: New methods. >> : Consider ignored ranges. >> : Clear ignored ranges. >> : New fields. >> * cp-support.c (cp_search_name_hash): Ignore ABI tags. >> (cp_symbol_name_matches_1, cp_fq_symbol_name_matches): Pass the >> completion_match_for_lcd pointer to strncmp_iw_with_mode. >> (test_cp_symbol_name_cmp): Add [abi:...] tags unit tests. >> * language.c (default_symbol_name_matcher): Pass the >> completion_match_for_lcd pointer to strncmp_iw_with_mode. >> * linespec.c (linespec_lexer_lex_string): Don't tokenize ABI tags. >> * utils.c (skip_abi_tag): New function. >> (strncmp_iw_with_mode): Add completion_match_for_lcd parameter. >> Handle ABI tags. >> * utils.h (strncmp_iw_with_mode): Add completion_match_for_lcd >> parameter. >> >> gdb/testsuite/ChangeLog: >> yyyy-mm-dd Pedro Alves >> >> * gdb.linespec/cpls-abi-tag.cc: New file. >> * gdb.linespec/cpls-abi-tag.exp: New file. > > Just one little thing: the PR# isn't mentioned in the ChangeLogs. Thanks Keith. I've fixed that in v2. > [This is also c++/18601, but I've marked that as a dup of this bug which is > discussed more.] Thanks, Pedro Alves