From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id w0qmOrLus2o5+DcAWB0awg (envelope-from ) for ; Wed, 23 Sep 2026 11:22:26 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PzQyks2F; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D031D1E01F; Wed, 23 Sep 2026 11:22:26 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3DD371E01F for ; Wed, 23 Sep 2026 11:22:26 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D12814BB3BA4 for ; Wed, 23 Sep 2026 15:22:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D12814BB3BA4 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PzQyks2F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 436514BA23D9 for ; Wed, 23 Sep 2026 15:22:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 436514BA23D9 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 436514BA23D9 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790176921; cv=none; b=b+aRJCX/wPKB28NHCeHxAaErjSlJ80SMljgnVi7F1TVfn6B13Hdc046QuDgfOxybFPtPtonrlfhnsV+dqKzSdSsQNMLyWZ7pm5nn+5RHXb1T3WCAo/2svwUETSn9yXDmHFmnk/QmhCGYqDr6EGJ5/cDOFWq5rn+fVlbqRqI0Apc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790176921; c=relaxed/simple; bh=6J4/a5VC/Bp6z6xZjVimi7nwiPfNe/0W6b7kDcH7Qg4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=f3lsQBr4jbndmoaId8JAGQ3cftAyZ6Ap4EZUI0aGcUejjV3/yA/UIvPerI5GE69JfBxmYFxWnB8fUOfzPL5eD23HLZtDeeZ7bc11JDtOdIKHabEu9WS626JpPs+2GNq1OiV/CJdkU1vc7ueTBbo7dxzvE4MyAzfMXsBhUCDcfv4= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PzQyks2F DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 436514BA23D9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790176920; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=42gvrJ3Xq4Gv+4l+EYRIXS3PSFbLLMVF8YFlbltEtlg=; b=PzQyks2F0qoAJ1/C23MdlFsP8UCTqW9BeM9sVUNfC/vpuOqxM+TyqRv8PEXiGT5M0oyuLm x5dJW0LF/pwpj9UwA0exO8f8W75SgneyycEA1lwygAV29t/n+BB3eKan72UxNWzXg49ZDH JtwuHm1FoBnxvwnrs74WQ2NR+I0VMic= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-456-eaEqN7UiOzGvT4U5vKyrwA-1; Wed, 23 Sep 2026 11:21:58 -0400 X-MC-Unique: eaEqN7UiOzGvT4U5vKyrwA-1 X-Mimecast-MFC-AGG-ID: eaEqN7UiOzGvT4U5vKyrwA_1790176918 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-91049eac948so17250166d6.1 for ; Wed, 23 Sep 2026 08:21:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790176918; x=1790781718; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=42gvrJ3Xq4Gv+4l+EYRIXS3PSFbLLMVF8YFlbltEtlg=; b=venDdvSdrFOHJcRGCdoJ33Kd7evKem/jf4BsmhBZY839dcPkWAGdkDNIAXwfEtcdB5 mPSIP0GM8NQ36zDO2cmU26dEqbMRyygRAIPdOc9YKes1yIoF/ipIthRmIJOAWyUWGLHG k33lENmZ6DlLAvXc0r2Vq1vAgs5WICAlTxm7tgsco3PjR///mRzMS96W4UJcuBW/yt05 jD/CwG0PnGLlql5Gw3tjQuiBzzX4TSxg78rUz3/9ll/x8PbrkqsqYNyh/C9VR4M3IRdg EG3Qmh9uAbbldZ4P2Ph6rZqdMmFapOAXoWNQTyETcJqIjbKLM8gXSwKIyn3UtmDdDH5Z /vnA== X-Forwarded-Encrypted: i=1; AKwUvBxpCTkxE6MFl6wzzhnB6fTqXtsxiNGqh17I9uuth/69WV1Nrdi/vLDpIJOCSbjHR9x8RnR/DWiDfUbVRw==@sourceware.org X-Gm-Message-State: AFuF++ndFKvQS/kW5Dyfsb4eZnBheV4q0oCb9WhSzXwgNJcobf25MRid pKfhXLemXBr2noG5iLvbWHmzPvac3wvrUVaZrITnJeYO98hUVsaE4QHV7YUa3J4c7TUDVyk/1zx /CefkeyhH9Obr1klbmEMbxwbRbCTdJlxl/AwMhFpq3bccqQJ4m9w0ygfwCU30E6rx+Ba0kwU= X-Gm-Gg: AYBFou1hJEgyJhKSxHUX3tyzzLbFqcPmVIt4/ShsqkSk98Qq+fGiPoX5WyZIU77cjRS Nun2dcE6peca2+n+2pRI3kM9rQuSasaL4lVzuPyY4GCrAUYNeNQD7B3aFLnvP5qIyFKqqe6h1op lAlagk6mj+FbJ72P1Xfl5r4oEZSsPf2UQKFKacICcCQolUgTTlV9WKM8/TGlhsNirsu7C1P2xNJ ZrFo7sOWkRNNXWT/8h+2GBX9meUPweMkSYzosc9j64LHPyJKkjwbssZPf9Y0a9gdQ07ddAoYrhI /jniGPleM8KHPSTQTwNLOoCdNm8kb5NZaPV7jQZYcyoGHH4NA2DM6rPby8/bGH8TCd3POJSseGt swsEstPA= X-Received: by 2002:a05:622a:14cf:b0:530:fbd1:6094 with SMTP id d75a77b69052e-532ead5dfd7mr45760081cf.53.1790176918075; Wed, 23 Sep 2026 08:21:58 -0700 (PDT) X-Received: by 2002:a05:622a:14cf:b0:530:fbd1:6094 with SMTP id d75a77b69052e-532ead5dfd7mr45759891cf.53.1790176917628; Wed, 23 Sep 2026 08:21:57 -0700 (PDT) Received: from [150.1.200.157] ([172.56.108.234]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-532eb364154sm21835811cf.22.2026.09.23.08.21.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Sep 2026 08:21:56 -0700 (PDT) Message-ID: <2d593033-4995-4ba0-8952-be58a8932bcd@redhat.com> Date: Wed, 23 Sep 2026 08:21:54 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] [gdb/contrib] Make gdb-add-index.sh shellcheck-clean To: Tom de Vries , gdb-patches@sourceware.org References: <20260923071343.2887804-1-tdevries@suse.de> From: Keith Seitz In-Reply-To: <20260923071343.2887804-1-tdevries@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Q762bzUMtOX2UDTqZfHEVO0YEiXk_PY3ooWXpXeX1p4_1790176918 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi, On 9/23/26 12:13 AM, Tom de Vries wrote: > diff --git a/gdb/contrib/gdb-add-index.sh b/gdb/contrib/gdb-add-index.sh > index 4a30c5c5536..0c7797d23ed 100755 > --- a/gdb/contrib/gdb-add-index.sh > +++ b/gdb/contrib/gdb-add-index.sh > @@ -93,10 +93,11 @@ if test $# != 1; then > fi > > file="$1" > +set -- Does this "set --" accomplish anything anymore? Otherwise, everything looks good. Thank you! Reviewed-By: Keith Seitz Keith