From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EfG/IHwrfWm71x4AWB0awg (envelope-from ) for ; Fri, 30 Jan 2026 17:06:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1769810812; bh=B2G2Tn2gtxLbBePtyQ0oeGXnc+Ccc6UxDiHISqYlXQw=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=BmvPmAbeeyWAzYuLu6W/KOsfDSZ8KCvRatKZ0V1Cf14R/rVLixjCg4vBpgDpVu50Z 3r3VFGxEvYwW1RDbO7MPchEUb/SfjBXg9nnW7E0n0AtQ1lbcok43ebwapBjRKamc/a U7R/HcqKozjc8V6HDsxITkpZG0JFtpeEmEecW/oE= Received: by simark.ca (Postfix, from userid 112) id 8169A1E0DD; Fri, 30 Jan 2026 17:06:52 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=lsH+vw2Q; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 27EE31E089 for ; Fri, 30 Jan 2026 17:06:52 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 90EC74BA9028 for ; Fri, 30 Jan 2026 22:06:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 90EC74BA9028 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=lsH+vw2Q Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 7DB694BA2E07 for ; Fri, 30 Jan 2026 22:06:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7DB694BA2E07 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7DB694BA2E07 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769810787; cv=none; b=kJKfaNlx162jtXpRwi/BFrAvN94OsKTmnp/Vavl8v8TKlnXjWXXwEyqAaGJAdVoO2K2PVWHRiYJKwriUqFfY4rwOBlBUQIoKArs0trZ7RWL6TiEW4q0l6kVUlrD0LKOp/e5O+Rg5RfKwwICZISFEPOTJLymvQU2zkkhPGEqDCDI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769810787; c=relaxed/simple; bh=B2G2Tn2gtxLbBePtyQ0oeGXnc+Ccc6UxDiHISqYlXQw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=IZIcP+MGtqS+0Ll7mF8/qL9ATw5E5eo5l6HNq3RVTVd/ILhMifaw39iy3IVr2olUjbf+5MUEZDQErBiVhe17H5/XwLqWomzpqn68u54RnBRZIFStfVac5YWUBvRoRwQT8Ku0wn71wsHF5ei4yelHAIUMdBcaPzDUtQQ1+F5ND9s= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7DB694BA2E07 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1769810787; bh=B2G2Tn2gtxLbBePtyQ0oeGXnc+Ccc6UxDiHISqYlXQw=; h=Date:Subject:To:References:From:In-Reply-To:From; b=lsH+vw2QKIiDOHx3b9wajaIGAFyzq4qysdwuzATOHxikZTZVp62P2EJTbZest/zqw ombnT296xIUEahxoIpAunbGYSpvE6S8eBHUphRxJv8Vl3ul4L9qsIQ7By9+K9V6oic L6MN0nwRQPvXs6zZg4vy9VLekB+3kgo2OOavno1A= Received: by simark.ca (Postfix) id 187C01E089; Fri, 30 Jan 2026 17:06:26 -0500 (EST) Message-ID: <2d113fe0-858b-46b6-b941-fc062bc7a2c0@simark.ca> Date: Fri, 30 Jan 2026 17:06:26 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/8] Correctly handle inline functions with dwz To: Tom Tromey , gdb-patches@sourceware.org References: <20260126-dw-inline-fixup-pr-symtab-30728-2-v2-0-8ab183d1911c@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <20260126-dw-inline-fixup-pr-symtab-30728-2-v2-0-8ab183d1911c@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-01-26 16:33, Tom Tromey wrote: > The new indexer does not correctly handle inline functions when 'dwz' > is used to compress the DWARF. This series fixes the bug, cleaning up > a number of other things on the way. > > I've separately regression tested each patch in this series on x86-64 > Fedora 41. I've also regression tested the series as a whole with the > dwz, gdb-index, and debug-names boards. > > Even with that I messed up somehow, so v1 didn't actually fix the bug > in question. I must have modified the patches after testing..? > > Anyway in v2 I've moved the line recording the CU inclusion and added > a comment explaining the placement. I re-ran the aformentioned tests > and didn't touch anything. I read up to patch 6 for now, they all look good to me and good on their own. If you want to merge those right away, you can use my Approved-By for them. Simon