Re: [PATCH 2/7] Arm: Create feature files for Arm target descriptions

[Simon Marchi <simark@simark.ca>]

On 2019-07-05 5:45 a.m., Alan Hayward wrote:
> Add Arm to the list of feature target description targets and generate the
> relevant C files.
> 
> Add arm-m-profile-with-fpa.xml as the feature version of the exisiting
> arm-with-m-fpa-layout.xml.
> 
> Add extra comments to the Makefile for readability.
> 
> New files are not yet used.

Hi Alan,

Note that you'll need to re-generate these files following the renaming
of common to gdbsupport.  It should not be a big deal though.

However, when I try to re-generate the C files, I get this spurious diff:

diff --git a/gdb/features/aarch64-pauth.c b/gdb/features/aarch64-pauth.c
index 931e6cb28410..7bd73a6b21d9 100644
--- a/gdb/features/aarch64-pauth.c
+++ b/gdb/features/aarch64-pauth.c
@@ -11,6 +11,5 @@ create_feature_aarch64_pauth (struct target_desc *result, long regnum)
   feature = tdesc_create_feature (result, "org.gnu.gdb.aarch64.pauth");
   tdesc_create_reg (feature, "pauth_dmask", regnum++, 1, NULL, 64, "int");
   tdesc_create_reg (feature, "pauth_cmask", regnum++, 1, NULL, 64, "int");
-
   return regnum;
 }

Do you see it too?  If so, would you mind just pushing an obvious patch to
fix it?

This patch LGTM, at least the features/Makefile and target-descriptions.c parts
(the arm parts look good too but I don't really know the specifics of the
architecture).

Thanks!

Simon