From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118795 invoked by alias); 28 Apr 2017 14:52:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 118761 invoked by uid 89); 28 Apr 2017 14:52:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=completed, wish X-HELO: mail-wr0-f174.google.com Received: from mail-wr0-f174.google.com (HELO mail-wr0-f174.google.com) (209.85.128.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Apr 2017 14:52:26 +0000 Received: by mail-wr0-f174.google.com with SMTP id z52so35100827wrc.2 for ; Fri, 28 Apr 2017 07:52:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=AuIubQ5u4egWp4hn7nZ7i3tO9k7Pa591rjMYB/Hs+Us=; b=cZtmySPQE4mXR2HtIKgOR6PXUcJSGNmTVqdEPIkNl83ujFDD9ZkxNwHYNCUp38NwOU AlQxqgEZ/ZQ47P1TIhPcQC9KqBDG4N9N90NCT2P7YfWCC3LlaZ6LhGe8WKYHHuRfjA+l mgwSsfT4/3zwE2LomKGSHrqCNZik7PzeBMzvhsVZiI5OGfjilejz1HSZkUpzmhx43X6V GsD8Wsl8htZtOcjOWaOhQVELAZBZhJEWZ+M+F1dCmDB8yTXGgUIJUGD3RBvuuUfW1ANa 68SzK3U4wOK1vMNGSXymoXJJ4yk3ZhEcjz5njiBC2HEA7n1CttOskaIey0cn5prG3GBG F4EQ== X-Gm-Message-State: AN3rC/6PZIy3tlKjJrvOk1rJPKCJdf45nuowR3NlkYfhUE+BA7nl9qxy IQ+FxoQu2+rIe4MeJfym8g== X-Received: by 10.223.170.70 with SMTP id q6mr8993722wrd.162.1493391145983; Fri, 28 Apr 2017 07:52:25 -0700 (PDT) Received: from ?IPv6:2a02:c7f:ae15:7800:4685:ff:fe66:9f4? ([2a02:c7f:ae15:7800:4685:ff:fe66:9f4]) by smtp.gmail.com with ESMTPSA id g90sm7996713wrd.11.2017.04.28.07.52.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Apr 2017 07:52:24 -0700 (PDT) Subject: Re: [RFA 04/10] Remove EXT_LANG_BT_COMPLETED To: Tom Tromey , gdb-patches@sourceware.org References: <20170425194113.17862-1-tom@tromey.com> <20170425194113.17862-5-tom@tromey.com> From: Phil Muldoon Message-ID: <2cc665c2-ea5b-efd3-deac-f2fc61e1feeb@redhat.com> Date: Fri, 28 Apr 2017 14:52:00 -0000 MIME-Version: 1.0 In-Reply-To: <20170425194113.17862-5-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00784.txt.bz2 On 25/04/17 20:41, Tom Tromey wrote: > While looking at the frame filter code, I noticed that > EXT_LANG_BT_COMPLETED is not really needed. Semantically there is no > difference between the "completed" and "ok" results. So, this patch > removes this constant. > > ChangeLog > 2017-04-25 Tom Tromey > > * python/py-framefilter.c (py_print_frame): Return > EXT_LANG_BT_OK. > (gdbpy_apply_frame_filter): Update comment. > * extension.h (enum ext_lang_bt_status) : > Remove. > : Change value. I wish I could remember why I added this. OTOH it could have been a relic even from the initial code submission. Anyway, patch LGTM. Cheers, Phil