From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 12/13] Introduce gdb_breakpoint_up
Date: Fri, 03 Nov 2017 01:56:00 -0000 [thread overview]
Message-ID: <2c6dfb89a82f516d3a2619c47b4acd34@polymtl.ca> (raw)
In-Reply-To: <20171102223612.3642-13-tom@tromey.com>
On 2017-11-02 18:36, Tom Tromey wrote:
> This introduces gdb_breakpoint_up, a unique_ptr typedef that owns a
> breakpoint. It then changes set_momentary_breakpoint to return a
> gdb_breakpoint_up and fixes up the fallout. This then allows the
> removal of make_cleanup_delete_breakpoint.
>
> Once breakpoints are fully C++-ified, this typedef can be removed in
> favor of a plain std::unique_ptr.
>
> gdb/ChangeLog
> 2017-11-02 Tom Tromey <tom@tromey.com>
>
> * breakpoint.c (set_momentary_breakpoint): Return
> gdb_breakpoint_up.
> (until_break_command): Update.
> (new_until_break_fsm): Change argument types to
> gdb_breakpoint_up.
> (set_momentary_breakpoint_at_pc): Return gdb_breakpoint_up.
> (do_delete_breakpoint_cleanup, make_cleanup_delete_breakpoint):
> Remove.
> * infcmd.c (finish_forward): Update.
> * breakpoint.h (set_momentary_breakpoint)
> (set_momentary_breakpoint_at_pc): Return gdb_breakpoint_up.
> (make_cleanup_delete_breakpoint): Remove.
> (struct gdb_breakpoint_deleter): New.
> (gdb_breakpoint_up): New typedef.
> * infrun.c (insert_step_resume_breakpoint_at_sal_1): Update.
> (insert_exception_resume_breakpoint): Update.
> (insert_exception_resume_from_probe): Update.
> (insert_longjmp_resume_breakpoint): Update.
> * arm-linux-tdep.c (arm_linux_copy_svc): Update.
> * elfread.c (elf_gnu_ifunc_resolver_stop): Update.
> * infcall.c (call_function_by_hand_dummy): Update
Just a tiny nit, why not name the type "breakpoint_up"? So far the
convention has been ${type_name}_up.
Otherwise, LGTM.
Simon
next prev parent reply other threads:[~2017-11-03 1:56 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 22:36 [RFA 00/13] more cleanup removal Tom Tromey
2017-11-02 22:36 ` [RFA 07/13] Use gdb::def_vector in sparc64-tdep.c Tom Tromey
2017-11-03 1:25 ` Simon Marchi
2017-11-03 17:05 ` Tom Tromey
2017-11-02 22:36 ` [RFA 12/13] Introduce gdb_breakpoint_up Tom Tromey
2017-11-03 1:56 ` Simon Marchi [this message]
2017-11-03 17:28 ` Tom Tromey
2017-11-02 22:36 ` [RFA 05/13] Remove directive-searched cleanups Tom Tromey
2017-11-03 1:09 ` Simon Marchi
2017-11-03 16:42 ` Tom Tromey
2017-11-03 16:46 ` Simon Marchi
2017-11-02 22:36 ` [RFA 06/13] Replace start_rbreak_breakpoints and end_rbreak_breakpoints Tom Tromey
2017-11-03 1:21 ` Simon Marchi
2017-11-03 16:58 ` Tom Tromey
2017-11-03 17:20 ` Simon Marchi
2017-11-04 16:25 ` Tom Tromey
2017-11-02 22:36 ` [RFA 01/13] Replace really_free_pendings with a scoped_ class Tom Tromey
2017-11-02 22:36 ` [RFA 13/13] Use std::vector in h8300-tdep.c Tom Tromey
2017-11-03 1:59 ` Simon Marchi
2017-11-04 16:25 ` Tom Tromey
2017-11-02 22:36 ` [RFA 09/13] Use gdb::def_vector in ppc-linux-tdep.c Tom Tromey
2017-11-03 1:31 ` Simon Marchi
2017-11-03 17:07 ` Tom Tromey
2017-11-02 22:36 ` [RFA 03/13] Use std::vector in compile-loc2c.c Tom Tromey
2017-11-02 22:36 ` [RFA 08/13] Remove make_cleanup_free_objfile Tom Tromey
2017-11-02 22:36 ` [RFA 10/13] Remove cleanups from linux-tdep.c Tom Tromey
2017-11-03 1:43 ` Simon Marchi
2017-11-04 16:25 ` Tom Tromey
2017-11-02 22:36 ` [RFA 02/13] Remove cleanups from link_callbacks_einfo Tom Tromey
2017-11-02 22:36 ` [RFA 11/13] Use unique_xmalloc_ptr in c_type_print_base Tom Tromey
2017-11-02 22:38 ` [RFA 04/13] Use unique_xmalloc_ptr in find_separate_debug_file_by_debuglink Tom Tromey
2017-11-03 1:02 ` Simon Marchi
2017-11-03 16:39 ` Tom Tromey
2017-11-03 1:59 ` [RFA 00/13] more cleanup removal Simon Marchi
2017-11-04 16:28 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c6dfb89a82f516d3a2619c47b4acd34@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox