From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-134733-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 127992 invoked by alias); 10 Nov 2016 23:19:01 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 127968 invoked by uid 89); 10 Nov 2016 23:19:00 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*F:U*palves
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Nov 2016 23:18:59 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 2E23AC0567B2;	Thu, 10 Nov 2016 23:18:58 +0000 (UTC)
Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAANIurJ024816;	Thu, 10 Nov 2016 18:18:57 -0500
Subject: Re: [RFA 01/20] Introduce gdbpy_enter
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
References: <1478816387-27064-1-git-send-email-tom@tromey.com> <1478816387-27064-2-git-send-email-tom@tromey.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <2c2cef8b-2704-1bc1-34ce-90e372aa264d@redhat.com>
Date: Thu, 10 Nov 2016 23:19:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <1478816387-27064-2-git-send-email-tom@tromey.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-11/txt/msg00273.txt.bz2

LGTM with a nit below.

On 11/10/2016 10:19 PM, Tom Tromey wrote:
> +
> + private:
> +
> +  // Intentionally not defined.

Use /**/ comments.

But actually, since we require C++11 now, use =delete instead.

> +  gdbpy_enter (const gdbpy_enter &);
> +  gdbpy_enter &operator= (const gdbpy_enter &);

Thanks,
Pedro Alves