From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68844 invoked by alias); 8 Jan 2019 23:39:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68818 invoked by uid 89); 8 Jan 2019 23:39:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,MIME_BASE64_BLANKS autolearn=ham version=3.3.2 spammy=am X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 08 Jan 2019 23:39:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/relaxed; q=dns/txt; i=@ericsson.com; t=1546990783; x=1549582783; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Pox1smdL91uwREBUpO01SfpZp7JGsDnwRtwYTWgUW5A=; b=TlrPXxjFLr8GsBH/Xmw4PjZ2coKj7koyizPoDw/fURPbK76/AXZrQjsrIk/ko+51 88PINSuswY/4zSIBPrMbTEe+vXzx+S3fitZTmXc4GuCa9roz3g/v9wYZnWfrL0hR SGB/Cvcwxs+UYw2Y5M4yd1pY2TlyP/VDQPT2UcIlmCU=; Received: from ESESSMB505.ericsson.se (Unknown_Domain [153.88.183.123]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id 8F.76.13660.FB4353C5; Wed, 9 Jan 2019 00:39:43 +0100 (CET) Received: from ESESSMR502.ericsson.se (153.88.183.110) by ESESSMB505.ericsson.se (153.88.183.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 9 Jan 2019 00:39:43 +0100 Received: from ESESBMB504.ericsson.se (153.88.183.171) by ESESSMR502.ericsson.se (153.88.183.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 9 Jan 2019 00:39:43 +0100 Received: from NAM05-DM3-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB504.ericsson.se (153.88.183.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Wed, 9 Jan 2019 00:39:43 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pox1smdL91uwREBUpO01SfpZp7JGsDnwRtwYTWgUW5A=; b=O7RJNJU9Tr7JznLBRqoF/c5OksrPxLrWihtLFVlOEnsSI0k4chxU4IdZrC185DRvx2MuHRUb41zRCPP3Gj2WsCiWCKFdbMtSS5wtZn1q1VhNmjmgZOxt9cbC4nX8Oq7k7c9Bh+/AWuBBfF7QZEGwdZOLYL+jchPvsKXaIH0fhqQ= Received: from BYAPR15MB2390.namprd15.prod.outlook.com (52.135.198.30) by BYAPR15MB2437.namprd15.prod.outlook.com (52.135.198.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1495.9; Tue, 8 Jan 2019 23:39:40 +0000 Received: from BYAPR15MB2390.namprd15.prod.outlook.com ([fe80::a4b4:ea6a:6321:191e]) by BYAPR15MB2390.namprd15.prod.outlook.com ([fe80::a4b4:ea6a:6321:191e%3]) with mapi id 15.20.1495.011; Tue, 8 Jan 2019 23:39:40 +0000 From: Simon Marchi To: Philippe Waroquiers , "gdb-patches@sourceware.org" , Tom Tromey Subject: Re: [RFA] Fix leak in linespec.c Date: Tue, 08 Jan 2019 23:39:00 -0000 Message-ID: <2c12aba6-cafa-54e2-9b69-96d95b82d3fb@ericsson.com> References: <20190108062452.3942-1-philippe.waroquiers@skynet.be> In-Reply-To: <20190108062452.3942-1-philippe.waroquiers@skynet.be> authentication-results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 Return-Path: simon.marchi@ericsson.com X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00153.txt.bz2 T24gMjAxOS0wMS0wOCAxOjI0IGEubS4sIFBoaWxpcHBlIFdhcm9xdWllcnMg d3JvdGU6DQo+IFZhbGdyaW5kIHJlcG9ydHMgYSBsZWFrIGluIG1hbnkgdGVz dHMsIHN1Y2ggYXM6DQo+ID09OTM4Mj09IDE2IGJ5dGVzIGluIDEgYmxvY2tz IGFyZSBkZWZpbml0ZWx5IGxvc3QgaW4gbG9zcyByZWNvcmQgMjM2IG9mIDMs MjgyDQo+ID09OTM4Mj09ICAgIGF0IDB4NEMyQkU2RDogbWFsbG9jICh2Z19y ZXBsYWNlX21hbGxvYy5jOjMwOSkNCj4gPT05MzgyPT0gICAgYnkgMHg0MTk3 QUY6IHhyZWFsbG9jIChjb21tb24tdXRpbHMuYzo2NCkNCj4gPT05MzgyPT0g ICAgYnkgMHg1MUQxNkE6IHhyZXNpemV2ZWM8bGluZXNwZWNfY2Fub25pY2Fs X25hbWU+IChwb2lzb24uaDoxNzApDQo+ID09OTM4Mj09ICAgIGJ5IDB4NTFE MTZBOiBhZGRfc2FsX3RvX3NhbHMobGluZXNwZWNfc3RhdGUqLCBzdGQ6OnZl Y3RvcjxzeW10YWJfYW5kX2xpbmUsIHN0ZDo6YWxsb2NhdG9yPHN5bXRhYl9h bmRfbGluZT4gPiosIHN5bXRhYl9hbmRfbGluZSosIGNoYXIgY29uc3QqLCBp bnQpIChsaW5lc3BlYy5jOjEwNDEpDQo+ID09OTM4Mj09ICAgIGJ5IDB4NTFF MkJGOiBjcmVhdGVfc2Fsc19saW5lX29mZnNldCAobGluZXNwZWMuYzoyMjE1 KQ0KPiA9PTkzODI9PSAgICBieSAweDUxRTJCRjogY29udmVydF9saW5lc3Bl Y190b19zYWxzKGxpbmVzcGVjX3N0YXRlKiwgbGluZXNwZWMqKSAobGluZXNw ZWMuYzoyMzU4KQ0KPiA9PTkzODI9PSAgICBieSAweDUyMUI1RDogY29udmVy dF9leHBsaWNpdF9sb2NhdGlvbl90b19zYWxzIChsaW5lc3BlYy5jOjI0NzMp DQo+IA0KPiBGaXggbGVhayBieSB4ZnJlZS1pbmcgc2VsZi0+Y2Fub25pY2Fs X25hbWVzIGluIGxpbmVzcGVjX3N0YXRlX2Rlc3RydWN0b3IuDQo+IFRoZSBs ZWFrIHByb2JhYmx5IGFwcGVhcmVkIHdpdGggdGhlIHBhdGNoICdSZW1vdmUg Y2xlYW51cCBmcm9tIGxpbmVzcGVjLmMnLA0KPiBhcyB0aGVyZSB3YXMgYSBj bGVhbnVwIHRvIHhmcmVlIGNhbm9uaWNhbF9uYW1lcyBiZWZvcmUgdGhlIHBh dGNoLg0KPiANCj4gVGVzdGVkIG9uIERlYmlhbi9hbWQ2NCwgbmF0aXZlIGFu ZCB1bmRlciB2YWxncmluZC4NCj4gDQo+IDIwMTktMDEtMDcgIFBoaWxpcHBl IFdhcm9xdWllcnMgIDxwaGlsaXBwZS53YXJvcXVpZXJzQHNreW5ldC5iZT4N Cj4gDQo+IAkqIGxpbmVzcGVjLmMgKGxpbmVzcGVjX3N0YXRlX2Rlc3RydWN0 b3IpOiBGcmVlIHNlbGYtPmNhbm9uaWNhbF9uYW1lcy4NCj4gLS0tDQo+ICBn ZGIvbGluZXNwZWMuYyB8IDEgKw0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5z ZXJ0aW9uKCspDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZ2RiL2xpbmVzcGVjLmMg Yi9nZGIvbGluZXNwZWMuYw0KPiBpbmRleCBiMWFiNDYyZTY2Li5mNmVmNGMy YzQwIDEwMDY0NA0KPiAtLS0gYS9nZGIvbGluZXNwZWMuYw0KPiArKysgYi9n ZGIvbGluZXNwZWMuYw0KPiBAQCAtMjc2Nyw2ICsyNzY3LDcgQEAgc3RhdGlj IHZvaWQNCj4gIGxpbmVzcGVjX3N0YXRlX2Rlc3RydWN0b3IgKHN0cnVjdCBs aW5lc3BlY19zdGF0ZSAqc2VsZikNCj4gIHsNCj4gICAgaHRhYl9kZWxldGUg KHNlbGYtPmFkZHJfc2V0KTsNCj4gKyAgeGZyZWUgKHNlbGYtPmNhbm9uaWNh bF9uYW1lcyk7DQo+ICB9DQo+ICANCj4gIC8qIERlbGV0ZSBhIGxpbmVzcGVj IHBhcnNlci4gICovDQo+IA0KDQpBaCwgaW5kZWVkLiAgVGhlIG9yaWdpbmFs IGNvZGUgaW4gZGVjb2RlX2xpbmVfZnVsbCBsb29rcyBsaWtlOg0KDQogIC8q IEFycmFuZ2UgZm9yIGFsbG9jYXRlZCBjYW5vbmljYWwgbmFtZXMgdG8gYmUg ZnJlZWQuICAqLw0KICBpZiAoIXJlc3VsdC5lbXB0eSAoKSkNCiAgICB7DQog ICAgICBpbnQgaTsNCg0KICAgICAgbWFrZV9jbGVhbnVwICh4ZnJlZSwgc3Rh dGUtPmNhbm9uaWNhbF9uYW1lcyk7DQogICAgICBmb3IgKGkgPSAwOyBpIDwg cmVzdWx0LnNpemUgKCk7ICsraSkNCgl7DQoJICBnZGJfYXNzZXJ0IChzdGF0 ZS0+Y2Fub25pY2FsX25hbWVzW2ldLnN1ZmZpeCAhPSBOVUxMKTsNCgkgIG1h a2VfY2xlYW51cCAoeGZyZWUsIHN0YXRlLT5jYW5vbmljYWxfbmFtZXNbaV0u c3VmZml4KTsNCgl9DQogICAgfQ0KDQouLi4gc28geW91IGFyZSBhZGRpbmcg dGhlIGVxdWl2YWxlbnQgb2YgdGhlIGZpcnN0IGNsZWFudXAuDQoNCkl0IHdv dWxkIGJlIG5pY2UgdG8gYmUgYWJsZSB0byBmcmVlIHRoZSBzdWZmaXggc3Ry aW5ncyBpbiBsaW5lc3BlY19zdGF0ZV9kZXN0cnVjdG9yLCB0aGUNCm9ubHkg cHJvYmxlbSBpcyB0aGF0IHdlIGRvbid0IGtub3cgdGhlIHNpemUgb2YgdGhl IGNhbm9uaWNhbF9uYW1lcyBhcnJheSBhdCB0aGF0IHBvaW50Lg0KDQpBbnl3 YXksIExHVE0sIHRoYW5rcyENCg0KU2ltb24NCg== >From gdb-patches-return-153264-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Jan 09 00:25:04 2019 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 101649 invoked by alias); 9 Jan 2019 00:25:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 101275 invoked by uid 89); 9 Jan 2019 00:24:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=deserve, upcoming, planned, keith X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Jan 2019 00:24:53 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EF4C0811DC; Wed, 9 Jan 2019 00:24:51 +0000 (UTC) Received: from theo.uglyboxes.com (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BA84B17C48; Wed, 9 Jan 2019 00:24:51 +0000 (UTC) Subject: Re: [PATCH] gdb: Remove support for old mangling schemes To: Simon Marchi , "gdb-patches@sourceware.org" References: <20190108232208.17487-1-simon.marchi@ericsson.com> From: Keith Seitz Message-ID: Date: Wed, 09 Jan 2019 00:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <20190108232208.17487-1-simon.marchi@ericsson.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00154.txt.bz2 Content-length: 2669 On 1/8/19 3:22 PM, Simon Marchi wrote: > An upcoming sync with gcc's libiberty [1] will remove support for old > mangling schemes (GNU v2, Lucid, ARM, HP and EDG). It will remove the > cplus_demangle_opname function, so we need to get rid of its usages in > GDB (it's a GNU v2 specific function). Thank you so much for doing this. I was working on my own version of this before other work got in the way. Your patch looks just about identical to mine, and I had a few additional questions about my own patch that I needed to answer. I would think this should have/deserve doc and NEWS changes. The manual talks about several demangling-related features which raised questions for me about the general support for gnu-v2 code. If libiberty is removing support for v2 demangling, how useful will GDB be without the ability to demangle v2 symbols? Should we deprecate or remove that, too? /me opens can of worms WRT docs specifically, "set cp-abi" and "set demangling-style" still carry either direct or indirect mentions of the different ABIs/mangling schemes in the documentation that are now no longer valid, e.g., "lucid" and "arm". Some comments in demangle.c do, too. The help system references that exist today/right now, I presume, will disappear when the libiberty patch goes back in (when libiberty_demanglers is updated), so I *think* there's nothing to do there. Now the bonus. :-) > diff --git a/gdb/testsuite/gdb.cp/demangle.exp b/gdb/testsuite/gdb.cp/demangle.exp > index 698231b82b4..9231b54f787 100644 > --- a/gdb/testsuite/gdb.cp/demangle.exp > +++ b/gdb/testsuite/gdb.cp/demangle.exp > - > - > proc catch_demangling_errors {command} { > if {[catch $command result]} { > puts "ERROR: demangle.exp: while running $command: $result" > @@ -1593,10 +183,7 @@ proc do_tests {} { > # Using catch_demangling_errors this way ensures that, if one of > # the functions raises a Tcl error, then it'll get reported, and > # the rest of the functions will still run. > - catch_demangling_errors test_lucid_style_demangling > - catch_demangling_errors test_gnu_style_demangling > - catch_demangling_errors test_arm_style_demangling > - catch_demangling_errors test_hp_style_demangling > + catch_demangling_errors test_gnuv3_style_demangling > Please consider getting rid of catch_demangling_errors and removing the "error" calls in set_demangling_style. They are not needed, and in fact, they cause the test suite to hang if that error is ever called. I ran across this while prepping my patch, and planned to remove it. Of course, this (nit) is sorta orthogonal, so please feel free to ask me to do it! ;-) Keith