From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6071 invoked by alias); 3 Jan 2017 14:36:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5897 invoked by uid 89); 3 Jan 2017 14:36:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=simulator, 2407, H*i:sk:zscOG1s, H*i:sk:eRXtu_w X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Jan 2017 14:36:07 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 84C624D687; Tue, 3 Jan 2017 14:36:07 +0000 (UTC) Received: from [10.36.116.174] (ovpn-116-174.ams2.redhat.com [10.36.116.174]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v03Ea5TJ013047 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 3 Jan 2017 09:36:06 -0500 Subject: Re: [PATCH] aarch64 sim mls and movi bug fixes To: Jim Wilson , gdb-patches@sourceware.org References: From: Nick Clifton Message-ID: <2c0cbab3-eed6-9043-6d12-0759ea24524a@redhat.com> Date: Tue, 03 Jan 2017 14:36:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-01/txt/msg00011.txt.bz2 Hi Jim, > The mls instruction computes accumulator - product, but the simulator > accidentally has the subtract operands swapped. While writing the > testcase for this problem, I discovered that the movi instruction is > broken, there is a missing break after the half word support. Both > are simple fixes. > > The testcase works with the patch, and fails without the patch. The > mls fix takes GCC C testsuite failures from 2407 to 2406, and the movi > fix then takes it from 2406 to 2295. Approved - please apply. Cheers Nick