From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GHAtGOdAkF+1FwAAWB0awg (envelope-from ) for ; Wed, 21 Oct 2020 10:08:39 -0400 Received: by simark.ca (Postfix, from userid 112) id 604DA1EFC3; Wed, 21 Oct 2020 10:08:39 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F09DE1E58E for ; Wed, 21 Oct 2020 10:08:36 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4FFB539518A8; Wed, 21 Oct 2020 14:08:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4FFB539518A8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1603289316; bh=WkCLchc0w35Xki671q7yenOoDnvWe6N3riq825AIdIY=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=K/NtWEhqppox6VzRgYL1AbBTzzH0WeQ2b1tYhDxqyNNeh9BgTOJK104JRO+SvEt9Z CJX1Ki1EPc4spQtnbIY48jXNqfvML10NHg1ZFMscMw3ST4beAK0wE5l2BU5pDS+DHC 6UZfm7MVldl9YRE+YjRqrB6odXM+DRzBRlj4FnWQ= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 93D1B3857813 for ; Wed, 21 Oct 2020 14:08:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 93D1B3857813 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 09LE8Q73028147 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 21 Oct 2020 10:08:30 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 09LE8Q73028147 Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id EBD091E58E; Wed, 21 Oct 2020 10:08:25 -0400 (EDT) Subject: Re: [PATCH] gdbserver: fix overlap in sprintf argument and buffer To: Christian Biesinger References: <20201020220453.302587-1-simon.marchi@polymtl.ca> Message-ID: <2bfe7987-20ac-f5df-50be-d240e0448694@polymtl.ca> Date: Wed, 21 Oct 2020 10:08:25 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 21 Oct 2020 14:08:26 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: gdb-patches Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-10-21 5:50 a.m., Christian Biesinger wrote: > On Wed, Oct 21, 2020 at 12:05 AM Simon Marchi via Gdb-patches > wrote: >> CXX server.o >> /home/Baube/src/binutils-gdb/gdbserver/server.cc: In function ‘void handle_general_set(char*)’: >> /home/Baube/src/binutils-gdb/gdbserver/server.cc:832:12: error: ‘sprintf’ argument 3 overlaps destination object ‘own_buf’ [-Werror=restrict] >> 832 | sprintf (own_buf, "E.Unknown thread-events mode requested: %s\n", >> | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> 833 | mode); >> | ~~~~~ > > https://sourceware.org/bugzilla/show_bug.cgi?id=26758 was filed on > this, so you should probably link to it in the commit message. > > + sprintf (own_buf, "%s", err.c_str ()); > > Why not use strcpy? Good point, I just blindly used sprintf because that's what was used before. I'll switch to strcpy and push the patch. Thanks! Simon