From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id /6WmGPVUlWARRQAAWB0awg (envelope-from ) for ; Fri, 07 May 2021 10:55:49 -0400 Received: by simark.ca (Postfix, from userid 112) id 576151F11C; Fri, 7 May 2021 10:55:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A868F1E01F for ; Fri, 7 May 2021 10:55:48 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5D5723853806; Fri, 7 May 2021 14:55:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5D5723853806 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1620399348; bh=LiJ0VKZE+xmdXG/1dTFVIxEgyi2wLojCnugHFDhGAd0=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=o7EgUiyeUMd0alSyQtuGtAdQ9p/YEQh5y0m+NSyUW8BtktjOuYS54onwTrUADmS7t 1FhYvlPEDiveZJAohpSB2AqJ+Y25nsy3zGIi81MublzJ8kvPasRbfMbsirDD8ITol3 82egafK2uWXf1mSfGsGBlD/50fNie8qNwYhRYLm4= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 373543853806 for ; Fri, 7 May 2021 14:55:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 373543853806 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 147EtdAA015342 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 7 May 2021 10:55:43 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 147EtdAA015342 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id D12D71E01F; Fri, 7 May 2021 10:55:38 -0400 (EDT) Subject: Re: [PATCHv2 1/2] gdb/guile: perform tilde expansion when sourcing guile scripts To: Andrew Burgess References: <87bl9pq9li.fsf@tromey.com> <6e22f6c142ac81db0ec98d3c9485be5efcf58eca.1620248278.git.andrew.burgess@embecosm.com> <20210507102910.GL6612@embecosm.com> Message-ID: <2bfc1a5d-d8ba-e0af-15b7-d241a6e2c274@polymtl.ca> Date: Fri, 7 May 2021 10:55:38 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210507102910.GL6612@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 7 May 2021 14:55:39 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-05-07 6:29 a.m., Andrew Burgess wrote: > @@ -737,8 +738,10 @@ source_script_with_search (const char *file, int from_tty, int search_path) > anyway so that error messages show the actual file used. But only do > this if we (may have) used search_path, as printing the full path in > errors for the non-search case can be more noise than signal. */ > + gdb::unique_xmalloc_ptr file_to_open = gdb_tilde_expand_up (file); > source_script_from_stream (opened->stream.get (), file, > - search_path ? opened->full_path.get () : file); > + search_path ? opened->full_path.get () > + : file_to_open.get ()); A minor detail, but the gdb_tilde_expand_up call is only necessary when search_path is false. So if there's a easy way to avoid it otherwise, it would be nice. But other than that, LGTM. Simon