From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5093 invoked by alias); 9 Oct 2016 17:20:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5081 invoked by uid 89); 9 Oct 2016 17:20:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=guideline X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 09 Oct 2016 17:20:40 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CF8F7624B5; Sun, 9 Oct 2016 17:20:38 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u99HKbjn010048; Sun, 9 Oct 2016 13:20:37 -0400 Subject: Re: [RFA 14/22] Replace two xmallocs with vector To: Tom Tromey , gdb-patches@sourceware.org References: <1474949330-4307-1-git-send-email-tom@tromey.com> <1474949330-4307-15-git-send-email-tom@tromey.com> From: Pedro Alves Message-ID: <2bb436df-b6ee-cc2f-c4c1-1a79d6fcdce1@redhat.com> Date: Sun, 09 Oct 2016 17:20:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1474949330-4307-15-git-send-email-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00199.txt.bz2 On 09/27/2016 05:08 AM, Tom Tromey wrote: > This replaces a couple of uses of xmalloc with a std::vector, also > removing a couple of cleanups. > > 2016-09-26 Tom Tromey > > * cli/cli-dump.c (dump_memory_to_file): Use std::vector. > (restore_binary_file): Likewise. As general guideline, for these cases where we only need to construct a buffer once (never resize/reallocate) and we don't care about the initial contents of the buffer, I think unique_ptr buf (new char[size]); ends up being more efficient, because std::vector default/zero initializes its elements, which is unnecessary since we're about to write into the buffer anyway. WDYT? (I'll try to post my unique_ptr shim soon.) Thanks, Pedro Alves