From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 593 invoked by alias); 22 Feb 2019 17:22:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 566 invoked by uid 89); 22 Feb 2019 17:22:05 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=3s, formerly, patchset X-HELO: mx2.freebsd.org Received: from mx2.freebsd.org (HELO mx2.freebsd.org) (8.8.178.116) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Feb 2019 17:22:04 +0000 Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4737F72DDD for ; Fri, 22 Feb 2019 17:22:03 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4822C768E1 for ; Fri, 22 Feb 2019 17:22:02 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-3.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id E526516101 for ; Fri, 22 Feb 2019 17:22:01 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: [PING][PATCH v2 00/11] Support for thread-local variables on FreeBSD From: John Baldwin To: gdb-patches@sourceware.org References: Openpgp: preference=signencrypt Message-ID: <2b9d1e4b-507c-748d-060f-363ed9656406@FreeBSD.org> Date: Fri, 22 Feb 2019 17:22:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4822C768E1 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.96 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.96)[-0.959,0]; ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00365.txt.bz2 On 2/8/19 4:40 PM, John Baldwin wrote: > Relative to the first version the changes are: > > - Patch 2 fixes some #ifdef's pointed by Simon in amd64-bsd-nat.c. > - Patch 3's description has been reworked to narrow down the cases in > which it applies. > - Patch 5 is a new cleanup patch > - Patch 6 is a new patch that introduces a new method to lookup the > offset of a field in a structure. It is slightly more general than > just returning offsets so that it can hopefully be used to replace > the lk_find_field function in the Linux kernel patchset. > - Patch 7 (formerly 5) now uses the new method from Patch 6 to lookup > the offsets of two fields in a runtime linker structure instead of > parse_and_eval_long with manual offsetof. > > John Baldwin (11): > Support the fs_base and gs_base registers on i386. > Support fs_base and gs_base on FreeBSD/i386. > Handle an edge case for minisym TLS variable lookups. > Add a new gdbarch method to resolve the address of TLS variables. > Remove code disabled since at least 1999 from lookup_struct_elt_type. > Add a more general version of lookup_struct_elt_type. > Add a helper function to resolve TLS variable addresses for FreeBSD. > Support TLS variables on FreeBSD/amd64. > Support TLS variables on FreeBSD/i386. > Support TLS variables on FreeBSD/riscv. > Support TLS variables on FreeBSD/powerpc. I'll probably wait until the 8.3 branch if this is OK'd. Simon looked at the first 3 patches previously (though 3 has a new description since the first series). Andrew ok'd the FreeBSD/riscv patch as well. The FreeBSD-specific ones are probably ok, but patches 4-6 probably could use at least some looking over. -- John Baldwin                                                                            Â