From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98223 invoked by alias); 18 Dec 2019 18:28:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 98214 invoked by uid 89); 18 Dec 2019 18:28:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=shot, 2241, *c, HX-Languages-Length:2370 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Dec 2019 18:28:24 +0000 Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9B2271E059; Wed, 18 Dec 2019 13:28:22 -0500 (EST) Subject: Re: [PATCH] Fix indentation (and clang warning) in c-lang.c To: Simon Marchi , gdb-patches@sourceware.org References: <20191216233637.29925-1-simon.marchi@efficios.com> From: Simon Marchi Message-ID: <2b7648a2-7f88-bb49-0e41-b2415e520c3c@simark.ca> Date: Wed, 18 Dec 2019 18:28:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191216233637.29925-1-simon.marchi@efficios.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-12/txt/msg00780.txt.bz2 On 2019-12-16 6:36 p.m., Simon Marchi wrote: > I see this warning when building with clang: > > CXX c-lang.o > /home/smarchi/src/binutils-gdb/gdb/c-lang.c:314:7: error: misleading indentation; statement is not part of the previous 'if' [-Werror,-Wmisleading-indentation] > *length = i * width; > ^ > /home/smarchi/src/binutils-gdb/gdb/c-lang.c:308:4: note: previous statement is here > if (extract_unsigned_integer (contents + i * width, > ^ > > It took me a while to notice that some lines in that area have a > spurious space before the tabs, at the beginning of the ling. I'm not > sure how clang translates that to misleading indentation, but making the > indentation correct gets rid of the error. > > There are many more instances of this in the code base (`grep -P '^ \t' > *.c`), if others think it's a good idea, it would be pretty easy to fix > them all up in one shot. > > gdb/ChangeLog: > > * c-lang.c (c_get_string, asm_language_defn): Remove space > before tab. > --- > gdb/c-lang.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/gdb/c-lang.c b/gdb/c-lang.c > index 846970af7b92..1f40e885d99a 100644 > --- a/gdb/c-lang.c > +++ b/gdb/c-lang.c > @@ -303,14 +303,14 @@ c_get_string (struct value *value, gdb::unique_xmalloc_ptr *buffer, > if (*length >= 0) > i = *length; > else > - /* Otherwise, look for a null character. */ > - for (i = 0; i < fetchlimit; i++) > + /* Otherwise, look for a null character. */ > + for (i = 0; i < fetchlimit; i++) > if (extract_unsigned_integer (contents + i * width, > width, byte_order) == 0) > - break; > + break; > > /* I is now either a user-defined length, the number of non-null > - characters, or FETCHLIMIT. */ > + characters, or FETCHLIMIT. */ > *length = i * width; > buffer->reset ((gdb_byte *) xmalloc (*length)); > memcpy (buffer->get (), contents, *length); > @@ -1119,7 +1119,7 @@ extern const struct language_defn asm_language_defn = > 0, /* String lower bound */ > default_word_break_characters, > default_collect_symbol_completion_matches, > - c_language_arch_info, /* FIXME: la_language_arch_info. */ > + c_language_arch_info, /* FIXME: la_language_arch_info. */ > default_print_array_index, > default_pass_by_reference, > c_watch_location_expression, > -- > 2.24.1 > I pushed this one. Simon