From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84399 invoked by alias); 25 May 2017 11:48:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84224 invoked by uid 89); 25 May 2017 11:48:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy= X-HELO: mail-wm0-f41.google.com Received: from mail-wm0-f41.google.com (HELO mail-wm0-f41.google.com) (74.125.82.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 May 2017 11:48:33 +0000 Received: by mail-wm0-f41.google.com with SMTP id d127so94153948wmf.0 for ; Thu, 25 May 2017 04:48:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=vcKPia5B6/j8qIMRIOSxhnrqoiqI6kRZGkX47MAUW2g=; b=ogvLYwaeDcRyN8dCWBD4XDVqcqDagvm04VKLnUUifs3mXPUX0t4BXZ+Uo4yMDU4VoS UgF0zBCEMGbIF4IaV+OfH8r0s55uUzMkikKAto0qf8JOsexXNV5cdrVOJMKlBWiaEcuY YU4q3PUKi0KwY9oHDVBcdnwiLuL/O2oGVOHYal6+T5uANJ/CuMWFSMKygc565Y7oHvyq uYPdNoJQXdMv0Lr5FwDfHGr7G4yDVuqf9PSttTg1n5hp2LFEwS5kJoP7yauIbelFYPjy +BfJe3GFvMqwSMczXVHXtf1SgC1IMEaxsAncp81sEF5/SmJ8sHPhDWhaUmc7pfLYKckv WUXg== X-Gm-Message-State: AODbwcDvAnxDf+L/7NafkqiZOq61ZSKLllYYNm7gcqsEFCd6ZrJZsU+s gw7mBzinpPz9NfsA X-Received: by 10.28.151.135 with SMTP id z129mr9398818wmd.2.1495712911038; Thu, 25 May 2017 04:48:31 -0700 (PDT) Received: from [192.168.0.102] ([37.189.166.198]) by smtp.gmail.com with ESMTPSA id 203sm7406872wmv.18.2017.05.25.04.48.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 May 2017 04:48:30 -0700 (PDT) Subject: Re: [PATCH 3/11] Add MIPS_MAX_REGISTER_SIZE (2/4) To: Yao Qi References: <3C00280E-37C9-4C0A-9DA6-F3B9DB1A6E8F@arm.com> <86y3v7uf9j.fsf@gmail.com> <806B436F-EFA1-4200-AC54-9036D166C9B9@arm.com> <867f1m8nhm.fsf@gmail.com> <8637bx9jsw.fsf@gmail.com> <78A7E8EA-7203-44DF-B7FD-63E75A5ECEF5@arm.com> <540372d8-efc3-f842-5cac-cd813bacc3f5@redhat.com> <4F90CD36-759D-4BDA-BFEC-8DD86F44A0B7@arm.com> <40597975-9458-e9af-8915-9d303bb1ed98@redhat.com> <5A105765-C70D-413C-BB35-50BAA5FD5865@arm.com> <73b5b4f8-065b-7102-a9d8-0b909b1eb124@redhat.com> <86wp95p3ev.fsf@gmail.com> Cc: Alan Hayward , "gdb-patches@sourceware.org" , nd From: Pedro Alves Message-ID: <2b6c26fe-be7e-e219-7c6a-7fb7425f7dc1@redhat.com> Date: Thu, 25 May 2017 11:48:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <86wp95p3ev.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-05/txt/msg00542.txt.bz2 On 05/25/2017 12:43 PM, Yao Qi wrote: >>> >> static void >>> >> supply_32bit_reg (struct regcache *regcache, int regnum, const void *addr) >>> >> { >>> >> - struct gdbarch *gdbarch = get_regcache_arch (regcache); >>> >> - enum bfd_endian byte_order = gdbarch_byte_order (gdbarch); >>> >> - gdb_byte buf[MAX_REGISTER_SIZE]; >>> >> - store_signed_integer (buf, register_size (gdbarch, regnum), byte_order, >>> >> - extract_signed_integer ((const gdb_byte *) addr, 4, >>> >> - byte_order)); >>> >> - regcache_raw_supply (regcache, regnum, buf); >>> >> + regcache->raw_supply_integer (regnum, (const gdb_byte *) addr, 4, true); >>> >> } >> > >> > Nice. :-) >> > [snip several "nice"s] >> > > Likewise, remove supply_32bit_reg and use regcache->raw_supply_integer. There are multiple calls to it, so inlining it would require writing the "4, true" arguments at all call sites. Leaving supply_32bit_reg (etc.) as small wrapper functions helps readability, IMHO. Thanks, Pedro Alves