From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 382 invoked by alias); 2 Sep 2014 13:42:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 352 invoked by uid 89); 2 Sep 2014 13:42:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: na01-bn1-obe.outbound.protection.outlook.com Received: from dns-bn1lp0143.outbound.protection.outlook.com (HELO na01-bn1-obe.outbound.protection.outlook.com) (207.46.163.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 02 Sep 2014 13:42:26 +0000 Received: from BY2PR03MB175.namprd03.prod.outlook.com (10.242.36.148) by BY2PR03MB175.namprd03.prod.outlook.com (10.242.36.148) with Microsoft SMTP Server (TLS) id 15.0.1015.19; Tue, 2 Sep 2014 13:42:21 +0000 Received: from BY2PR03MB175.namprd03.prod.outlook.com ([169.254.5.31]) by BY2PR03MB175.namprd03.prod.outlook.com ([169.254.5.168]) with mapi id 15.00.1015.018; Tue, 2 Sep 2014 13:42:21 +0000 From: "catalin.udma@freescale.com" To: Marcus Shawcroft CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH v2] aarch64/gdbserver: fix floating point registers display Date: Tue, 02 Sep 2014 13:42:00 -0000 Message-ID: <2b1c05a9add342ae9d6604d70da25c96@BY2PR03MB175.namprd03.prod.outlook.com> References: <1408690493-5243-1-git-send-email-catalin.udma@freescale.com> In-Reply-To: x-ms-exchange-transport-fromentityheader: Hosted x-microsoft-antispam: BCL:0;PCL:0;RULEID:;UriScan:; x-forefront-prvs: 0322B4EDE1 x-forefront-antispam-report: SFV:NSPM;SFS:(6009001)(189002)(199003)(51704005)(92566001)(106116001)(21056001)(50986999)(87936001)(76482001)(79102001)(101416001)(76576001)(33646002)(46102001)(558084003)(77096002)(74316001)(95666004)(90102001)(86362001)(15975445006)(99286002)(99396002)(77982001)(2656002)(74662001)(74502001)(31966008)(108616004)(83072002)(85852003)(19580395003)(83322001)(85306004)(110136001)(76176999)(64706001)(54356999)(81542001)(81342001)(80022001)(20776003)(105586002)(4396001)(106356001)(107046002)(66066001)(24736002);DIR:OUT;SFP:;SCL:1;SRVR:BY2PR03MB175;H:BY2PR03MB175.namprd03.prod.outlook.com;FPR:;MLV:sfv;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-SW-Source: 2014-09/txt/msg00050.txt.bz2 IA0KPiBEb2VzIHRoaXMgdmVyc2lvbiBvZiB0aGUgcGF0Y2ggYXNzdW1lIHRo YXQNCj4gaHR0cHM6Ly9zb3VyY2V3YXJlLm9yZy9tbC9nZGItcGF0Y2hlcy8y MDEzLTEyL21zZzAwNzIwLmh0bWwgaGFzIGJlZW4NCj4gcmV2ZXJ0ZWQ/DQo+ IA0KPiBDaGVlcnMNCj4gL01hcmN1cw0KW0NhdGFsaW4gVWRtYV0gWWVzLCBp dCBhc3N1bWVzIHRoYXQgdGhlIHBhdGNoIGhhcyBiZWVuIHJldmVydGVkLg0K >From gdb-patches-return-115460-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Sep 02 13:47:36 2014 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 4253 invoked by alias); 2 Sep 2014 13:47:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 4243 invoked by uid 89); 2 Sep 2014 13:47:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f176.google.com Received: from mail-vc0-f176.google.com (HELO mail-vc0-f176.google.com) (209.85.220.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 02 Sep 2014 13:47:33 +0000 Received: by mail-vc0-f176.google.com with SMTP id ik5so7011747vcb.35 for ; Tue, 02 Sep 2014 06:47:31 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.52.88.74 with SMTP id be10mr282502vdb.54.1409665651872; Tue, 02 Sep 2014 06:47:31 -0700 (PDT) Received: by 10.52.253.33 with HTTP; Tue, 2 Sep 2014 06:47:31 -0700 (PDT) In-Reply-To: <1408690493-5243-1-git-send-email-catalin.udma@freescale.com> References: <1408690493-5243-1-git-send-email-catalin.udma@freescale.com> Date: Tue, 02 Sep 2014 13:47:00 -0000 Message-ID: Subject: Re: [PATCH v2] aarch64/gdbserver: fix floating point registers display From: Marcus Shawcroft To: Catalin Udma Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00051.txt.bz2 Content-length: 1053 On 22 August 2014 07:54, Catalin Udma wrote: > When using aarch64 gdb with gdbserver, floating point registers are > not correctly displayed, as below: > (gdb) info registers fpsr fpcr > fpsr > fpcr > > To fix these problems, the missing fpsr and fpcr registers are added > when floating point registers are read/write > > gdb/gdbserver/ > 2014-08-12 Catalin Udma > > * linux-aarch64-low.c (AARCH64_FPSR_REGNO): New define. > (AARCH64_FPCR_REGNO): Likewise. > (AARCH64_NUM_REGS): Update to include fpsr/fpcr registers. > (aarch64_fill_fpregset): Add missing fpsr/fpcr registers. > (aarch64_store_fpregset): Likewise. This looks good to me.... and I agree with the views expressed elsewhere in this list that https://sourceware.org/ml/gdb-patches/2013-12/msg00720.html should be reverted pending a proper solution for BE. .. however... I can't approve your patch here in gdb land. Cheers /Marcus