From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by sourceware.org (Postfix) with ESMTPS id 0D997387703A for ; Fri, 20 Mar 2020 16:59:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0D997387703A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gmx.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=n54@gmx.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1584723570; bh=xX5gdxBArAySkWycexVUV43wrkaCJ5VHjcgQgkn9o+4=; h=X-UI-Sender-Class:To:Cc:References:From:Subject:Date:In-Reply-To; b=cRF7dQoA0SJcIeGLFSxanF7JGyidNMlcnnEhuPQ4455855gKD2xfu1jJi3hEgD1U+ NmJquxwlEU3qyZyPThnYKFjpf5Sx0bV1sg2t0lZBgBm6BaIwdzu2zPtGrV1bszhYvY aiQahK4BY0DKpJglGIIBB0mTSFVJ//hrYS0NE5iA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.241] ([89.79.191.25]) by mail.gmx.com (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MC30Z-1j7srs3QWT-00CNJ9; Fri, 20 Mar 2020 17:59:29 +0100 To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20200316173424.25375-1-n54@gmx.com> <875zezm421.fsf@tromey.com> From: Kamil Rytarowski Autocrypt: addr=n54@gmx.com; prefer-encrypt=mutual; keydata= mQINBFVwUF8BEADHmOg7PFLIcSDdMx5HNDYr8MY2ExGfUTrKwPndbt3peaa5lHsK+UGoPG48 KiWkhEaMmjaXHFa7XgVpJHhFmNoJXfPgjI/sOKTMCPQ5DEHEHTibC4mta7IBAk+rmnaOF0k8 bxHfP8Qbls66wvicrAfTRXn/1ReeNc3NP4Sq39PoVHkfQTlnQiD4eAqBdq61B7DhzjhbKAZ4 RsNtLfB6eOv9qvmblUzs50ChYewM9hvn+c7MdDH+x2UXoSDhkBDkKcJGkX91evos8s9AuoEd D32X5e+bmdUGe8Cr3cAZJ8IEXR6F9828/kxzPliMsCWVRx1Fr28baCJOUGgFPNr3ips78m9+ Iw8PdQ101jU0dvucDFxw/1SCGYEZzV+O/237oRPuLCiDX5nhQoxf6dn9ukQleLBMNy2BLI4H g342NhF21HLA+KlyLOHaMKQCKzlal+zVNZTRTCh/ikMhsxWQjBfnqTDbMj85DnWwtump27SI qhPjUnS0a6MKoS/A+hbi64k5zztkvloELfCSrX7NyBTT0jgF2IGFIxZMrKCtQ9StcGMCV9MX tjcBy6fj7QMontEaIDRJEMjg8UIGw1B687OhalOv1ISia4xOWvpYAM6ipgqh6tBQmFzasL9P h1RtcVdFpFbhwVlr1Bly8c25gBNQHL5GUjLMn45LlQz50OzrkwARAQABtCdLYW1pbCBSeXRh cm93c2tpIChOZXRCU0QpIDxuNTRAZ214LmNvbT6JAjwEEwEIACYCGyMHCwkIBwMCAQYVCAIJ CgsEFgIDAQIeAQIXgAUCVbKGFwIZAQAKCRBLswjpsC52bIVpD/9i8npieI91xMIVvAHIUMeo cQO0IrNb+b/PuTj2qNemdwU7dhVJ7tVU5O1H2hI2M4rHGzjzDTxYzdxka0+A8CVEuvFdf6sF lXlXF0wM7rC6MoaB0QLAKxkZB5OtCILxLx7Bl2Y4cTPMU9v+qSL6yrdmhxogkufa4d6O9Zl/ FCWO2kH/BphKOiDtbyvdo2WULSLWP2IXN+0rCpNL4wbTfYLgV9JtMf8f0naGsdy7BFuDWsIE vtHh8dkQZP7dz6Qy67kx8negZaehSEgXwiae0HwQIn3xTQrFmBDALDsCgXuLWPTvglSkqTak uG+8X5fyTy0cU10TNKsU+rFBO+/xsUoIQOGrARwfWOIfJNPelzh/qigSnyNQNH8u5vFRPg9n fqB/AcvvAvtOYOo8EN9Ofx11gNj397NXc5HBQTrX6k5GNAeBWE3Ng1uO6scIwAS7qGnqGezU ABmQKLN37gmJiiGwhQAnSE6HILLBC5Z2b0S2rQsPKg8WgUmPa1YIcDkDtNB/LJcDsdU4Fm+r U2ksKU7tGD2ZfBt8H2nqfPKKeB+Uv/TBigjRvx/m70vjhqVxwCZA9Fqr9vkQkZroNfqP+3dp Z5V5fjmxO5abE2+IikSvFagwMtgx56i8Yrr2BzE8P5/S4cKq1kgyQoF+lVGDKRkUKCv1i4Fo aftnSxN8jTFZDbkCDQRVcFBfARAAutbzb8wAHGL5FPPWKErQ3Bsrp9RDTVqRzp7kBMOtd/14 MrOsWWyiml4XnvBYsJuhZWomFoeulcOXAPoTJ2vTw6erWYtdOiZymfQ3GMWpxzgkOVeNjsFF 9AQ38FCMKmIDs9dgn+KXSIXlZA34khKLd163SN5U/KHfYlnnocec31u+7rVa1hlF5DBSSpoi s8cs41foBYC5NsB/i+yqGIlfzHy7pC2u5kyQCuJotLH4y0rT5X+YBC7z7cqKChtILNDGw0ht qps29fwOGBE/FWmu8CbpSHj8pvg7uUyQcKbZbNChBfWtOJKdjnNs5VHf2ec95SwYmWl6Xz66 G892HY4ODtvl05/kh0qtdJd2oI4gJBsBx/N1585/3JYN4k78GIHTnML3xJydRRs9wwM3AXf/ iDGrMyY7qHQVXJLdO5nPe7LHg48vryCMkBnTMw5iNFPVCu5w1BaZyHxuS2HvpsgUtQoBa2QE P1jYNI+2qgoiIG4VQDhYtrD0WJaYdi/C2UVDxRy07dt73SV3RQ7ijOiUrz4g3/deFKY16/1k sE+N5Sc5Tjt84ChjO3nJRbHrQxd6dCOElR70e3R2yAuSB4m7LJpO20IB9CtWhlF/0AtfL91W O8GGGqLWB0Z04hmwRs/l8T4WWIlykLshbunWN6jsP1Y27FeilTZ+Pc9mYOEUFfEAEQEAAYkC HwQYAQgACQUCVXBQXwIbDAAKCRBLswjpsC52bPayD/9jE8mdNudrudSxbDB2vf8pU8r5flCq vIkfOdpZGV/Wx/Zx+HFHHp+b2aNBGSNyFTnph1Ku9bvg06vD0o+b7SdA1vrBgRG41t0OCIyf vejz65Xpin2EtCllcBM8zUCxHo43blON8fNw70P1Ec0loBp4TAal1MiXbB8kxRTRcEPVO9YF 9NPsFxycoWl0ZSvu4ESrQlrjRbVv+W0Fy/XqcQwEtDziFQHQXNRbTy8INPD49CsB7BkKRK+f 1vMmw7SxfsyEhyCgo9ZWfHb/+w9T5h+UhF87L/m287z7W+s4aCAPBzjbIWhtngGJJwIgiWdI I9J6YJLcHLvVZLw7xzA/flcjc0VfzOgJOJw3hBukHnEz7/CKgnABwyNu52P+PQbxVTiTjMKm 06eV732u9ZLD9ZgEazfmyGDHzsuzoXwsRnmcnbwYYAiynS+vfGl5oMtMa5qzsPhlzuvRlXHm zr8VjF8c9RThvyZyyHtWYAqNmBecMvM0whigjMeoAMJ5LtpyZgxjbHj1XnVdNBZgfJkOzsc/ twffi7RYphRx0d9z5UZ1Yl5Rvl05vTaJ7YhhNC7xuE8yGOQmDUsPDwWqO/eXUDErJjCOBR5b 0yILqRPYNT0Fj/th9gtEbZy1Gp0TVBkZM3tfjDRu43Pn6iSKObO/j0rNuq1LwN/EMxDifeZO 4XSbcg== Subject: Re: [PATCH] Implement "info proc mappings" for NetBSD Message-ID: <2b16c08b-330f-1aa8-7c69-c14774847047@gmx.com> Date: Fri, 20 Mar 2020 17:58:18 +0100 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <875zezm421.fsf@tromey.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5aubanr2q2NHZ6NT2pIH2NMxlCzkajrmH" X-Provags-ID: V03:K1:esGj82R2bonTk+f3yrGdf401pU/10CBuPF+1JbKNGrEe+Iw6mT4 tNFTBxJoqnXKUvjxFP2YsZumJg9FQKBqBT5sWtpuj5XfRjGFcQF9rPnWT6BF7wWLVEX3nRX JI9noU+SJiS0+Mena0DWvhXuhYtybZvbNhGVcjuZLplJg0saR4j0Q60WydsXQatjXNgx9q0 9ewNzplWfOpmRFh1MalPQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:vdqoDx71B10=:wFhawhyBSpGmWK5SYoPpqn D4Gw59VG8cGCRd7XpeVMcCagTq1qc5QKZ85W7xdX2XHt0zLPvHofsO1bO5hhoMtKk5SA+nzyD 32D4yMZV9VGfUMEEDf8G0GRgShrFRpR1kgU0dGp5GaRnNiGc5rD2J9H8X3BOoUjDEjJOO1oDU y7eTkkUJNTCu1heg1LjkWsNn7CigT8qJ7bSSPtB9bpSAgvQNsGrU0Z66hAZ1gdphbo+BHb48H EuqxtPXVK75V+ApYgQTHufCwe2lFhkxjt3GiO6XhCziLGviEBSsjaKZO7Js0c0fGweKpbkLq/ RCcO5VThmULfm9p/3lkxl73lmCIzLVo8DTmaQEywSgkkkfKfaSl5dEj5t9a7/14Jq1Am8mqLA JhePBxVJ1SWMhra/e8hCdvxiwNaeOe8ViksCZsM/5xE0iwRy2Hom6/IXX31mdgtjKWhH4Umbv AR0Pnnq7aRfMrnmlS2x3r37cdOV0E7TJontsc00lLKjhhHNTfcCHYCOVZxcI/e2sTZgSqeUki Ilj3rVsFZ0TjlR1HEuZFArRHflDcpadyvOxfQJBtGcehIMG6N2GRQ8jYr9mTlWdMPnVhbzxTJ dknmNB/Q15nQ5k+o8emIUW+RHOt6aZ8hXF+wptacJATErKc6Op+iQEztQfi0vWjbq/6aOCcji OPAeOk1hLHZ5Z3DWzZyWR3huVxpjhRBNhLNZR+IgFkzCJyg+OtiTDxYdITYnukce2ntAu2hfG s4QEtxpo2QqlpWXBDOtJkXITPtT2X7KjdnSU6mbcFbXQ+kh8lFth3RtJ8vM/XSkiwGhqlMUII 99fnmU4tSH5UPYHTbVq3cZlJGOdU9v4IxhMKGT0v91hw6TPioeRHpux2LXfWG1HduUoRrn8RB j7c0RmewEQu4SSVbF8OA3lgHp2EqYNN7Ik0LgIxuDt/teoytS+gJGYigPpQ9lDutCMyCfOunC sBmngwI1rjGDHxjiEjEqZlOsQ8HJzpXI22NwtLz9FOOBp8LNzZ0nnZfsjtOEDfjXVt2g7LFrt wTTjtGiCzDAjv8fJRlQUJ4ZqrUvJSorxvKQNfjYFUMosKCBa1UHYgJcoTALrQqyFIPSLZ70KF EyJdDJ5VFthopiIJBWz6t9ejGOa5miZZYD5lMXXBFHb1Q1VeA2IZt0YHGOG6dRTxZLPjpAXRo KuhuQo7XqwngfFpeFHUSxXUlSMfQey2BwsweaLrceQRm+sRfwq6qcbBLg039a2giObVh0= X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Mar 2020 16:59:44 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5aubanr2q2NHZ6NT2pIH2NMxlCzkajrmH Content-Type: multipart/mixed; boundary="C1LwnqZxo32BmgP3KQJOs9rxBF7qcC69W"; protected-headers="v1" From: Kamil Rytarowski To: Tom Tromey Cc: gdb-patches@sourceware.org Message-ID: <2b16c08b-330f-1aa8-7c69-c14774847047@gmx.com> Subject: Re: [PATCH] Implement "info proc mappings" for NetBSD References: <20200316173424.25375-1-n54@gmx.com> <875zezm421.fsf@tromey.com> In-Reply-To: <875zezm421.fsf@tromey.com> --C1LwnqZxo32BmgP3KQJOs9rxBF7qcC69W Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 20.03.2020 16:36, Tom Tromey wrote: >>>>>> "Kamil" =3D=3D Kamil Rytarowski writes: >=20 > Kamil> Define nbsd_nat_target::find_memory_regions and > Kamil> nbsd_nat_target::info_proc. info_proc handles as of now only > Kamil> the "mappings" command. >=20 > Thank you for the patch. >=20 > Kamil> +/* Retrieve all the memory regions in the specified process. *= / > Kamil> + > Kamil> +static struct kinfo_vmentry * > Kamil> +kinfo_get_vmmap(pid_t pid, size_t *size) >=20 > Space before paren. > There are multiple instances of this in the patch. >=20 Done. > Kamil> +{ > Kamil> + int mib[5] =3D {CTL_VM, VM_PROC, VM_PROC_MAP, pid, sizeof(str= uct kinfo_vmentry)}; > Kamil> + > Kamil> + size_t length =3D 0; > Kamil> + if (sysctl(mib, ARRAY_SIZE (mib), NULL, &length, NULL, 0)) { >=20 > GNU style is to put the open brace on its own line. > There are several cases of this as well. >=20 Done. > Kamil> + if (sysctl(mib, ARRAY_SIZE (mib), kiv, &length, NULL, 0)) { > Kamil> + *size =3D 0; > Kamil> + free(kiv); >=20 > xfree, though these days in gdb it's better to create and return a > self-managing object, like gdb::unique_xmalloc_ptr<>. >=20 Done. > Kamil> + > Kamil> +int > Kamil> +nbsd_nat_target::find_memory_regions (find_memory_region_ftype = func, > Kamil> + void *obfd) >=20 > I wouldn't name that parameter "obfd" but rather "data" or "user_data" > or something like that. The name "obfd" in gdb normally implies that i= t > is a "BFD *", but this is just opaque data that's shared by the caller > and the callback. >=20 I see. I prefer to keep this called obfd, as it matches the FreeBSD code more closely. If we want to rename it, we shall do it also in FreeBSD. > Kamil> diff --git a/gdb/nbsd-tdep.c b/gdb/nbsd-tdep.c > [...] > Kamil> +/* Flags in the 'kve_protection' field in struct kinfo_vmentry.= These > Kamil> + match the KVME_PROT_* constants in . */ >=20 > What if they stop matching? >=20 Not a concern. If that will ever change, it will be patched, same as the other existing NetBSD support. > I wonder if this code really ought to be in the tdep file. I suppose > so, if it will be used somehow when cross debugging... but will that > happen? >=20 This code follows the structure of FreeBSD. > If not then maybe putting it in the -nat file is better; and then the > appropriate NetBSD headers could be used. >=20 I prefer to keep similarity with FreeBSD. If we want to change it, FreeBSD shall be changed too. > Kamil> + printf_filtered (_("Mapped address spaces:\n\n")); > Kamil> + if (addr_bit =3D=3D 64) > Kamil> + { > Kamil> + printf_filtered (" %18s %18s %10s %10s %9s %s\n", > Kamil> + "Start Addr", > Kamil> + " End Addr", > Kamil> + " Size", " Offset", "Flags ", "File"); > Kamil> + } > Kamil> + else > Kamil> + { > Kamil> + printf_filtered ("\t%10s %10s %10s %10s %9s %s\n", > Kamil> + "Start Addr", > Kamil> + " End Addr", > Kamil> + " Size", " Offset", "Flags ", "File"); >=20 > Personally I like using ui-out tables instead of this kind of thing. >=20 I will keep this as is. If we want to change it, we shall change FreeBSD in one go. I don't have chance to work or test on FreeBSD myself so I defer refactoring it into future. Please see v2. > Tom >=20 --C1LwnqZxo32BmgP3KQJOs9rxBF7qcC69W-- --5aubanr2q2NHZ6NT2pIH2NMxlCzkajrmH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEELaxVpweEzw+lMDwuS7MI6bAudmwFAl509ioACgkQS7MI6bAu dmyQuQ//ejI4u1m9TjEPf+rD0f1ClJ1iqIJpWNlhh06KUI9OOBjif7Vb++88Gh0z v5UwvbY9TCmhQQaJcgKbU182+Zlp/ww3yywls7tGxRvv4ca4Jlez0ncuB5syTgwK NSBk1MMHR3lVZZ74tOEE//5XmWJtxJOAnkmSrnOWxxHEBZVMMNbZhAz6+oZVdC5I 1O3abP5gfFwJP7h2FBJr8rsUQLy/7URXZVnIw9I3Y5Gjy+gZ3/bZqPPcG7UTaDHB X3cGGfWkwvWUec9MZfWOzDO3d9Jd0g19fFka8bWui/TzMuRdpVj7Pvbdv0DMol+G d0tARQiMrASoTYPvLgeeypi27Xh54+jCb+78VAgjwBO8zamOby53G5Y50DxJLBY4 olG07VYkoEIoE6DeRHH0IJsR1Mqhr4Gnm8AzQEpepigtcF7DoPCAFQlWBVwI3GW1 vmmFSOLhIDwRxWNugfLMZc6RjT9341WGYuxG5Jz9EjoaNi3Gbfcv7mkxRU7FD7LQ gZ5aytiQfXYh8AbX49n+BkuEjKQHep6IBTBlxdcWpW9FdN00DsswQKNHb9ci/NmF d0okgMETMZZSY5jE3ku+BFJD5NLYVgcFjb8VCPkuFddJkOTRdjxcQytxpycMAR3t +oR0yRVjS4XT1ZLiJLbPlnLBX4ZKlT41C4CqjVr4YCg/kH6W2rQ= =OqOE -----END PGP SIGNATURE----- --5aubanr2q2NHZ6NT2pIH2NMxlCzkajrmH--