Re: [PATCH 3/3] Make the class name in the definition match the declaration

Kamil Rytarowski
2020-01-24T14:36:49Z

[-- Attachment #1.1: Type: text/plain, Size: 1521 bytes --]

On 24.01.2020 15:14, cbiesinger@chromium.org wrote:
> From: Christian Biesinger <cbiesinger@google.com>
>
> Fixes a compile error because the class is actually called
> arm_netbsd_nat_target.
>
> gdb/ChangeLog:
>
> 2020-01-24 Christian Biesinger <cbiesinger@google.com>
>
> * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
> (arm_netbsd_nat_target::fetch_registers): ...this.
> (arm_nbsd_nat_target::store_registers): Rename to...
> (arm_netbsd_nat_target::store_registers): ...this.
>

Looks fine.

Personally I am for unwinding the 'nbsd' term in GDB more widely in more
places.

> Change-Id: Ibebfab9edeff48f54c32d0745afda1d74d31de92
> ---
> gdb/arm-nbsd-nat.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/arm-nbsd-nat.c b/gdb/arm-nbsd-nat.c
> index 31fe66c724..5072bd09ec 100644
> --- a/gdb/arm-nbsd-nat.c
> +++ b/gdb/arm-nbsd-nat.c
> @@ -191,7 +191,7 @@ fetch_fp_regs (struct regcache *regcache)
> }
>
> void
> -arm_nbsd_nat_target::fetch_registers (struct regcache *regcache, int regno)
> +arm_netbsd_nat_target::fetch_registers (struct regcache *regcache, int regno)
> {
> if (regno >= 0)
> {
> @@ -380,7 +380,7 @@ store_fp_regs (const struct regcache *regcache)
> }
>
> void
> -arm_nbsd_nat_target::store_registers (struct regcache *regcache, int regno)
> +arm_netbsd_nat_target::store_registers (struct regcache *regcache, int regno)
> {
> if (regno >= 0)
> {
>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]