Re: [PATCH 2/3 v2] Define _KMEMUSER in arm-nbsd-nat.c

Kamil Rytarowski
2020-01-24T14:29:21Z

[-- Attachment #1.1: Type: text/plain, Size: 1659 bytes --]

On 24.01.2020 15:18, cbiesinger@chromium.org wrote:
> From: Christian Biesinger <cbiesinger@google.com>
>
> Fixes the below compile error on ARM NetBSD 9.0_RC1 (the only version I
> tested). types.h does not define register_t by default.
>
> We already use this define elsewhere, notably in bsd-kvm.c.
>
> In file included from ../../gdb/arm-nbsd-nat.c:28:
> /usr/include/machine/frame.h:54:2: error: unknown type name 'register_t'; did you mean '__register_t'?
> register_t tf_spsr;
> ^
> /usr/include/machine/types.h:77:14: note: '__register_t' declared here
> typedef int __register_t;
> ^
>
> There are other compile errors that this does not fix.
>
> gdb/ChangeLog:
>
> 2020-01-24 Christian Biesinger <cbiesinger@google.com>
>
> * arm-nbsd-nat.c: Define _KMEMUSER to get the declaration of
> register_t.
>
> Change-Id: I82c21d38189ee59ea0af2538ba84b771d268722e
> ---
> gdb/arm-nbsd-nat.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/gdb/arm-nbsd-nat.c b/gdb/arm-nbsd-nat.c
> index 00f919194b..4844b51a3c 100644
> --- a/gdb/arm-nbsd-nat.c
> +++ b/gdb/arm-nbsd-nat.c
> @@ -17,6 +17,8 @@
> You should have received a copy of the GNU General Public License
> along with this program. If not, see <http://www.gnu.org/licenses/>. */
>
> +/* We define this to get types like register_t. */
> +#define _KMEMUSER
> #include "defs.h"
> #include "gdbcore.h"
> #include "inferior.h"
>

While gdb is the right user for _KMEMUSER, here we should probably go
for -D_KERNTYPES as it is the canonical symbol for register_t.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]