From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100329 invoked by alias); 24 Jan 2020 14:29:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100318 invoked by uid 89); 24 Jan 2020 14:29:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mout.gmx.net Received: from mout.gmx.net (HELO mout.gmx.net) (212.227.17.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Jan 2020 14:29:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1579876153; bh=nhVHr6qSnK3gFlOHT6v/ltmHTBDgO5Qi2lrg/+TPGuk=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=cI2wk3GgeO1UB9NGNIHaSFuMS47qz/bC3IkQexQm7j6VFA6IKZQ+oNFO+I4eEYoKg /+Q99oUG+wHXjrdwvm949wd9PeyAqTT4MCYwRmhRLMqszjveGqcCdf+HT3+D/jGPox ygbnytu/kOIkD1P4AccOqpS5GcFwJQluK51PtvEA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.241] ([89.71.135.231]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1N63VY-1jevh31dpA-016Liy; Fri, 24 Jan 2020 15:29:13 +0100 Subject: Re: [PATCH 2/3 v2] Define _KMEMUSER in arm-nbsd-nat.c To: cbiesinger@chromium.org, gdb-patches@sourceware.org Cc: Christian Biesinger References: <20200124141458.171392-3-cbiesinger@chromium.org> <20200124141818.172490-1-cbiesinger@chromium.org> From: Kamil Rytarowski Message-ID: <2afe5687-5be2-7650-d4e3-3aceed3f68f2@gmx.com> Date: Fri, 24 Jan 2020 14:32:00 -0000 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200124141818.172490-1-cbiesinger@chromium.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OKm8vF7rDEAlKx3YE8WzCo431EfqQlKhQ" X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00792.txt.bz2 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OKm8vF7rDEAlKx3YE8WzCo431EfqQlKhQ Content-Type: multipart/mixed; boundary="uUlGwQS0DdKJu8fgYeDmD4jEHkWGpYOMt"; protected-headers="v1" From: Kamil Rytarowski To: cbiesinger@chromium.org, gdb-patches@sourceware.org Cc: Christian Biesinger Message-ID: <2afe5687-5be2-7650-d4e3-3aceed3f68f2@gmx.com> Subject: Re: [PATCH 2/3 v2] Define _KMEMUSER in arm-nbsd-nat.c References: <20200124141458.171392-3-cbiesinger@chromium.org> <20200124141818.172490-1-cbiesinger@chromium.org> In-Reply-To: <20200124141818.172490-1-cbiesinger@chromium.org> --uUlGwQS0DdKJu8fgYeDmD4jEHkWGpYOMt Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Content-length: 1639 On 24.01.2020 15:18, cbiesinger@chromium.org wrote: > From: Christian Biesinger >=20 > Fixes the below compile error on ARM NetBSD 9.0_RC1 (the only version I > tested). types.h does not define register_t by default. >=20 > We already use this define elsewhere, notably in bsd-kvm.c. >=20 > In file included from ../../gdb/arm-nbsd-nat.c:28: > /usr/include/machine/frame.h:54:2: error: unknown type name 'register_t';= did you mean '__register_t'? > register_t tf_spsr; > ^ > /usr/include/machine/types.h:77:14: note: '__register_t' declared here > typedef int __register_t; > ^ >=20 > There are other compile errors that this does not fix. >=20 > gdb/ChangeLog: >=20 > 2020-01-24 Christian Biesinger >=20 > * arm-nbsd-nat.c: Define _KMEMUSER to get the declaration of > register_t. >=20 > Change-Id: I82c21d38189ee59ea0af2538ba84b771d268722e > --- > gdb/arm-nbsd-nat.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/gdb/arm-nbsd-nat.c b/gdb/arm-nbsd-nat.c > index 00f919194b..4844b51a3c 100644 > --- a/gdb/arm-nbsd-nat.c > +++ b/gdb/arm-nbsd-nat.c > @@ -17,6 +17,8 @@ > You should have received a copy of the GNU General Public License > along with this program. If not, see .= */ >=20=20 > +/* We define this to get types like register_t. */ > +#define _KMEMUSER > #include "defs.h" > #include "gdbcore.h" > #include "inferior.h" >=20 While gdb is the right user for _KMEMUSER, here we should probably go for -D_KERNTYPES as it is the canonical symbol for register_t. --uUlGwQS0DdKJu8fgYeDmD4jEHkWGpYOMt-- --OKm8vF7rDEAlKx3YE8WzCo431EfqQlKhQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-length: 833 -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEELaxVpweEzw+lMDwuS7MI6bAudmwFAl4q/wUACgkQS7MI6bAu dmzX6Q//bEPdSr7PlYYqLvjyKqU2MeJflvygT8GAbyufnK3LsJwtczncyTELGh0V Hn987aurJAXeqS8wWCInJvz0eeFwTGhsQDeahMtawHiDQ1p6hqIO39ctZuNFKQ5h ZA9+cxTMgHwxoJynLKFBWXJy5ZBqgGCu76qR+1/zf9+yw2fajpenPEcL66zhxcMj ePLId4TlrvGWJl4SZ77WCQlGGmwI7nqAesSyEkB4QDlK0MB+CEnEforesmCd3hIi TEhskk1ZVz+Bffubt1YDUfFoz+dBxmbrQSw31ju8Y/+BDoQVCn1w5F7QoCNeUNTi zVqmxccFH9QKvFhz7xK2sg+HGvjNLHJHQ8osWvcfuiDtITWh70N2SXLoTy/1Setp ymSgiorj8bp72ZE5LolVyKHD66G18jJOFQueK4k5ez+4d6Gn/1VtAPP7HjcLvtwq du9FmvLj+5N/rIVDuncNYoXlo8IhNhwMjy/6JCPPVfcn5cLWODDO9lpuSN2oSaJP 1up0crvX0nm92L7lCUD1PGd6B5918mVNP+nGnNCxyDW2WcTZWtwDKyk+qiDDIJsv C5swK7jVYUmZ3ARuRdOtAH3jQfG57TJx6jEDrR4bvCs8l3Wz//JlYX5Z1Cw8D5cM xasRdgHQFlLE+cyipr1ciqsm5MFgbikV8XWaIsr6rJSFqMdgWsE= =d1qn -----END PGP SIGNATURE----- --OKm8vF7rDEAlKx3YE8WzCo431EfqQlKhQ--