From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id eHb5JueF6GfaFx8AWB0awg (envelope-from ) for ; Sat, 29 Mar 2025 19:44:39 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=FWi8dhft; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9BB841E0C3; Sat, 29 Mar 2025 19:44:39 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3F5531E0C0 for ; Sat, 29 Mar 2025 19:44:39 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E29563857BAF for ; Sat, 29 Mar 2025 23:44:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E29563857BAF Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=FWi8dhft Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id F33DB3858D39 for ; Sat, 29 Mar 2025 23:43:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F33DB3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F33DB3858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1743291782; cv=none; b=pdpYkwlGPyWwP2yNn2nUjMLW49a9pSed0aIG2PXEexnsmaHvIKi3UfJhMRHA9wEEsJ84XqnAOcC2NC0vYeHvkFP8uE7dIwc/7NqKdpH2rBAl1yb9OU6lHHPUWqUmEfbSEEd1+HVy37/MgCOZjzptaatO2qpZnlLzJ1PgxrI+dNg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1743291782; c=relaxed/simple; bh=Y1zwApGdtOHpLufEhfIS1cMih+qqN1Nh0WHuVEb+oxw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=YpDI20F/o3iGwR9HST2bInY1EhJquhF1NhY1/43w9uTZTfRmDLcznMDcPv1fcmQ9Ab53QpWtWF1qXw+UehD8ydaM23svqJcK5PwrTFsm0jqTRH/7WEbKzIUkdXwpzVJPkARAvIOIyNwiYJI//7ZhogSSvqZXMRK4nSUs4L1IX5Q= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F33DB3858D39 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743291781; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1jpWc6ZY+SU0yWIn0uTsgzOUWI8aKrBgPU59iC0Libs=; b=FWi8dhftNFkSNgNtg8qC4eu+7OZOvdzkVD2oUAkeSeTonL4/U7ch7TWGm7ujppMgePFWac rA18f+IcndP1cEanfHk00yfkDKbqOpkY1bT1BZB2PyIWbbpcAm6WMD5YAPZbqruCsckhaX WYECqVbWUb8ho1q4q0QGoW6o15NgR7E= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-138-WJEUvf1QOj2lCPgBjdvo8Q-1; Sat, 29 Mar 2025 19:43:00 -0400 X-MC-Unique: WJEUvf1QOj2lCPgBjdvo8Q-1 X-Mimecast-MFC-AGG-ID: WJEUvf1QOj2lCPgBjdvo8Q_1743291779 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-2ff605a7a43so8950666a91.3 for ; Sat, 29 Mar 2025 16:43:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743291778; x=1743896578; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1jpWc6ZY+SU0yWIn0uTsgzOUWI8aKrBgPU59iC0Libs=; b=mge5O5fhwj/U53bgUJs8BbQQ7iFg4oUxAGf3k/kdMNyPuEz+PClADEJNttCn3ziv7M Z1/vfwGHVbfC46tiHEb8hbL2h7173r2Xuk2TrmthJfkrpdc361Tw/K29Jo7aYeWNiIFN KfZG+wMvUWHj47NJlsaS2+76lfCjXOnjm/NA+2T/jeQuz3+RRL9nALCBfY0O5v3K4njw Fy1MROnG1yuxbM2//FN8q+TFLI3agegfvPF2kdN2lf6g6TCTzUGfg8TELd7ZaoW/xpQq 9GKnaFKBrlyzz0FzQ60lhahfo9uiYUt+R56Ta3JwnWG/+7Ysuh1o0sIGKrB3YweMs3Wi /X8A== X-Forwarded-Encrypted: i=1; AJvYcCXeA1kJPCDRyV+mPx4d4vp22qPr6AjfExOydlDRraCntqG9CZe2dPlxLPMcwBScoz7kIV918z2CDNy+CA==@sourceware.org X-Gm-Message-State: AOJu0YxEZzifeszBTwsUpEiFejRGwidbKC4oA0d5D4YdS0Bpwife0NfK 83xu3qBFxAxPrPOIlYa/Zzh9u1PMlhDuD7oM6JccRHCj/m1ConxsI5H7b/dwo5jRExaKmpoj8E0 9nEWGkRjefp+zm/UCq1h1HKtc8tPTz7zn9ePAJ5grqxKoUZFI5ff6JaksBsS9oFFERo8= X-Gm-Gg: ASbGnct5HIagn0GCTrVW01VuQtyRyiSc5tOepwbhlZBn43Wr4DtR0BbpkQPjLCqKyp0 GXnFGtGHA+7kpsddgDxW93pCDEQZlCVu32yQLxvnCbxhAXKPba59iAdFXYcawjz5enm1B9MHqP9 KbTMYmbQR0iT6YfJJNX33fEbqKqgC/7yA5IB/CNzlb3dRkqLJLs6aNSPSyob8dU5lbEMAojLk3g PfgIQP4KPdjc4FATO2EB00ti8MOUE7KcwOZLUr3p+lRGMxFyDpZcmbJ1SbE2uZHtOvJU6+kVPrq u/MP+IyRD3znJycQfF71 X-Received: by 2002:a05:6a00:4b05:b0:736:4830:68a6 with SMTP id d2e1a72fcca58-739803359e7mr6922773b3a.4.1743291778649; Sat, 29 Mar 2025 16:42:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFMFuctlup7fDDGDa2YIA55Nr2HbGlDuZ67OQ0l/cNPEDlgCC0qzhP0EvQCr2UP1DOasnMi9A== X-Received: by 2002:a05:6a00:4b05:b0:736:4830:68a6 with SMTP id d2e1a72fcca58-739803359e7mr6922763b3a.4.1743291778370; Sat, 29 Mar 2025 16:42:58 -0700 (PDT) Received: from [150.1.200.127] ([172.56.105.77]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73970deef04sm4184911b3a.1.2025.03.29.16.42.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 29 Mar 2025 16:42:57 -0700 (PDT) Message-ID: <2aef1e6c-ab5d-4884-8de2-0073ace3e194@redhat.com> Date: Sat, 29 Mar 2025 16:42:57 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] gdb-add-index: fix shellcheck warnings To: Sam James , gdb-patches@sourceware.org References: <0fa2e0d207eef78dc6a4305ee28588676932753e.1743188332.git.sam@gentoo.org> From: Keith Seitz In-Reply-To: <0fa2e0d207eef78dc6a4305ee28588676932753e.1743188332.git.sam@gentoo.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: XbuPVoCcRuY2S3xdMal6yqoIBvqlpHPWstK6CQkwusQ_1743291779 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi, On 3/28/25 11:58 AM, Sam James wrote: > * Drop useless echo > * Add missing quoting to rm argument (and use -- to delimit options) > * Fix quoting w/ trap to avoid expanding $tmp_files immediately Again, thank you for doing this. > --- > gdb/contrib/gdb-add-index.sh | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/gdb/contrib/gdb-add-index.sh b/gdb/contrib/gdb-add-index.sh > index b299f830373..f727d28aac7 100755 > --- a/gdb/contrib/gdb-add-index.sh > +++ b/gdb/contrib/gdb-add-index.sh > @@ -163,10 +162,10 @@ for f in "$file" "$dwz_file"; do > tmp_files="$tmp_files $index4 $index5 $debugstr $debugstrmerge $debugstrerr" > done > > -rm -f $tmp_files > +rm -f -- "$tmp_files" By preventing expansion, wouldn't this be attempting to erase a single file whose name is a concatenation of all the temporary files? That is, $ touch a b c $ tmp="a b c" $ rm -- "$tmp" rm: cannot remove 'a b c': No such file or directory Keith