From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1616 invoked by alias); 19 Dec 2014 18:06:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1543 invoked by uid 89); 19 Dec 2014 18:06:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: na01-bn1-obe.outbound.protection.outlook.com Received: from mail-bn1bon0056.outbound.protection.outlook.com (HELO na01-bn1-obe.outbound.protection.outlook.com) (157.56.111.56) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA256 encrypted) ESMTPS; Fri, 19 Dec 2014 18:06:34 +0000 Received: from BN1BFFO11HUB007.protection.gbl (10.58.144.154) by BN1BFFO11HUB059.protection.gbl (10.58.144.206) with Microsoft SMTP Server (TLS) id 15.1.26.17; Fri, 19 Dec 2014 18:06:31 +0000 Received: from BN1BFFO11FD018.protection.gbl (10.58.144.34) by BN1BFFO11HUB007.protection.gbl (10.58.144.154) with Microsoft SMTP Server (TLS) id 15.1.26.17; Fri, 19 Dec 2014 18:06:10 +0000 Received: from xsj-pvapsmtpgw01 (149.199.60.83) by BN1BFFO11FD018.mail.protection.outlook.com (10.58.144.81) with Microsoft SMTP Server (TLS) id 15.1.26.17 via Frontend Transport; Fri, 19 Dec 2014 18:06:09 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1Y21tV-0000w4-HZ; Fri, 19 Dec 2014 10:03:17 -0800 From: Ajit Kumar Agarwal To: Pedro Alves , Michael Eager , "Joel Brobecker" CC: "gdb-patches@sourceware.org" , Vinod Kathail , Vidhumouli Hunsigida , "Nagaraju Mekala" Subject: RE: [Patch] Microblaze: Port of Linux gdbserver Date: Fri, 19 Dec 2014 18:06:00 -0000 References: <25de23b98e054fd291ea232d10f2800c@BN1BFFO11FD018.protection.gbl> <5436B7D0.9060004@eagercon.com> <543E7630.5060001@redhat.com> <99de529c620a4bb0a118a9fc39ae6ad0@BY2FFO11FD008.protection.gbl> <548F2240.7020700@redhat.com> <5492BA45.8090205@redhat.com> <81895ba3cb504c4b8a4365c3ffba0444@BY2FFO11FD051.protection.gbl> <549405CB.1030208@redhat.com> In-Reply-To: <549405CB.1030208@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-RCIS-Action: ALLOW Message-ID: <2acafbbe2f4945a1ae06e2286752ef61@BN1BFFO11FD018.protection.gbl> X-EOPAttributedMessage: 0 Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=ajit.kumar.agarwal@xilinx.com; X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(438002)(377454003)(189002)(13464003)(51704005)(24454002)(479174004)(199003)(69234005)(108616004)(33646002)(102836002)(107046002)(93886004)(64706001)(47776003)(106466001)(20776003)(6806004)(53416004)(62966003)(23676002)(77156002)(104016003)(2950100001)(4396001)(31966008)(92726002)(54356999)(106116001)(50986999)(76176999)(92566001)(21056001)(46102003)(86362001)(19580395003)(19580405001)(50466002)(2656002)(87936001)(120916001)(99396003)(74316001)(107986001)(24736002)(23106004);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1BFFO11HUB007;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;MLV:sfv;PTR:unknown-60-83.xilinx.com;MX:1;A:1;LANG:en; X-Microsoft-Antispam: UriScan:;UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:BN1BFFO11HUB007; X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004);SRVR:BN1BFFO11HUB007; X-Forefront-PRVS: 0430FA5CB7 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:BN1BFFO11HUB007; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:BN1BFFO11HUB059; X-OriginatorOrg: xilinx.com X-SW-Source: 2014-12/txt/msg00581.txt.bz2 DQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBnZGItcGF0 Y2hlcy1vd25lckBzb3VyY2V3YXJlLm9yZyBbbWFpbHRvOmdkYi1wYXRjaGVz LW93bmVyQHNvdXJjZXdhcmUub3JnXSBPbiBCZWhhbGYgT2YgUGVkcm8gQWx2 ZXMNClNlbnQ6IEZyaWRheSwgRGVjZW1iZXIgMTksIDIwMTQgNDozMyBQTQ0K VG86IEFqaXQgS3VtYXIgQWdhcndhbDsgTWljaGFlbCBFYWdlcjsgSm9lbCBC cm9iZWNrZXINCkNjOiBnZGItcGF0Y2hlc0Bzb3VyY2V3YXJlLm9yZzsgVmlu b2QgS2F0aGFpbDsgVmlkaHVtb3VsaSBIdW5zaWdpZGE7IE5hZ2FyYWp1IE1l a2FsYQ0KU3ViamVjdDogUmU6IFtQYXRjaF0gTWljcm9ibGF6ZTogUG9ydCBv ZiBMaW51eCBnZGJzZXJ2ZXINCg0KT24gMTIvMTkvMjAxNCAxMDoyNiBBTSwg QWppdCBLdW1hciBBZ2Fyd2FsIHdyb3RlOg0KPiAtLS0tLU9yaWdpbmFsIE1l c3NhZ2UtLS0tLQ0KPiBGcm9tOiBQZWRybyBBbHZlcyBbbWFpbHRvOnBhbHZl c0ByZWRoYXQuY29tXQ0KPiBTZW50OiBUaHVyc2RheSwgRGVjZW1iZXIgMTgs IDIwMTQgNDo1OCBQTQ0KPiBUbzogQWppdCBLdW1hciBBZ2Fyd2FsOyBNaWNo YWVsIEVhZ2VyOyBKb2VsIEJyb2JlY2tlcg0KPiBDYzogZ2RiLXBhdGNoZXNA c291cmNld2FyZS5vcmc7IFZpbm9kIEthdGhhaWw7IFZpZGh1bW91bGkgSHVu c2lnaWRhOyANCj4gTmFnYXJhanUgTWVrYWxhDQo+IFN1YmplY3Q6IFJlOiBb UGF0Y2hdIE1pY3JvYmxhemU6IFBvcnQgb2YgTGludXggZ2Ric2VydmVyDQo+ IA0KPiBPbiAxMi8xOC8yMDE0IDA4OjU2IEFNLCBBaml0IEt1bWFyIEFnYXJ3 YWwgd3JvdGU6DQo+PiBGcm9tOiBQZWRybyBBbHZlcyBbbWFpbHRvOnBhbHZl c0ByZWRoYXQuY29tXSBPbiAxMC8xNy8yMDE0IDA4OjIyIFBNLCANCj4+IEFq aXQgS3VtYXIgQWdhcndhbCB3cm90ZToNCj4+DQo+Pj4gR2RiLmJhc2UgZ2Ri IHRlc3RzdWl0ZSBpcyBydW4gYW5kIGhlcmUgaXMgdGhlIHN0YXR1cyBvZiBn ZGIgdGVzdHN1aXRlIHJ1biBmb3IgZ2RiLmJhc2UuDQo+Pj4NCj4+PiAgICAg ICAgICAgICAgICAgPT09IGdkYiBTdW1tYXJ5ID09PQ0KPj4+DQo+Pj4gIyBv ZiBleHBlY3RlZCBwYXNzZXMgICAgICAgICAgICA3ODA0DQo+Pj4gIyBvZiB1 bmV4cGVjdGVkIGZhaWx1cmVzICAgICAgICAyMjYzDQo+Pg0KPj4+PiBPdmVy IDIwMDAgdW5leHBlY3RlZCBmYWlsdXJlcyBpcyBub3QgdmVyeSByZWFzc3Vy aW5nIHRob3VnaC4NCj4+Pj4gSGF2ZSB5b3UgbG9va2VkIGF0IHRoZSBsb2dz IHRvIGdldCBhbiBpZGVhIG9mIHdoYXQgbWlnaHQgYmUgYnJva2VuPw0KPj4N Cj4+IFdlIGhhdmUgbG9va2VkIGF0IHRoZSBsb2cgZmlsZXMgZm9yIHRoZSBm YWlsdXJlcy4gSGVyZSBhcmUgdGhlIG1haW4gY2F0ZWdvcmllcyBvZiB0aGUg ZmFpbHVyZS4NCj4+DQo+PiAxLiBwdXNoX2R1bW15X2NvZGUgaXMgbm90IGlt cGxlbWVudGVkIGZvciBNaWNybyBibGF6ZSBwb3J0ICBkdWUgdG8gdGhpcyAg dGhlcmUgYXJlIDM1MCsgZmFpbHVyZXMuDQo+IA0KPj4+IEVoLCBubyBpbmZl cmlvciBmdW5jdGlvbiBjYWxsIHN1cHBvcnQuICBBcmUgeW91IHBsYW5uaW5n IG9uIGltcGxlbWVudGluZyB0aGlzPw0KPiANCj4+PiBZb3UgY2FuIHNldCBn ZGIsY2Fubm90X2NhbGxfZnVuY3Rpb25zIGluIHlvdXIgYm9hcmQgZmlsZSB0 byBza2lwIHRoZSBhZmZlY3RlZCB0ZXN0cyBtZWFud2hpbGUuDQo+IA0KPj4g Mi4gIEZhaWx1cmVzIGZvciBzaWduYWxzIGlzIGFyb3VuZCAzNTcuDQo+IA0K Pj4+IFdoYXQgc29ydCBvZiBmYWlsdXJlcz8NCj4gDQo+PiAzLiBXYXRjaCBw b2ludCAgZmFpbHVyZXMgYXJlIGFyb3VuZCA4MTcuDQo+IA0KPj4+IFNldCBn ZGIsbm9faGFyZHdhcmVfd2F0Y2hwb2ludHMgaW4gdGhlIGJvYXJkIGZpbGUu DQo+IA0KPiBUaGFua3MuIFdlIGhhdmUgdXNlZCB0aGUgZm9sbG93aW5nIGdk YiBvcHRpb25zIGFzIHBlciB5b3VyIHN1Z2dlc3Rpb25zLg0KPiANCj4gc2V0 X2JvYXJkX2luZm8gZ2RiLG5vX2hhcmR3YXJlX3dhdGNocG9pbnRzIDEgc2V0 X2JvYXJkX2luZm8gDQo+IGdkYixjYW5ub3RfY2FsbF9mdW5jdGlvbnMgMSBz ZXRfYm9hcmRfaW5mbyBnZGIsbm9zaWduYWxzIDENCj4gDQoNCj4+VG8gYmUg Y2xlYXIsIGdkYixub3NpZ25hbHMgaXMgZm9yIHRhcmdldHMgdGhhdCB0cnVs eSBoYXZlIG5vIGNvbmNlcHQgb2Ygc2lnbmFscy4gIEEgTGludXggcG9ydCBz aG91bGQgbm90IG5lZWQgdGhhdC4uLiAgSXQncyBwcm9iYWJseSBtYXNraW5n IG91dCByZWFsIHByb2JsZW1zLg0KDQpUaGFua3MuIEkgaGF2ZSBhZGRlZCBn ZGIsbm9zaWduYWxzIHRvIGludmVzdGlnYXRlIHRoZSBmYWlsdXJlcyBmb3Ig c2lnbmFsIGhhbmRsaW5nLiBTb3JyeSBmb3IgdGhhdC4NCg0KPiBUaGUgZ2Ri IHN1bW1hcnkgZm9yIGdkYi5iYXNlIGlzIGFzIGZvbGxvd3M6DQo+IA0KPiAg ICAgICAgICAgICAgICAgPT09IGdkYiBTdW1tYXJ5ID09PQ0KPiANCj4gIyBv ZiBleHBlY3RlZCBwYXNzZXMgICAgICAgICAgICA2MDQ3DQo+ICMgb2YgdW5l eHBlY3RlZCBmYWlsdXJlcyAgICAgICAgNTM5DQoNCj4+RllJLCB0aGlzIGlz IHdheSBoaWdoZXIgdGhhbiBJJ2QgZXhwZWN0IGFmdGVyIGRpc2FibGluZyBh bGwgdGhhdCBmdW5jdGlvbmFsaXR5Lg0KDQoNCkNvdWxkIHlvdSBwbGVhc2Ug bGV0IG1lIGtub3cgd2hhdCBpcyB0aGUgZXhwZWN0ZWQgZmFpbHVyZXMgIGFm dGVyIGRpc2FibGluZyBhbGwgdGhhdCBmdW5jdGlvbmFsaXR5Lg0KDQpUaGFu a3MgJiBSZWdhcmRzDQpBaml0DQoNCj4gIyBvZiBleHBlY3RlZCBmYWlsdXJl cyAgICAgICAgICAxNw0KPiAjIG9mIGtub3duIGZhaWx1cmVzICAgICAgICAg ICAgIDIxDQo+ICMgb2YgdW5yZXNvbHZlZCB0ZXN0Y2FzZXMgICAgICAgMjYN Cj4gIyBvZiB1bnRlc3RlZCB0ZXN0Y2FzZXMgICAgICAgICA0Mw0KPiAjIG9m IHVuc3VwcG9ydGVkIHRlc3RzICAgICAgICAgIDEzMw0KPiANCj4gSSB3aWxs IHNlbmQgdGhlIG1vZGlmaWVkIHBhdGNoIGluY29ycG9yYXRpbmcgeW91ciBj b21tZW50cy4NCg0KVGhhbmtzLg0KUGVkcm8gQWx2ZXMNCg0K >From gdb-patches-return-118549-listarch-gdb-patches=sources.redhat.com@sourceware.org Fri Dec 19 19:25:18 2014 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 6940 invoked by alias); 19 Dec 2014 19:25:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 6931 invoked by uid 89); 19 Dec 2014 19:25:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 19 Dec 2014 19:25:15 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBJJP2oF020841 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 19 Dec 2014 14:25:02 -0500 Received: from host2.jankratochvil.net (ovpn-116-142.ams2.redhat.com [10.36.116.142]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sBJJOvHC029231 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Fri, 19 Dec 2014 14:25:00 -0500 Date: Fri, 19 Dec 2014 19:25:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: Kai Tietz , Eli Zaretskii , sellcey@imgtec.com, brobecker@adacore.com, yao@codesourcery.com, gdb-patches@sourceware.org Subject: Re: [patch] compile: rm -rf -> ftw()+rmdir()+unlink() [Re: [patch] compile: Fix MinGW build] Message-ID: <20141219192457.GA28791@host2.jankratochvil.net> References: <20141217210144.GA26674@host2.jankratochvil.net> <83wq5oub28.fsf@gnu.org> <20141218173103.GA18871@host2.jankratochvil.net> <83sigcua9l.fsf@gnu.org> <526566540.670835.1418933688966.JavaMail.zimbra@redhat.com> <5493678F.4050906@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5493678F.4050906@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg00582.txt.bz2 Content-length: 1618 On Fri, 19 Dec 2014 00:47:27 +0100, Pedro Alves wrote: > For our purposes, both APIs are just as good (*). It's just > that ftw has System V roots, while fts has BSD roots. > > In practice, programs that use fts instead are just, if not > more portable. > > But, as I mentioned, gnulib provides an fts replacement > for systems that don't have it. So if we use fts instead, we're > good to go everywhere. Linux fts man page http://man7.org/linux/man-pages/man3/fts.3.html says BUGS All of the APIs described in this man page are not safe when compiling a program using the LFS APIs (e.g., when compiling with -D_FILE_OFFSET_BITS=64). and _FILE_OFFSET_BITS=64 happens on 32-bit hosts and --enable-64-bit-bfd. Contrary to it gnulib fts documentation https://www.gnu.org/software/gnulib/manual/html_node/fts_005fread.html says On platforms where off_t is a 32-bit type, this function may not correctly report the size of files or block devices larger than 2 GB and may not work correctly on huge directories larger than 2 GB. Also, on platforms where ino_t is a 32-bit type, this function may report inode numbers incorrectly. The fix is to use the AC_SYS_LARGEFILE macro (only on Mac OS X systems). This would suggest as if GDB should be compatible with 32-bit hosts and --enable-64-bit-bfd GDB should use gnulib fts even on Linux; but I guess the gnulib fts replacement would not be active on Linux. The temporary files being deleted are never larger than 2GB nor their size is read. So I hope nobody is going address these issues (I would add 32-bit hosts are not relevant anymore anyway). Jan