From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id U/pyHV8HjGCPZQAAWB0awg (envelope-from ) for ; Fri, 30 Apr 2021 09:34:23 -0400 Received: by simark.ca (Postfix, from userid 112) id 701FE1F11C; Fri, 30 Apr 2021 09:34:23 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9D4CD1E783 for ; Fri, 30 Apr 2021 09:34:22 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 00A853851C3E; Fri, 30 Apr 2021 13:34:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 00A853851C3E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619789662; bh=8mHggonDbXT/iJn3AwTvMmJ8J/r0+j7QwYKstcSIGqU=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=d9phVxelu6HapnhImkZJ9brA9YRect/LIIwocKjFhvudnybyPn73/55t2EhY/5l59 sBc3MptbHQ4P6A5T/5CV9pXrELvWtCr8OhEFWOC5m3vpWAJHLFDVI/VDq/9UiQWnt+ OuLLV/yfOgegqMW8eNfieZwaTwXabmfEJi7ECWt8= Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) by sourceware.org (Postfix) with ESMTPS id 481D23851C3E for ; Fri, 30 Apr 2021 13:34:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 481D23851C3E Received: by mail-qk1-x72a.google.com with SMTP id v20so15735551qkv.5 for ; Fri, 30 Apr 2021 06:34:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8mHggonDbXT/iJn3AwTvMmJ8J/r0+j7QwYKstcSIGqU=; b=h2XVCe4LsPgOWGuEz5sGjw5BlTEqIwHfFf17zgLKq/MApdiKDLBDsF7EE8tEcH3aCB 2Q/GaykvW6Kl7ORBOoCJgjsExPhax1GadutZ39gWY+H/pk1RByQ7urIuEPtmsAxTQ8xr qNfDlGOOBz7Gwt+ejL2E2JyBIDQbDGzwnmiXBg+VVjDOtsrYUO2JpoN5IVOLfyWeiUBc trWlCQcHX/I8N+pCGQu2Uyw5mwk0+cFwxa6VCbeykvAaX2TcWZ4N+a6UdcJE62z3rx/w /vVB+NkkzDySac1mOMBXpUpH+0UN2kITw1RAABItdIGxjOoA8nwoKLPTCpJU0PWodJxC AFrQ== X-Gm-Message-State: AOAM532e5ROCHmcqGxjxkMon1xIs395ZZ/tUvIDfAK23nGxx0qrah5me FnGeFsYB2d5sDhZdxK12sy2lkUrF9HvXqw== X-Google-Smtp-Source: ABdhPJx2ac0lDdQLIhee0rdtYf760lZDbIS3qvGYGTf7QxCTsl8CIPQ5/wsTW4WUf1lLRzm4DyAOHQ== X-Received: by 2002:a05:620a:70c:: with SMTP id 12mr5338713qkc.377.1619789658866; Fri, 30 Apr 2021 06:34:18 -0700 (PDT) Received: from ?IPv6:2804:7f0:4841:2d9e:407c:a880:b5f9:cf8c? ([2804:7f0:4841:2d9e:407c:a880:b5f9:cf8c]) by smtp.gmail.com with ESMTPSA id p145sm1423318qke.67.2021.04.30.06.34.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Apr 2021 06:34:18 -0700 (PDT) Subject: Re: [committed][gdb/testsuite] Make gdb.mi/mi-sym-info.exp more robust against timeouts To: Simon Marchi , Tom de Vries , gdb-patches@sourceware.org References: <20210430092743.GA24286@delia.home> <1c7ee1d2-9ff0-645c-3a0e-b6d1ed3f328f@linaro.org> <26770214-5135-391b-6bd0-4b5f39b97149@polymtl.ca> <42e495c3-2d64-ad20-8402-1c0b409db001@polymtl.ca> Message-ID: <2a638604-5146-6c0d-07fd-a0073ce61d31@linaro.org> Date: Fri, 30 Apr 2021 10:34:14 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <42e495c3-2d64-ad20-8402-1c0b409db001@polymtl.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb-patches Reply-To: Luis Machado Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 4/30/21 10:28 AM, Simon Marchi wrote: > On 2021-04-30 9:20 a.m., Luis Machado wrote:> On 4/30/21 10:06 AM, Simon Marchi wrote: >>> On 2021-04-30 8:55 a.m., Luis Machado via Gdb-patches wrote: >>>> Wouldn't it be more reliable to do line-by-line matching instead of sprinkling timeouts across the test? Or so I've been told. >>>> >>>> This doesn't seem to be an instance where GDB is taking too long, but rather that the MI output is very verbose, right? >>> >>> From what I can see, it's a case of GDB thinking for a long time >>> (gathering symbols) before outputting anything. You can see it >>> by having a >>> >>> $ tail -F testsuite/gdb.log >>> >>> on the side, while you run the test. >>> >>> Another one that I found times out in a similar way on my machine is >>> gdb.base/info-os.exp. >>> >>> Simon >>> >> >> Fair enough. But I also see the output being 113K chars in one case, no line breaks. I think these instances of very long lines are something to be dealt with. > > Yeah, good point. If GDB takes 6 seconds to think and Dejagnu takes 6 > seconds to read the long input, the timeout is a result of the > combination of both, so it wouldn't hurt to parse item by item. It's a > bit more work to parse one item at the time, but in the end I think it > also helps when you need to debug the test, as you can print a little > something after parsing each item and know where things went wrong. What I'm unsure about is if the MI protocol cares about line breaks or not. If not, there is no reason we should be putting out such long line, as it is hard on the test infrastructure. > > Simon >