Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: gdb-patches@sourceware.org
Cc: eliz@gnu.org
Subject: Re: [PATCH] Use console uiout when executing breakpoint commands
Date: Wed, 01 Nov 2017 01:37:00 -0000	[thread overview]
Message-ID: <2a3ce6b1-844a-e212-28f7-3787c325ad66@polymtl.ca> (raw)
In-Reply-To: <20171021184121.694-1-simon.marchi@polymtl.ca>

On 2017-10-21 02:41 PM, Simon Marchi wrote:
> As reported here
> 
>   https://sourceware.org/ml/gdb/2017-10/msg00020.html
> 
> the output of certain commands, like backtrace, doesn't appear anywhere
> when it is run as a breakpoint command and when using MI.
> 
> The reason is that the current_uiout is set to the mi_ui_out while these
> commands run, whereas we want the output as CLI output.  Some commands
> like "print" work, because they use printf_filtered (gdb_stdout, ...)
> directly, bypassing the current ui_out.
> 
> The fix I did is to force setting the cli_uiout as the current_uiout
> when calling execute_control_command.  I am not sure if this is the
> right way to fix the problem, comments about the approach would be
> appreciated.
> 
> I enhanced gdb.mi/mi-break.exp to test the backtrace command.
> 
> Regtested on the buildbot.

I pushed this patch in.

Simon


  reply	other threads:[~2017-11-01  1:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <8360bqt0im.fsf@gnu.org>
     [not found] ` <8a3d7153-7486-032f-aabc-6c3453f96459@simark.ca>
     [not found]   ` <83shetsdg2.fsf@gnu.org>
     [not found]     ` <e65519d3-37e8-06f0-cd5a-d7e6b7aaf31d@simark.ca>
     [not found]       ` <83o9phs8zw.fsf@gnu.org>
     [not found]         ` <b0ce9014-a231-6d57-8a72-6da1eb80f67b@simark.ca>
     [not found]           ` <83d15wsrvw.fsf@gnu.org>
     [not found]             ` <83bmlgsqpm.fsf@gnu.org>
     [not found]               ` <fb95da6b-2390-f486-0806-291d24fbe766@simark.ca>
2017-10-21  8:26                 ` Breakpoint commands in MI mode and "backtrace" Eli Zaretskii
     [not found]                   ` <f54ff4bc-fb7c-397f-153d-83cafb6966bd@simark.ca>
2017-10-21 16:27                     ` Eli Zaretskii
2017-10-21 18:41                   ` [PATCH] Use console uiout when executing breakpoint commands Simon Marchi
2017-11-01  1:37                     ` Simon Marchi [this message]
2017-11-01  3:45                       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a3ce6b1-844a-e212-28f7-3787c325ad66@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox