From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aKbEIp3qSWdBfwQAWB0awg (envelope-from ) for ; Fri, 29 Nov 2024 11:23:57 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=py8p53K+; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qBDRTySB; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=py8p53K+; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qBDRTySB; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 863EF1E097; Fri, 29 Nov 2024 11:23:57 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CF8D21E05C for ; Fri, 29 Nov 2024 11:23:56 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6A9543858CDA for ; Fri, 29 Nov 2024 16:23:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6A9543858CDA Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=py8p53K+; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qBDRTySB; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=py8p53K+; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qBDRTySB Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 7F66C3858CD9 for ; Fri, 29 Nov 2024 16:22:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7F66C3858CD9 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7F66C3858CD9 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732897330; cv=none; b=vj4btAxWpktBSrzsIbAlT89Q4Q3tGPrw2T3zD7yC980ZTcDCnBE3use+ruKszo3IvNJE9gIGrD7BF5juDS55Pq+yjIqg1THvfDg0M3mkTMRPsKU0ay2JIMJde42/j5sfybkvTI5xIr0VyjJkVC8LlvDfz/sYpQwCGOu8vjHX//o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732897330; c=relaxed/simple; bh=hy1JWyDIYuHZnuq8CUUOOVt2ovEjP2Psi3+Vc7j/1Tw=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=sKIOLg5tQhXOuf1oeC/kA+BnMwjpadtopyGsudXhL2lkKYXu3UpfdxoJxjVBVMMyxVYlBabpBRq5DEgS9ULoHMfQwFguy+yjzQ+Ufq8/QAOvabBqq7G6Np0z/n5yQLblm6TJoQ7QEwTLpWAnjLAxjdie/D+h9E4G5zIMeXThJQE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7F66C3858CD9 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 664CE21125; Fri, 29 Nov 2024 16:22:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1732897329; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9Rwb17NS6h311d/Juuou5sjvQuk+i30ItzA5zA1suXY=; b=py8p53K++Kcr55FPwTicD04QuY8r5+lhES0LG4PrU5ujcgTL7j5wgUxWffuFj0pb4nssPM uL0pbFo4wN2+WLmsAt1+OzZxyuNu6/d1igVlzxxJ3P5XHZoCRYfLYWeiTGBnAuUhBpLX/B TUkaqV2PRHMEiJs3a8ech4aHbmIQE6I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1732897329; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9Rwb17NS6h311d/Juuou5sjvQuk+i30ItzA5zA1suXY=; b=qBDRTySByCdBGyFL+F3Lym6TEpYaHIfsGBTP4ursiIC9tidkUjf9pNnizKCpLK2NHhNRqi 3RpaXCHgjn3GsuBA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=py8p53K+; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=qBDRTySB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1732897329; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9Rwb17NS6h311d/Juuou5sjvQuk+i30ItzA5zA1suXY=; b=py8p53K++Kcr55FPwTicD04QuY8r5+lhES0LG4PrU5ujcgTL7j5wgUxWffuFj0pb4nssPM uL0pbFo4wN2+WLmsAt1+OzZxyuNu6/d1igVlzxxJ3P5XHZoCRYfLYWeiTGBnAuUhBpLX/B TUkaqV2PRHMEiJs3a8ech4aHbmIQE6I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1732897329; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9Rwb17NS6h311d/Juuou5sjvQuk+i30ItzA5zA1suXY=; b=qBDRTySByCdBGyFL+F3Lym6TEpYaHIfsGBTP4ursiIC9tidkUjf9pNnizKCpLK2NHhNRqi 3RpaXCHgjn3GsuBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 48528133F3; Fri, 29 Nov 2024 16:22:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ce8rEDHqSWeXWAAAD6G6ig (envelope-from ); Fri, 29 Nov 2024 16:22:09 +0000 Message-ID: <2a0ca637-82c7-4194-9b5e-6ce6802e3415@suse.de> Date: Fri, 29 Nov 2024 17:23:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] [gdbsupport] Add gdb::{waitpid,read,write,close} To: Simon Marchi , Tom Tromey Cc: gdb-patches@sourceware.org References: <20241028174913.27056-1-tdevries@suse.de> <87y122501s.fsf@tromey.com> <9b20eea0-0f14-47d9-ad7f-39e197d2e521@suse.de> <70b41955-4a06-47db-a467-ef8f24ca030a@suse.de> Content-Language: en-US From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 664CE21125 X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCPT_COUNT_THREE(0.00)[3]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 11/29/24 17:15, Simon Marchi wrote: > > > On 2024-11-22 11:46, Tom de Vries wrote: >> On 11/5/24 13:07, Tom de Vries wrote: >>> On 11/1/24 18:35, Tom Tromey wrote: >>>>>>>>> "Tom" == Tom de Vries writes: >>>> >>>> Tom> +namespace gdb { >>>> Tom> + >>>> Tom> +extern "C" { >>>> >>>> I didn't even know this was valid ... but is it really needed? >>>> It seems wrong. >>>> >>> >>> It seemed to work: >>> ... >>> $ cat test.c >>> namespace gdb { >>> >>> extern "C" { >>> int foo (void) { return 1; }; >>> } >>> } >>> >>> $ cat test2.c >>> namespace gdb { >>> extern "C" { >>> int foo (void); >>> } >>> } >>> >>> int >>> main (void) >>> { >>> return gdb::foo (); >>> } >>> $ g++ test.c test2.c >>> ... >>> but the linkage symbol is plain foo: >>> ... >>> $ nm ./a.out | grep foo >>> 00000000004004c7 T foo >>> ... >>> >>> So, you're right, this is wrong. >>> >>> I seem to have ended up with gdb_waitpid instead of gdb::waitpid in v2, similar to gdb_select, but thinking about it now I slightly prefer gdb::waitpid. I suppose it doesn't matter that much. >>> >> >> When looking at this again today, it bugged me enough rewrite v2 in the gdb::waitpid style. Committed after retesting. > > When building for mingw-w64, I see this, which seems related: > > CXX cli/cli-cmds.o > In file included from /home/simark/src/binutils-gdb/gdb/cli/cli-cmds.c:58: > /home/simark/src/binutils-gdb/gdb/../gdbsupport/eintr.h: In function ‘pid_t gdb::waitpid(pid_t, int*, int)’: > /home/simark/src/binutils-gdb/gdb/../gdbsupport/eintr.h:77:35: error: ‘::waitpid’ has not been declared; did you mean ‘gdb::waitpid’? > 77 | return gdb::handle_eintr (-1, ::waitpid, pid, wstatus, options); > | ^~~~~~~ > | gdb::waitpid > /home/simark/src/binutils-gdb/gdb/../gdbsupport/eintr.h:75:1: note: ‘gdb::waitpid’ declared here > 75 | waitpid (pid_t pid, int *wstatus, int options) > | ^~~~~~~ > > Note that to get to it, you have to step past this other build error in > gdbserver (by doing `make all-gdb` for instance): > > https://inbox.sourceware.org/gdb-patches/75926446-4c8a-40ee-8ed8-ab55f38e1520@simark.ca/T/#m194744b18419e37dfb4ec82c8e0ce73fb017ba17 Hi Simon, thanks for reporting this. I don't have a windows setup unfortunately, so I have no way of reproducing this, and at this point I have no idea why waitpid is not declared. Thanks, - Tom