From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5469 invoked by alias); 24 Sep 2012 15:08:26 -0000 Received: (qmail 5460 invoked by uid 22791); 24 Sep 2012 15:08:24 -0000 X-SWARE-Spam-Status: No, hits=-4.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from server-nat-6.cs.umd.edu (HELO bacon.cs.umd.edu) (128.8.127.149) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Sep 2012 15:08:12 +0000 Received: from [10.109.170.227] (129-2-129-154.wireless.umd.edu [129.2.129.154]) (Authenticated sender: khooyp) by bacon.cs.umd.edu (Postfix) with ESMTPSA id 93D9CB4048E; Mon, 24 Sep 2012 11:08:00 -0400 (EDT) Subject: Re: [PATCH 2/2] Try to initialize data-directory by first searching for "data-directory" in the same directory as the gdb binary Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Khoo Yit Phang In-Reply-To: <20120924145910.GE4146@adacore.com> Date: Mon, 24 Sep 2012 15:08:00 -0000 Cc: Khoo Yit Phang , Jan Kratochvil , GDB Patches Content-Transfer-Encoding: quoted-printable Message-Id: <2F996037-77F9-4B9C-8734-D4BA8373F133@cs.umd.edu> References: <21ACC598-F6B4-4117-BA7B-B316414DE9E3@cs.umd.edu> <20120919130040.GA20442@host2.jankratochvil.net> <20120921183122.GB8747@host2.jankratochvil.net> <20120922110822.GA28159@host2.jankratochvil.net> <78B3333C-92F9-474D-8352-087C5A0F575B@cs.umd.edu> <20120924072945.GA4146@adacore.com> <20120924145910.GE4146@adacore.com> To: Joel Brobecker X-CSD-MailScanner-ID: 93D9CB4048E.A15D8 X-CSD-MailScanner: Found to be clean X-CSD-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-50, required 5, autolearn=not spam, ALL_TRUSTED -50.00) X-CSD-MailScanner-From: khooyp@cs.umd.edu X-CSD-MailScanner-Watermark: 1349104081.24323@7BKS5kvx/LPTMbBmz2wgIA Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00506.txt.bz2 Hi, On Sep 24, 2012, at 10:59 AM, Joel Brobecker wrote: >> How about this solution, instead of patching the gdb binary, I can >> install a shell script into the build directory that contains: >=20 > In addition to Eli's comments, a shell script isn't debuggable. >=20 > I know we are walking on thin ice with this data-directory issue, > but I think it's worth our trouble in this case. The side-effect > of your _gdb patch is something that's really important to me; > that's why I am pushing a little harder than usual. >=20 > As far as I could tell, Jan and yourself were discussing two patches > that should work. You like neither of them, but short of having > a solution that either of you likes, why not just commit one of them? > As long as we take the build data-directory as a fallback over a non- > existant standard (configured/possibly relocated) data-directory, > I don't see a problem. I'd just like to point out any issues that may arise in the future and offe= r other solutions; but I'm willing to commit either patch. Which one would = you prefer? Yit September 24, 2012