From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32172 invoked by alias); 9 Feb 2017 13:26:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32108 invoked by uid 89); 9 Feb 2017 13:26:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.7 required=5.0 tests=AWL,BAYES_50,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=sk:get_reg, rabbit, REG_VALID, reg_valid X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com Received: from mail-db5eur01on0084.outbound.protection.outlook.com (HELO EUR01-DB5-obe.outbound.protection.outlook.com) (104.47.2.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Feb 2017 13:26:23 +0000 Received: from VI1PR0801MB1822.eurprd08.prod.outlook.com (10.168.68.7) by VI1PR0801MB1821.eurprd08.prod.outlook.com (10.168.67.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.888.16; Thu, 9 Feb 2017 13:26:18 +0000 Received: from VI1PR0801MB1822.eurprd08.prod.outlook.com ([10.168.68.7]) by VI1PR0801MB1822.eurprd08.prod.outlook.com ([10.168.68.7]) with mapi id 15.01.0888.026; Thu, 9 Feb 2017 13:26:18 +0000 From: Alan Hayward To: Yao Qi CC: Pedro Alves , Joel Brobecker , "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH] Removal of uses of MAX_REGISTER_SIZE Date: Thu, 09 Feb 2017 13:26:00 -0000 Message-ID: <2F1152B6-D09E-4D48-9DF9-7D39D5CF0489@arm.com> References: <45e3a5e1-a9aa-1bc0-5d08-526b89fc458e@redhat.com> <20170201124123.GA27498@E107787-LIN> <20170202094012.dge4r6rsl2skdrii@adacore.com> <20170203102819.GA11916@E107787-LIN> <25716edf-096e-20c5-4170-fb8ca04d897b@redhat.com> <0C6A0D51-4C49-4400-8C46-E77DD512DF56@arm.com> <20170203165022.GB11916@E107787-LIN> <1E0030CE-FB37-4821-AA53-9C6D1CC285C9@arm.com> <20170206152635.GE11916@E107787-LIN> <5F3D30AE-9A53-493A-B6DC-DF594C2FAB18@arm.com> <8660kkpq1l.fsf@gmail.com> In-Reply-To: <8660kkpq1l.fsf@gmail.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-office365-filtering-correlation-id: d15c514e-4d65-4ba6-2e85-08d450ef3b0a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081);SRVR:VI1PR0801MB1821; x-microsoft-exchange-diagnostics: 1;VI1PR0801MB1821;7:9g2zCW/2gbj0FOcT04Uiruuox/EioqErMZdzub2Xqwb18lIz2w0i/tdpxAbeK+GZnvEueJ3ckIOYJNBEf1KX5O1uLpsL86bNeHTDSkVK1dIiTjtOUueGjGlwoIFEDBhFy+9vbtRz/gbmJKMuk8nVrISmXW88yhArkj7xg8x2/GZyFbJMb7QiL5hruVRxISO+G9DcxHzsR6rLGSaOPrZ0MC9dWHeGidbtuJgt28WINCddl95qZkPf11cRRPuf80eSbhk3fysi6kvXeLcWVsHq5FOkaB8qa8Gd/g/IHX1m+itvKku8dvzJLifGlFEodI176wZHDGpne5h1SVNLs1coFSmTT1hw8mO0s+urh4mpreeMOMRpysHQwovwrA9z9jueNahImB8mcRmhngGhys0P55g8fUkcmvsObeT+j93bU+XTjsifjielmk296hs9cmjXE7f07JOJABHkunPh93szNGps1I1OEVLZFfY5l3TmVNffidEW/wkePVYULTnhzHFjpwFqS3AIPxCktlX/vfSG9g== nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6041248)(20161123564025)(20161123562025)(20161123560025)(20161123558025)(20161123555025)(6072148);SRVR:VI1PR0801MB1821;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0801MB1821; x-forefront-prvs: 02135EB356 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(39840400002)(39860400002)(39450400003)(39850400002)(39410400002)(24454002)(199003)(189002)(33656002)(5660300001)(2900100001)(92566002)(36756003)(3280700002)(2906002)(122556002)(4326007)(6506006)(53936002)(66066001)(82746002)(86362001)(6486002)(83716003)(39060400001)(229853002)(1411001)(77096006)(6246003)(53546003)(105586002)(106116001)(106356001)(54356999)(93886004)(2950100002)(6916009)(101416001)(76176999)(50986999)(305945005)(7736002)(38730400002)(110136004)(8676002)(81156014)(81166006)(6512007)(68736007)(3660700001)(97736004)(99286003)(6116002)(3846002)(6436002)(54906002)(25786008)(8936002)(189998001)(102836003)(104396002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0801MB1821;H:VI1PR0801MB1822.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <2D7782B9956EFC469FB95AF10441E5D3@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2017 13:26:18.0048 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1821 X-SW-Source: 2017-02/txt/msg00224.txt.bz2 DQo+IE9uIDggRmViIDIwMTcsIGF0IDE3OjA5LCBZYW8gUWkgPHFpeWFvbHRj QGdtYWlsLmNvbT4gd3JvdGU6DQo+IA0KPiBBbGFuIEhheXdhcmQgPEFsYW4u SGF5d2FyZEBhcm0uY29tPiB3cml0ZXM6DQo+IA0KPj4gQEAgLTExMzUsOCAr MTEzNSw4IEBAIHJlZ2lzdGVyX2NoYW5nZWRfcCAoaW50IHJlZ251bSwgc3Ry dWN0IHJlZ2NhY2hlICpwcmV2X3JlZ3MsDQo+PiAJCSAgICBzdHJ1Y3QgcmVn Y2FjaGUgKnRoaXNfcmVncykNCj4+IHsNCj4+ICAgc3RydWN0IGdkYmFyY2gg KmdkYmFyY2ggPSBnZXRfcmVnY2FjaGVfYXJjaCAodGhpc19yZWdzKTsNCj4+ IC0gIGdkYl9ieXRlIHByZXZfYnVmZmVyW01BWF9SRUdJU1RFUl9TSVpFXTsN Cj4+IC0gIGdkYl9ieXRlIHRoaXNfYnVmZmVyW01BWF9SRUdJU1RFUl9TSVpF XTsNCj4+ICsgIHN0ZDo6dmVjdG9yPGdkYl9ieXRlPiBwcmV2X2J1ZmZlciAo cmVnaXN0ZXJfc2l6ZSAoZ2RiYXJjaCwgcmVnbnVtKSk7DQo+PiArICBzdGQ6 OnZlY3RvcjxnZGJfYnl0ZT4gdGhpc19idWZmZXIgKHJlZ2lzdGVyX3NpemUg KGdkYmFyY2gsIHJlZ251bSkpOw0KPj4gICBlbnVtIHJlZ2lzdGVyX3N0YXR1 cyBwcmV2X3N0YXR1czsNCj4+ICAgZW51bSByZWdpc3Rlcl9zdGF0dXMgdGhp c19zdGF0dXM7DQo+PiANCj4gDQo+IFRoaXMgZnVuY3Rpb24gc2hvdWxkIGJl IG1vdmVkIHRvIHJlZ2NhY2hlLmMsIGJlY2F1c2UgaXQgaXMgYWJvdXQNCj4g Y29tcGFyaW5nIGJ5dGVzIG9mIGEgY2VydGFpbiByZWdpc3RlciBpbiBib3Ro IHJlZ2NhY2hlcy4gIFRoZW4sIHdlbiBjYW4NCj4gY29tcGFyZSByYXcgcmVn aXN0ZXJzIGZyb20gcmVnaXN0ZXJfYnVmZmVyLCBhbmQgcHNldWRvIHJlZ2lz dGVycyBmcm9tDQo+IHRoZSB2YWx1ZXMuDQoNClRyeWluZyB0byByZW1vdmUg dGhlIGJ1ZmZlciByZXN1bHRzIGluIHF1aXRlIGEgbG90IG9mIGNvZGUsIGFz IHlvdSBjYW7igJl0IGFzc3VtZQ0KdGhlIHJlZ2lzdGVyIGhhcyB0aGUgc2Ft ZSBzdGF0ZSBpbiBib3RoIHByZXZfcmVncyBhbmQgdGhpc19yZWdzLg0KRm9y IHBzZXVkbyBjYXNlcywgaXQgd2lsbCBzdGlsbCByZXN1bHQgaW4gYnVmZmVy IHVzYWdlLg0KKEF0dGVtcHRlZCBjb2RlIHBhc3RlZCBiZWxvdykuDQoNCkkg ZmVlbCB0aGlzIGlzIGFkZGluZyBhIHdob2xlIGxvdCBvZiBjb21wbGV4aXR5 IGFuZCBtb3N0bHkgZHVwbGljYXRlcyBjb2RlIGZyb20NCnJlZ2NhY2hlX2Nv b2tlZF9yZWFkLg0KDQpVbmxlc3MgeW91IHJlYWxseSBmZWVsIHRoaXMgY2Fz ZSBpcyBnb2luZyB0byBoaXQgcGVyZm9ybWFuY2UsIHRoZW4gSSB0aGluayB0 aGUNCmV4aXN0aW5nIGNvZGUgaXMgbXVjaCBzaW1wbGVyIGFuZCBlYXNpZXIg dG8gcmVhZC4NCg0KKEhhcHB5IHRvIG1vdmUgdGhlIGZ1bmN0aW9uIHRvIHJl Z2NhY2hlIGFuZCBjaGFuZ2UgcmVzdWx0IHRvIGEgYm9vbCkuDQoNCg0KDQpN YXliZSBhIGxvbmcgdGVybSBzb2x1dGlvbiB3b3VsZCBiZSBhbiBhbHRlcm5h dGl2ZSBhZGRpdGlvbmFsIHZlcnNpb24gb2YNCnJlZ2NhY2hlX2Nvb2tlZF9y ZWFkOg0KDQplbnVtIHJlZ2lzdGVyX3N0YXR1cw0KcmVnY2FjaGVfY29va2Vk X3JlYWQgKHN0cnVjdCByZWdjYWNoZSAqcmVnY2FjaGUsIGludCByZWdudW0s IGdkYl9ieXRlICoqYnVmLCANCgkJICAgICAgYm9vbCAqcmVxdWlyZXNfZGVh bGxvY2F0aW9uKQ0KDQpUaGUgZnVuY3Rpb24gcmV0dXJucyB5b3UgYSBwdHIg aW4gKipidWYuIElmICpyZXF1aXJlc19kZWFsbG9jYXRpb24gaXMgdHJ1ZSB0 aGVuIHlvdQ0KbmVlZCB0byBmcmVlIGJ1ZiBvbmNlIHlvdSBoYXZlIGZpbmlz aGVkIHdpdGggaXQuDQoNCk9yIG1heWJlIGEgdmVyc2lvbiBvZiByZWdjYWNo ZV9jb29rZWRfcmVhZCB3aGljaCByZXR1cm5zIGEgc3RydWN0ICp2YWx1ZQ0K KGFzc3VtaW5nIGl04oCZcyBwb3NzaWJsZSB0byBzZXQgdGhlIGJ1ZmZlciBp biBhIHN0cnVjdCB2YWx1ZSB0byBiZSBhbiBleGlzdGluZyBwb2ludGVyKS4N Cg0KVGhpcyBjb3VsZCB0aGVuIGJlIHVzZWQgdGhyb3VnaG91dCB0aGUgY29k ZWJhc2UsIHByZXZlbnRpbmcgbG90cyBvZiBzbWFsbCBtZW1jcHkuDQpIb3dl dmVyLCB0aGF0IHdvdWxkIHRoZW4gb3BlbiBhIHJhYmJpdCBob2xlIG9mIGNo YW5nZXMgdG8gY29tbW9uIGZ1bmN0aW9ucywgd2hpY2ggaXMNCmFsbCBmYXIg b3V0IG9mIHRoZSBzY29wZSBvZiB0aGVzZSBwYXRjaGVzLg0KDQpJdOKAmXMg cG9zc2libGUgdGhhdCBhbGwgdGhhdCBpcyBub3QgcG9zc2libGUgYmVjYXVz ZSB3ZSBkb27igJl0IHdhbnQgdG8gZXhwb3NlIHRoZQ0KaW50ZXJuYWwgcmVn Y2FjaGUgcG9pbnRlcnMgaW4gY2FzZSB0aGUgdmFsdWVzIG1vdmUuDQoNCg0K DQpUaGlzIHdhcyBteSB3b3JrIGluIHByb2dyZXNzOg0KDQoNCmJvb2wNCnJl Z2NhY2hlX3JlZ2lzdGVyX2NoYW5nZWRfcCAoaW50IHJlZ251bSwgc3RydWN0 IHJlZ2NhY2hlICpwcmV2X3JlZ3MsDQoJCQkgICAgIHN0cnVjdCByZWdjYWNo ZSAqdGhpc19yZWdzKQ0Kew0KICBzdHJ1Y3QgZ2RiYXJjaCAqdGhpc19nZGJh cmNoID0gZ2V0X3JlZ2NhY2hlX2FyY2ggKHRoaXNfcmVncyk7DQogIHN0cnVj dCBnZGJhcmNoICpwcmV2X2dkYmFyY2g7DQogIGdkYl9ieXRlICpwcmV2X2J1 ZmZlciA9IE5VTEw7DQogIGdkYl9ieXRlICp0aGlzX2J1ZmZlciA9IE5VTEw7 DQogIGVudW0gcmVnaXN0ZXJfc3RhdHVzIHByZXZfc3RhdHVzOw0KICBlbnVt IHJlZ2lzdGVyX3N0YXR1cyB0aGlzX3N0YXR1czsNCiAgZ2RiX2Fzc2VydCAo cmVnbnVtID49IDApOw0KICBnZGJfYXNzZXJ0IChyZWdudW0gPCB0aGlzX3Jl Z3MtPmRlc2NyLT5ucl9jb29rZWRfcmVnaXN0ZXJzKTsNCg0KICAvKiBpZiB0 aGVyZSBhcmUgbm8gcHJldmlvdXMgcmVnaXN0ZXJzIGNvbnNpZGVyIGFsbCBy ZWdpc3RlcnMgYXMgY2hhbmdlZC4gICovDQogIGlmICghcHJldl9yZWdzKQ0K ICAgIHJldHVybiB0cnVlOw0KICBnZGJfYXNzZXJ0IChyZWdudW0gPCByZWdj YWNoZS0+ZGVzY3ItPm5yX2Nvb2tlZF9yZWdpc3RlcnMpOw0KDQogIHByZXZf Z2RiYXJjaCA9IGdldF9yZWdjYWNoZV9hcmNoIChwcmV2X3JlZ3MpOw0KDQog IC8qIElmIGFyY2hlcyBkb24ndCBtYXRjaCB0aGVuIGNvbnNpZGVyIGFsbCBy ZWdpc3RlcnMgYXMgY2hhbmdlZC4gICovDQogIGlmIChwcmV2X2dkYmFyY2gg IT0gZ2RiYXJjaCkNCiAgICByZXR1cm4gdHJ1ZTsNCg0KICBpZiAocmVnbnVt IDwgcmVnY2FjaGUtPmRlc2NyLT5ucl9yYXdfcmVnaXN0ZXJzKQ0KICB7DQog ICAgcHJldl9zdGF0dXMgPSBwcmV2X3JlZ3MtPnJlZ2lzdGVyX3N0YXR1c1ty ZWdudW1dOw0KICAgIHRoaXNfc3RhdHVzID0gdGhpc19zdGF0dXMtPnJlZ2lz dGVyX3N0YXR1c1tyZWdudW1dOw0KICAgIHByZXZfYnVmZmVyID0gcmVnaXN0 ZXJfYnVmZmVyIChwcmV2X3JlZ3MsIHJlZ251bSk7DQogICAgdGhpc19idWZm ZXIgPSByZWdpc3Rlcl9idWZmZXIgKHRoaXNfcmVncywgcmVnbnVtKTsNCiAg fQ0KICBlbHNlDQogIHsNCiAgICBpZiAocHJldl9yZWdzLT5yZWFkb25seV9w DQoJJiYgcHJldl9yZWdzLT5yZWdpc3Rlcl9zdGF0dXNbcmVnbnVtXSAhPSBS RUdfVU5LTk9XTikNCiAgICAgIHsNCiAgICAgIAlwcmV2X3N0YXR1cyA9IHBy ZXZfcmVncy0+cmVnaXN0ZXJfc3RhdHVzW3JlZ251bV07DQogICAgICAJcHJl dl9idWZmZXIgPSByZWdpc3Rlcl9idWZmZXIgKHByZXZfcmVncywgcmVnbnVt KTsNCiAgICAgIH0NCiAgICAgZWxzZSBpZiAoZ2RiYXJjaF9wc2V1ZG9fcmVn aXN0ZXJfcmVhZF92YWx1ZV9wIChwcmV2X3JlZ3MtPmRlc2NyLT5nZGJhcmNo KSkNCiAgICAgIHsNCglzdHJ1Y3QgdmFsdWUgKm1hcmssICpjb21wdXRlZDsN Cg0KCW1hcmsgPSB2YWx1ZV9tYXJrICgpOw0KDQoJY29tcHV0ZWQgPSBnZGJh cmNoX3BzZXVkb19yZWdpc3Rlcl9yZWFkX3ZhbHVlIChwcmV2X2dkYmFyY2gs DQoJCQkJCQkgICAgICAgcHJldl9yZWdzLCByZWdudW0pOw0KCWlmICh2YWx1 ZV9lbnRpcmVseV9hdmFpbGFibGUgKGNvbXB1dGVkKSkNCgkgIHsNCgkgICAg cHJldl9idWZmZXIgPSB2YWx1ZV9jb250ZW50c19yYXcgKGNvbXB1dGVkKTsN CgkgICAgcHJldl9zdGF0dXMgPSBSRUdfVkFMSUQ7DQoJICB9DQoJZWxzZQ0K CSAgcHJldl9zdGF0dXMgPSBSRUdfVU5BVkFJTEFCTEU7DQoJfQ0KICAgICAg fQ0KICAgICBlbHNlDQogICAgICB7DQogICAgICAJcHJldl9idWZmZXIgPSB4 bWFsbG9jIChyZWdpc3Rlcl9zaXplIChwcmV2X2dkYmFyY2gsIHJlZ251bSkp Ow0KICAgICAgCWdkYmFyY2hfcHNldWRvX3JlZ2lzdGVyX3JlYWQgKHByZXZf Z2RiYXJjaCwgcHJldl9yZWdjYWNoZSwgcmVnbnVtLCBwcmV2X2J1ZmZlcik7 DQogICAgICB9DQoNCiAgICAgIC4uLi5kdXBsaWNhdGUgYWJvdmUgY29kZSBm b3IgdGhpc19yZWdjYWNoZS4uLi4NCiAgICAgIFBvc3NpYmx5IHB1dCBhYm92 ZSBjb2RlIGludG8gYSBzdGF0aWMgZnVuY3Rpb24gKGJ1dCB0aGVuIHlvdSBz dGlsbCBoYXZlIHRvIGRlYWwNCiAgICAgIHdpdGggYWxsb2NhdGlvbiBhbmQg ZnJlZXMgc3Bhbm5pbmcgdGhlIGZ1bmN0aW9ucykNCg0KICB9DQoNCg0KICBp ZiAodGhpc19zdGF0dXMgIT0gcHJldl9zdGF0dXMpDQogICAgcmV0ID0gdHJ1 ZTsNCiAgZWxzZSBpZiAodGhpc19zdGF0dXMgPT0gUkVHX1ZBTElEKQ0KICAg IHJldCA9IG1lbWNtcCAocHJldl9idWZmZXIsIHRoaXNfYnVmZmVyLA0KCQkg IHJlZ2lzdGVyX3NpemUgKGdkYmFyY2gsIHJlZ251bSkpICE9IDA7DQogIGVs c2UNCiAgICByZXQgPSBmYWxzZTsNCg0KICAuLi5jb2RlIHRvIGZyZWUgYW55 IGJ1ZiBvciBtYXJrIGZvciBjcmVhdGVkIGZvciBlaXRoZXIgcHJldiBhbmQg dGhpcy4uLg0KDQogIHJldHVybiByZXQ7DQp9DQoNCg0KDQoNCj4gDQo+PiBA QCAtMTE0NiwxMyArMTE0NiwxMyBAQCByZWdpc3Rlcl9jaGFuZ2VkX3AgKGlu dCByZWdudW0sIHN0cnVjdCByZWdjYWNoZSAqcHJldl9yZWdzLA0KPj4gICAg IHJldHVybiAxOw0KPj4gDQo+PiAgIC8qIEdldCByZWdpc3RlciBjb250ZW50 cyBhbmQgY29tcGFyZS4gICovDQo+PiAtICBwcmV2X3N0YXR1cyA9IHJlZ2Nh Y2hlX2Nvb2tlZF9yZWFkIChwcmV2X3JlZ3MsIHJlZ251bSwgcHJldl9idWZm ZXIpOw0KPj4gLSAgdGhpc19zdGF0dXMgPSByZWdjYWNoZV9jb29rZWRfcmVh ZCAodGhpc19yZWdzLCByZWdudW0sIHRoaXNfYnVmZmVyKTsNCj4+ICsgIHBy ZXZfc3RhdHVzID0gcmVnY2FjaGVfY29va2VkX3JlYWQgKHByZXZfcmVncywg cmVnbnVtLCBwcmV2X2J1ZmZlci5kYXRhICgpKTsNCj4+ICsgIHRoaXNfc3Rh dHVzID0gcmVnY2FjaGVfY29va2VkX3JlYWQgKHRoaXNfcmVncywgcmVnbnVt LCB0aGlzX2J1ZmZlci5kYXRhICgpKTsNCj4+IA0KPj4gICBpZiAodGhpc19z dGF0dXMgIT0gcHJldl9zdGF0dXMpDQo+PiAgICAgcmV0dXJuIDE7DQo+PiAg IGVsc2UgaWYgKHRoaXNfc3RhdHVzID09IFJFR19WQUxJRCkNCj4+IC0gICAg cmV0dXJuIG1lbWNtcCAocHJldl9idWZmZXIsIHRoaXNfYnVmZmVyLA0KPj4g KyAgICByZXR1cm4gbWVtY21wIChwcmV2X2J1ZmZlci5kYXRhICgpLCB0aGlz X2J1ZmZlci5kYXRhICgpLA0KPj4gCQkgICByZWdpc3Rlcl9zaXplIChnZGJh cmNoLCByZWdudW0pKSAhPSAwOw0KPj4gICBlbHNlDQo+PiAgICAgcmV0dXJu IDA7DQo+IA0KPiAtLSANCj4gWWFvICjpvZDlsKcpDQoNCg== >From gdb-patches-return-136848-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Feb 09 15:09:02 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 49468 invoked by alias); 9 Feb 2017 15:09:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 49453 invoked by uid 89); 9 Feb 2017 15:09:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.0 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=Core, Philipp, philipp, linux-kernel X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Feb 2017 15:08:58 +0000 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v19F8nkM039906 for ; Thu, 9 Feb 2017 10:08:57 -0500 Received: from e06smtp09.uk.ibm.com (e06smtp09.uk.ibm.com [195.75.94.105]) by mx0a-001b2d01.pphosted.com with ESMTP id 28gqghs69t-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 09 Feb 2017 10:08:57 -0500 Received: from localhost by e06smtp09.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 9 Feb 2017 15:08:55 -0000 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp09.uk.ibm.com (192.168.101.139) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 9 Feb 2017 15:08:53 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 5B3EE2190019; Thu, 9 Feb 2017 15:07:56 +0000 (GMT) Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v19F8qxg1835486; Thu, 9 Feb 2017 15:08:52 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B0CA052043; Thu, 9 Feb 2017 14:07:36 +0000 (GMT) Received: from ThinkPad (unknown [9.152.212.148]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 773C152045; Thu, 9 Feb 2017 14:07:36 +0000 (GMT) Date: Thu, 09 Feb 2017 15:09:00 -0000 From: Philipp Rudo To: Yao Qi Cc: gdb-patches@sourceware.org, peter.griffin@linaro.org, yao.qi@arm.com, arnez@linux.vnet.ibm.com Subject: Re: [RFC 3/7] Add basic Linux kernel support In-Reply-To: <86wpczo6o9.fsf@gmail.com> References: <20170112113217.48852-1-prudo@linux.vnet.ibm.com> <20170112113217.48852-4-prudo@linux.vnet.ibm.com> <20170207105403.GA1630@E107787-LIN> <86wpczo6o9.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17020915-0036-0000-0000-0000036A09B1 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17020915-0037-0000-0000-0000150E4DD5 Message-Id: <20170209160851.1a63b508@ThinkPad> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-09_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1702090137 X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00225.txt.bz2 Content-length: 2975 Hi Yao wow. Thats wonderful. Now we know we can go this way for testing. One minor thing I noticed in your code (which is actually my mistake) > struct mm_struct > {}; > > struct mm_struct init_mm; You don't need those two when you are only interested in thread handling. The mm_struct and init_mm are needed for address translation and actually belong in the commit with module handling ... Fixed it for v3. Thanks a lot Philipp On Thu, 09 Feb 2017 13:05:58 +0000 Yao Qi wrote: > Yao Qi writes: > > > I am playing your first three patches on x86_64 with some hacks. > > I write a small program with the same linux kernel "signature", and > > want GDB treat it as a linux kernel. > > > > I make some progress on writing such small test case, > see the code below. I hacked lk_try_push_target not to do the > sanity check, and not to call lk_try_push_target in > lk_observer_inferior_created, so that I can push this target layer > when I want. > > (gdb) break stop^M > Breakpoint 2 at 0x400711: > file /home/yao/SourceCode/gnu/gdb/git/gdb/testsuite/gdb.base/linux-kernel.c, > line 104.^M (gdb) continue^M Continuing.^M > ^M > Breakpoint 2, stop () > at /home/yao/SourceCode/gnu/gdb/git/gdb/testsuite/gdb.base/linux-kernel.c:104^M > 104 {}^M (gdb) PASS: gdb.base/linux-kernel.exp: continue to > breakpoint: stop > > at this point, the list of tasks are set up, switch to linux-kernel > target layer, > > target linux-kernel^M > [New process 8001]^M > (gdb) PASS: gdb.base/linux-kernel.exp: target linux-kernel > maintenance print target-stack^M > The current target stack is:^M > - linux-kernel (linux kernel support)^M > - native (Native process)^M > - exec (Local exec file)^M > - None (None)^M > > It works! In this way, we can test that GDB can successfully parse > the these data structures in Linux kernel without Linux kernel image > at all. > > Then, we can generate a coredump, > > (gdb) generate-core-file > Saved corefile core.9614 > > Remove the hack in lk_observer_inferior_created, so that GDB can > automatically push linux-kernel target layer, > > $ ./gdb ./testsuite/outputs/gdb.base/linux-kernel/linux-kernel ./core.9614 > [New LWP 9614] > [New process 9614] > Core was generated by > `/scratch/yao/gdb/build-git/x86_64/gdb/testsuite/outputs/gdb.base/linux-kernel/li'. > Program terminated with signal SIGTRAP, Trace/breakpoint trap. #0 > stop () > at /home/yao/SourceCode/gnu/gdb/git/gdb/testsuite/gdb.base/linux-kernel.c:104 > 104 {} [Current thread is 1 (PID: 9614*, 0x602010)] (gdb) > maintenance print target-stack The current target stack is: > - linux-kernel (linux kernel support) > - core (Local core dump file) > - exec (Local exec file) > - None (None) > > The next step would be extending the test case to a multi-threaded > program, so that we can create task lists for these threads, and > generate coredump which is similar to the kernel coredump. >