From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23366 invoked by alias); 27 Jun 2002 18:58:49 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23321 invoked from network); 27 Jun 2002 18:58:46 -0000 Received: from unknown (HELO harvester.transas.com) (193.125.200.2) by sources.redhat.com with SMTP; 27 Jun 2002 18:58:46 -0000 Received: from localhost (localhost [127.0.0.1]) by harvester.transas.com (Postfix) with SMTP id 0FBEB6B821; Thu, 27 Jun 2002 22:58:31 +0400 (MSD) Received: from clue.transas.com (clue.transas.com [10.0.0.42]) by harvester.transas.com (Postfix) with ESMTP id 05E666B820; Thu, 27 Jun 2002 22:58:24 +0400 (MSD) Received: by clue.transas.com with Internet Mail Service (5.5.2653.19) id ; Thu, 27 Jun 2002 22:58:24 +0400 Message-ID: <2E74F312D6980D459F3A05492BA40F8DFE33B0@clue.transas.com> From: Andrew Volkov To: Kevin Buettner Cc: gdb-patches@sources.redhat.com, jimb@redhat.com, ezannoni@redhat.com Subject: RE: [RFA/RFC] blockframe.c Fix errorneous addr check Date: Thu, 27 Jun 2002 11:58:00 -0000 MIME-Version: 1.0 Content-Type: text/plain; charset="koi8-r" X-SW-Source: 2002-06/txt/msg00562.txt.bz2 > >On Jun 27, 10:08pm, Andrew Volkov wrote: > >> Daniel you're right, this bug in coffread.c(complete_symtab) >function, >> rather, in invalid calculating of current_source_end_addr: >> >> current_source_end_addr = start_addr + size; >> >> but must be: >> >> current_source_end_addr = start_addr + size + ; >> >> As I understand, since machine address size is not known at >time of parsing >> coff file, then we have big trouble :(. > >Could you explain why you need to add in the size of an address? It's not necessarily must be addr sizeof, it may be 1, but, I think, will be better, if current_source_end_addr will contain correct value for target. > >Assuming it is needed, won't TARGET_PTR_BIT / TARGET_CHAR_BIT >provide the >correct size? > >Kevin > Sorry, I forget about this macros :) Andrey