From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50526 invoked by alias); 27 Feb 2019 22:26:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50511 invoked by uid 89); 27 Feb 2019 22:26:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=baldwin, Baldwin X-HELO: mx2.freebsd.org Received: from mx2.freebsd.org (HELO mx2.freebsd.org) (8.8.178.116) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Feb 2019 22:26:36 +0000 Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id DB1FC754CF; Wed, 27 Feb 2019 22:26:33 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 239BA938F6; Wed, 27 Feb 2019 22:26:33 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-3.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id AD3299CA9; Wed, 27 Feb 2019 22:26:32 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: [PATCH 0/7] Use warn_unused_result on release methods To: Tom Tromey , gdb-patches@sourceware.org References: <20190227221814.17661-1-tromey@adacore.com> From: John Baldwin Openpgp: preference=signencrypt Message-ID: <29ee742e-2a41-a4bb-771a-7d5c97499d9b@FreeBSD.org> Date: Wed, 27 Feb 2019 22:26:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190227221814.17661-1-tromey@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 239BA938F6 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.99 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.99)[-0.992,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US] X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00550.txt.bz2 On 2/27/19 2:18 PM, Tom Tromey wrote: > This applies the warn_unused_result attribute to various "release" > methods in gdb. The idea here is to avoid the bug where "release" is > used when "reset (nullptr)" is meant. > > This caught one bug, so I consider it a success. Perhaps the new > attribute can be used elsewhere as well. > > Tested by the buildbot. > Let me know what you think. Looks good to me. -- John Baldwin