From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14725 invoked by alias); 9 Sep 2017 18:22:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14716 invoked by uid 89); 9 Sep 2017 18:22:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 09 Sep 2017 18:22:56 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v89IMoSP009828 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 9 Sep 2017 14:22:54 -0400 Received: by simark.ca (Postfix, from userid 112) id F228E1E984; Sat, 9 Sep 2017 14:22:49 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 966101E984; Sat, 9 Sep 2017 14:22:48 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 09 Sep 2017 18:22:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 2/7] Remove make_cleanup_ui_out_table_begin_end In-Reply-To: <87y3pndfmk.fsf@bapiya> References: <20170909153540.15008-1-tom@tromey.com> <20170909153540.15008-3-tom@tromey.com> <87y3pndfmk.fsf@bapiya> Message-ID: <29dd1075cea4be9035966dbe5335f7e4@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sat, 9 Sep 2017 18:22:50 +0000 X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00245.txt.bz2 On 2017-09-09 18:02, Tom Tromey wrote: > I forgot to mention something I had meant to mention when submitting > this series: > > Tom> * spu-tdep.c (info_spu_mailbox_list): Use ui_out_emit_table. > Tom> (info_spu_dma_cmdlist): Likewise. > [..] > Tom> * darwin-nat-info.c (darwin_debug_regions_recurse): Use > Tom> ui_out_emit_table. > > I don't have any way to test these, or even compile the darwin patch. > So this requires extra careful review at least, or someone to volunteer > to try them out. > > It would be very nice to have a darwin builder hooked up to the > buildbot. I'm not sure how practical this is ... there are so many > Macs > around Moz that maybe I could acquire one somehow, but I don't know > that I could host it anywhere. The patch LGTM. I built-tested your series on a Mac, it builds fine (if we ignore all the current hurdles to get it to build). Now when I try actually running, I get this: (gdb) r Starting program: /Users/simark/build/binutils-gdb/gdb/test_clang [New Thread 0x1503 of process 79554] [New Thread 0x1803 of process 79554] Warning: Cannot insert breakpoint -1. Cannot access memory at address 0xeb19 Command aborted. But it also does that before your patch. Simon