From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id rFkUJSlG/Wm0giAAWB0awg (envelope-from ) for ; Thu, 07 May 2026 22:10:49 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=wrus6qs+; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7F1601E0BA; Thu, 07 May 2026 22:10:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 02ACA1E093 for ; Thu, 07 May 2026 22:10:49 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BC6284BA2E23 for ; Fri, 8 May 2026 02:10:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BC6284BA2E23 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=wrus6qs+ Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 10DF94BA2E0C for ; Fri, 8 May 2026 02:10:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 10DF94BA2E0C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 10DF94BA2E0C Authentication-Results: sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778206219; cv=none; b=M2iqNQIMdquw11H7FhSFzvOARmCKQxsY+c4gVAABmcdpOSFFdVnr+R8Yl3a/eS5zTIcgQEUzg1WvfaEjCeVICSeNtQi6UEFB0/RS0SXsBJuXuPpH0r61fRbzircyUbcXxD0HlxV3LPi9wwarrih198waqWLsPSzqwuOqwcL11uU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778206219; c=relaxed/simple; bh=TXNMEA+VJx2H22+Ajc7UpayZk7q/IhCtKL9oK/ROh/0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=YAse0UJg3hvaVhUYHYcklq2uR1HgfEetgkpPzxS/d+1VgjxkZsz+eme47gHKFVDJwCftpEWdECqEIVb5jFvvkerR5Dz/b9/zkgmuBi/20QgtMqGVbLMTxqEzLpsPE/wt5W9/h2FfCcvraw1AQ3og/2rB4Ek6vFkOIwoZUHA74Vk= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=wrus6qs+ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 10DF94BA2E0C Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 6482ACCK130298 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 7 May 2026 22:10:17 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 6482ACCK130298 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1778206217; bh=vn40Dli2dhsFT6+B8Y9B9L2Ew/bHJIGZwJBansXuDfo=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=wrus6qs+oQQof8/tzrLcQATZ+PYcGi8YD2jXOf/WaMoj+XQWwCUx75zZ4pX+7A+mG UfSkHSF30FBQ6m7p11mO+jMis6n4W/5ssQs80iiJQZGid3Al/zMjGzTklDNHUWbWbv SYfMOZiFWekbbKZRvb+ZKG1cEkDPDVz47UBu9k1hCX53pgoYNwkP0iFwAj9CE2eZYS m370TFHOU9Bchl+hrfRr2Xiezo7tziQcahiX5UU1nURfAWDO6eCd8GsID4NmoUxFYY bOfEagADGf8rxQTXL3SCzsUFl5jbKVUfvEJ8Aa6iCNMtlmEgq/+UJyZP6JHgeGeQ0Q aNvG0sSwPbAJQ== Received: by simark.ca (Postfix) id 59D2B1E093; Thu, 07 May 2026 22:10:12 -0400 (EDT) Message-ID: <29cde9aa-7de0-4edf-9c54-6a4e9e3eb19f@polymtl.ca> Date: Thu, 7 May 2026 22:10:12 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/11] gdb/solib-rocm: save inferior in rocm_solib_ops To: Tom Tromey , Simon Marchi Cc: gdb-patches@sourceware.org References: <20251209193610.296085-1-simon.marchi@efficios.com> <20251209193610.296085-8-simon.marchi@efficios.com> <87a4unm59w.fsf@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87a4unm59w.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 8 May 2026 02:10:12 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/28/26 12:14 PM, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> From: Simon Marchi > Simon> Saving the inferior the rocm_solib_ops is for can avoid using > Simon> `current_inferior ()` at a couple of places. > > I had to read this a few times to parse it. You're right, me too, after a few months. > Maybe rewording it to something like "Storing the inferior in > rocm_solib_ops lets us avoid some calls to current_inferior()" or > something along those lines. I took your suggestion as-is, it's straight to the point. Simon