From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26851 invoked by alias); 3 Oct 2018 15:02:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26598 invoked by uid 89); 3 Oct 2018 15:02:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS autolearn=ham version=3.3.2 spammy=latent, forbid X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Oct 2018 15:01:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1538578912; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=0VxwNGEoiih5LQUwgmHDEWUpuMJmciKVSNK5QZiJ3+0=; b=OgtgPxGU90HfwPgo3ztGss2dFqZKu4BsnMzfjiH611Wr/f+htaUAhC8FCtEaNot3 1kGHY81HtESOMT6kAvKV3MxgGDypGkEQVo7ci9nz9qHtyCnX8VSGNzh7BACBUxSF xegeFORFgzqj+EGErmsn9FomIwlaEan6Z8Qcnifrjao=; Received: from ESESSMB501.ericsson.se (Unknown_Domain [153.88.183.119]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id E1.0A.05037.FD9D4BB5; Wed, 3 Oct 2018 17:01:51 +0200 (CEST) Received: from ESESSMB502.ericsson.se (153.88.183.163) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 3 Oct 2018 17:01:45 +0200 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB502.ericsson.se (153.88.183.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Wed, 3 Oct 2018 17:01:44 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0VxwNGEoiih5LQUwgmHDEWUpuMJmciKVSNK5QZiJ3+0=; b=FJWn6hhRjYsijA/rh3zxk9wh7GA4LyH2M5kzjKyHEP0yFKDKmj4Jtv0gJLf+DFeb4gYCYwaOjW24SxgMxJQr6sdMqjGUAON0vrcMrZKnh9xIaybIHXoNtkpSFCKPZto0sLZauUgeujpaY5XZk1u2LsbgBlT958o92PnRgmi7HMk= Received: from BYAPR15MB2390.namprd15.prod.outlook.com (52.135.198.30) by BYAPR15MB2389.namprd15.prod.outlook.com (52.135.198.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1185.24; Wed, 3 Oct 2018 15:01:42 +0000 Received: from BYAPR15MB2390.namprd15.prod.outlook.com ([fe80::619e:2dbd:180c:a2fb]) by BYAPR15MB2390.namprd15.prod.outlook.com ([fe80::619e:2dbd:180c:a2fb%4]) with mapi id 15.20.1185.024; Wed, 3 Oct 2018 15:01:42 +0000 From: Simon Marchi To: Tom Tromey , "gdb-patches@sourceware.org" Subject: Re: [PATCH 0/8] Add -Wshadow=local Date: Wed, 03 Oct 2018 15:02:00 -0000 Message-ID: <29c17639-6ee6-b089-be95-227f98ac0ccf@ericsson.com> References: <20180923040814.27941-1-tom@tromey.com> In-Reply-To: <20180923040814.27941-1-tom@tromey.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) Content-Type: text/plain; charset="utf-8" Content-ID: <7B4D11D2F5796F4F9E9ACE333C51585C@namprd15.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Return-Path: simon.marchi@ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00068.txt.bz2 T24gMjAxOC0wOS0yMyAxMjowOCBBTSwgVG9tIFRyb21leSB3cm90ZToNCj4g VGhpcyBzZXJpZXMgZW5hYmxlcyAtV3NoYWRvdz1sb2NhbCBmb3IgZ2RiLg0K PiANCj4gSSB0aGluayB0aGF0IHNoYWRvd2luZyBpcyBtaWxkbHkgY29uZnVz aW5nLCBhbmQgSSBub3JtYWxseSB0cnkgdG8NCj4gYXZvaWQgaXQuICBIb3dl dmVyLCBmb3IgYSBsb25nIHRpbWUsIGl0IHdhc24ndCBmZWFzaWJsZSB0byBl bmFibGUgYW55DQo+IHNoYWRvd2luZyB3YXJuaW5ncywgYmVjYXVzZSBnY2Mg d291bGQgd2FybiBhYm91dCBzaGFkb3dpbmcgdGhhdCB3YXMNCj4gInVuaW50 ZXJlc3RpbmciIC0tIHRoZSBjbGFzc2ljIGV4YW1wbGUgYmVpbmcgdGhlIHVz ZSBvZiBhIGxvY2FsDQo+IHZhcmlhYmxlIG5hbWVkICJpbmRleCIuDQo+IA0K PiBJbiB0aGlzIHNlcmllcyBJIGNob3NlIHRvIHVzZSAtV3NoYWRvdz1sb2Nh bCwgdG8gZm9yYmlkIHNoYWRvd2luZw0KPiB3aXRoaW4gYSBmdW5jdGlvbi4g IC1Xc2hhZG93PWNvbXBhdGlibGUtbG9jYWwgaXMgYW5vdGhlciBjaG9pY2Us IGJ1dCBJDQo+IHRoaW5rIHRoYXQgdGhlIHN0YXRlZCBzZW1hbnRpY3M6DQo+ IA0KPiAgICAgSW4gQysrLCB0eXBlIGNvbXBhdGliaWxpdHkgaGVyZSBtZWFu cyB0aGUgdHlwZSBvZiB0aGUgc2hhZG93aW5nDQo+ICAgICB2YXJpYWJsZSBj YW4gYmUgY29udmVydGVkIHRvIHRoYXQgb2YgdGhlIHNoYWRvd2VkIHZhcmlh YmxlLg0KPiANCj4gLi4uIGlzIG1heWJlIGluc3VmZmljaWVudC4gIEZvciBl eGFtcGxlIGEgc2l0dWF0aW9uIHdoZXJlIHRoZSB0d28NCj4gZGlmZmVyZW50 IHR5cGVzIGFyZSBib3RoIGNvbnZlcnRpYmxlIHRvIGEgdGhpcmQgdHlwZSBj b3VsZCBiZSBlbm91Z2gNCj4gdG8gY2F1c2UgYSBidWcuICBUaGF0J3MgYSBi aXQgb2YgYSByZWFjaCBtYXliZSwgYnV0IGl0IHNlZW1lZCB0byBtZQ0KPiB0 aGF0IGl0J3Mgbm90IHN1Y2ggYSBiaWcgZGVhbCwgYW5kIGNlcnRhaW5seSBh bHdheXMgc2FmZXIsIHRvIGp1c3QNCj4gZGlzYWxsb3cgc2hhZG93aW5nIGVu dGlyZWx5Lg0KPiANCj4gQWRkaW5nIHRoaXMgd2FybmluZyBmb3VuZCBhIGZl dyBsYXRlbnQgYnVncyBpbiBnZGIuDQo+IA0KPiBSZWdyZXNzaW9uIHRlc3Rl ZCBieSB0aGUgYnVpbGRib3QuICBUaGFua3MsIFNlcmdpbywgZm9yIHlvdXIg d29yaw0KPiBydW5uaW5nIHRoaXMgLS0gaXQgaXMgYSBncmVhdCBzZXJ2aWNl Lg0KPiANCj4gTGV0IG1lIGtub3cgd2hhdCB5b3UgdGhpbmsuICBJIGZlZWwg dGhhdCBhIGNoYW5nZSBsaWtlIHRoaXMgc2hvdWxkDQo+IGludm9sdmUgc29t ZSBmZWVkYmFjay4NCg0KSSB0aGluayB0aGF0J3MgYSBnb29kIGlkZWEsIEkg dGhpbmsgdmFyaWFibGUgc2hhZG93aW5nIGlzIG1vcmUgbGlrZWx5DQpkb25l IGJ5IG1pc3Rha2UgdGhhbiBhbnl0aGluZyBlbHNlLg0KDQpTaW1vbg0KDQo= >From gdb-patches-return-151351-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Oct 03 16:01:47 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 75713 invoked by alias); 3 Oct 2018 16:01:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 75655 invoked by uid 89); 3 Oct 2018 16:01:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS autolearn=ham version=3.3.2 spammy=Hx-languages-length:735, examined, commonly, H*M:db4d X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Oct 2018 16:01:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1538582501; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=wy2tUIx9AwJByv8fLMxBmkfpaZYHCbk21dohU+vsvrs=; b=ebAhE6fdNOeahoxnaiuq89wFquVrIPj1WPOPegWcIzaysKzJ9QA1+afO7tUGn+nq GJ++OCx3N49/Cl3MWEcMSQIQ9DRHPxlWZKKvvAHiONuuZduqwTK4532c+hGZn9m8 jZKzGtmreoeX1LeVV0j5F63RMTniGdogsmxwi8r7dd0=; Received: from ESESSMB501.ericsson.se (Unknown_Domain [153.88.183.119]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id 7B.A4.05037.5E7E4BB5; Wed, 3 Oct 2018 18:01:41 +0200 (CEST) Received: from ESESSMB503.ericsson.se (153.88.183.164) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 3 Oct 2018 18:01:30 +0200 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB503.ericsson.se (153.88.183.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Wed, 3 Oct 2018 18:01:30 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wy2tUIx9AwJByv8fLMxBmkfpaZYHCbk21dohU+vsvrs=; b=PIPbvfedoxfdfXHsFAwz2fWWhe+By/T6YgXtVMalj35qoqOBAtBEfgT50amonewRbL3tV0JXXxOEWm89KNmT3OXR3ACwIakQ2ZgzKxCM3IBK/VZM0nP30hRTxa3VZzEKPYhD6F0kKP6/jCFoWInEpKLobTANNKjZKYLGrWd7a9Q= Received: from BYAPR15MB2390.namprd15.prod.outlook.com (52.135.198.30) by BYAPR15MB2277.namprd15.prod.outlook.com (52.135.197.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1185.25; Wed, 3 Oct 2018 16:01:27 +0000 Received: from BYAPR15MB2390.namprd15.prod.outlook.com ([fe80::619e:2dbd:180c:a2fb]) by BYAPR15MB2390.namprd15.prod.outlook.com ([fe80::619e:2dbd:180c:a2fb%4]) with mapi id 15.20.1185.024; Wed, 3 Oct 2018 16:01:27 +0000 From: Simon Marchi To: Tom Tromey , "gdb-patches@sourceware.org" Subject: Re: [PATCH 1/8] Simple -Wshadow=local fixes Date: Wed, 03 Oct 2018 16:01:00 -0000 Message-ID: <30a68353-a5ed-db4d-0bb2-2e6f52cd16b7@ericsson.com> References: <20180923040814.27941-1-tom@tromey.com> <20180923040814.27941-2-tom@tromey.com> In-Reply-To: <20180923040814.27941-2-tom@tromey.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 Return-Path: simon.marchi@ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00069.txt.bz2 Content-length: 968 T24gMjAxOC0wOS0yMyAxMjowOCBBTSwgVG9tIFRyb21leSB3cm90ZToNCj4g VGhpcyBmaXhlcyBhbGwgdGhlIHN0cmFpZ2h0Zm9yd2FyZCAtV3NoYWRvdz1s b2NhbCB3YXJuaW5ncyBpbiBnZGIuICBBDQo+IGZldyBzdGFuZGFyZCBhcHBy b2FjaGVzIGFyZSB1c2VkIGhlcmU6DQo+IA0KPiAqIFJlbmFtaW5nIGFuIGlu bmVyIChvciBvdXRlciwgYnV0IG1vcmUgY29tbW9ubHkgaW5uZXIpIHZhcmlh YmxlOw0KPiAqIExvd2VyaW5nIGEgZGVjbGFyYXRpb24gdG8gYXZvaWQgYSBj bGFzaDsNCj4gKiBNb3ZpbmcgYSBkZWNsYXJhdGlvbiBpbnRvIGEgbW9yZSBp bm5lciBzY29wZSB0byBhdm9pZCBhIGNsYXNoLA0KPiAgIGluY2x1ZGluZyB0 aGUgc3BlY2lhbCBjYXNlIG9mIG1vdmluZyBhIGRlY2xhcmF0aW9uIGludG8g YSBsb29wIGhlYWRlci4NCj4gDQo+IEkgZGlkIG5vdCBjb25zaWRlciBhbnkg b2YgdGhlIGNoYW5nZXMgaW4gdGhpcyBwYXRjaCB0byBiZSBwYXJ0aWN1bGFy bHkNCj4gbm90ZXdvcnRoeSwgdGhvdWdoIG9mIGNvdXJzZSB0aGV5IHNob3Vs ZCBhbGwgc3RpbGwgYmUgZXhhbWluZWQuDQoNClRoaXMgTEdUTSwgYWx0aG91 Z2ggaWYgdGhlcmUgd2FzIHNvbWUgc3VidGxlIGJ1ZywgbGlrZSBtaXNzaW5n IHVwZGF0aW5nIG9uZQ0KdmFyaWFibGUgcmVmZXJlbmNlIHNvbWV3aGVyZSwg SSB3b3VsZCBwcm9iYWJseSBtaXNzIGl0Lg0KDQpTaW1vbg0KDQo= >From gdb-patches-return-151352-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Oct 03 16:12:12 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 56038 invoked by alias); 3 Oct 2018 16:12:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 56008 invoked by uid 89); 3 Oct 2018 16:12:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS autolearn=ham version=3.3.2 spammy=Hx-languages-length:342 X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Oct 2018 16:12:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1538583127; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=sdSzXxYs0U8vCk7XTmHqOOZdcSFqg3Vsz4cA0jiAh2w=; b=JC+jF2+RV2TPJK/TfTtIa+mZ3N2xB3f75oU6okAuT8nW3VEqLrALiSokH0p/xmkb gA9oFjmZRSWUdPyDpc4wDDxgSH27DXR6MSONf+wB7G4XBa3QyPHJ2in7EIB1XjD9 16d3g75iK6Jqgl+Bad0qIfhRsaItdpY9Ux0E2eDjEB4=; Received: from ESESSMB504.ericsson.se (Unknown_Domain [153.88.183.122]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 2C.27.22015.75AE4BB5; Wed, 3 Oct 2018 18:12:07 +0200 (CEST) Received: from ESESBMR504.ericsson.se (153.88.183.139) by ESESSMB504.ericsson.se (153.88.183.192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 3 Oct 2018 18:12:07 +0200 Received: from ESESBMB502.ericsson.se (153.88.183.169) by ESESBMR504.ericsson.se (153.88.183.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 3 Oct 2018 18:12:07 +0200 Received: from NAM01-BY2-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB502.ericsson.se (153.88.183.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Wed, 3 Oct 2018 18:12:06 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sdSzXxYs0U8vCk7XTmHqOOZdcSFqg3Vsz4cA0jiAh2w=; b=Msa2DJOR9Mvufzx42JOiwVNwuFvLZ9YQul6rlqbR31Ma5GdjeXaVVIYDIzgDPVY3CsUt6ApGPbSAz2z/fsw88EG1hoaxKdp816QA9G2V0OGWWRzcUCOAXdLphvBmUGV6av66eL9ElF8cFw9Uc2EOleb/6xgFmwdppKAh1zHxk5s= Received: from BYAPR15MB2390.namprd15.prod.outlook.com (52.135.198.30) by BYAPR15MB2424.namprd15.prod.outlook.com (52.135.198.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1207.20; Wed, 3 Oct 2018 16:12:04 +0000 Received: from BYAPR15MB2390.namprd15.prod.outlook.com ([fe80::619e:2dbd:180c:a2fb]) by BYAPR15MB2390.namprd15.prod.outlook.com ([fe80::619e:2dbd:180c:a2fb%4]) with mapi id 15.20.1185.024; Wed, 3 Oct 2018 16:12:04 +0000 From: Simon Marchi To: Tom Tromey , "gdb-patches@sourceware.org" Subject: Re: [PATCH 7/8] Shadowing fix in gdbscm_frame_read_var Date: Wed, 03 Oct 2018 16:12:00 -0000 Message-ID: <6d098a36-c483-77b8-61a6-87768c29f5d5@ericsson.com> References: <20180923040814.27941-1-tom@tromey.com> <20180923040814.27941-8-tom@tromey.com> In-Reply-To: <20180923040814.27941-8-tom@tromey.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) Content-Type: text/plain; charset="utf-8" Content-ID: <15A1DB2924D42145BF4CDB965E293F59@namprd15.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Return-Path: simon.marchi@ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00070.txt.bz2 Content-length: 403 T24gMjAxOC0wOS0yMyAxMjowOCBBTSwgVG9tIFRyb21leSB3cm90ZToNCj4g LVdzaGFkb3c9bG9jYWwgcG9pbnRlZCBvdXQgdGhhdCB0aGUgc2hhZG93aW5n IGluIGdkYnNjbV9mcmFtZV9yZWFkX3Zhcg0KPiBtZWFucyB0aGF0IHRoZSB1 bHRpbWF0ZSBjYWxsIHRvIHJlYWRfdmFyX3ZhbHVlIHdpbGwgYWx3YXlzIGJl IHBhc3NlZA0KPiBibG9jaz09TlVMTC4gIFRoZSBmaXggaXMgdG8gcmVtb3Zl IHRoZSBvdXRlciBkZWNsYXJhdGlvbi4NCg0Kcy9vdXRlci9pbm5lci8gPw0K DQpUaGUgY29kZSBMR1RNLg0KDQpTaW1vbg0K >From gdb-patches-return-151353-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Oct 03 16:16:02 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 69500 invoked by alias); 3 Oct 2018 16:16:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 69115 invoked by uid 89); 3 Oct 2018 16:15:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,MIME_BASE64_BLANKS,SPF_PASS,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.2 spammy= X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Oct 2018 16:15:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1538583325; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=f/nx2kqMPhuQ8EpHzd4rwd2Hjuk6UTgKufSKTLnhgKs=; b=P93bHOP7d3VWPK0hQ8m9bDG1yNrgEg5RBwQlb4NoyqzxrdxQLmrct1Y+WpSgAdg9 ohAEYMaKPlSgb66+vXQsyr2+OIXJKFXBKGtYVJI/sAfcNOrhxqhWOkPlfkaN1SG7 KRcSvIIzsgthugza90w9zKpnH9wZIzXy9EB2Yj2VqfE=; Received: from ESESSMB504.ericsson.se (Unknown_Domain [153.88.183.122]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 1A.E7.22015.D1BE4BB5; Wed, 3 Oct 2018 18:15:25 +0200 (CEST) Received: from ESESSMR505.ericsson.se (153.88.183.127) by ESESSMB504.ericsson.se (153.88.183.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 3 Oct 2018 18:15:25 +0200 Received: from ESESSMB504.ericsson.se (153.88.183.165) by ESESSMR505.ericsson.se (153.88.183.127) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 3 Oct 2018 18:15:25 +0200 Received: from NAM01-BN3-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB504.ericsson.se (153.88.183.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Wed, 3 Oct 2018 18:15:24 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f/nx2kqMPhuQ8EpHzd4rwd2Hjuk6UTgKufSKTLnhgKs=; b=PKoea9CC3FwYlRLk2oWDx4BwD2baoyEYAwPXEBA0IW2FStv12OFGvd5JgmhyjgcMJ38xYV9ES6AEwRS4jiHo2QP87BbYi+L7va2xGNtbKrmhMJAno8SQkXtSqhzLcOJj9/iTtTSTW2naDwLPA5GxDAtf5SFThDLB2/qebIJJRAE= Received: from BYAPR15MB2390.namprd15.prod.outlook.com (52.135.198.30) by BYAPR15MB2294.namprd15.prod.outlook.com (52.135.197.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1164.25; Wed, 3 Oct 2018 16:15:21 +0000 Received: from BYAPR15MB2390.namprd15.prod.outlook.com ([fe80::619e:2dbd:180c:a2fb]) by BYAPR15MB2390.namprd15.prod.outlook.com ([fe80::619e:2dbd:180c:a2fb%4]) with mapi id 15.20.1185.024; Wed, 3 Oct 2018 16:15:21 +0000 From: Simon Marchi To: Tom Tromey , "gdb-patches@sourceware.org" Subject: Re: [PATCH 0/8] Add -Wshadow=local Date: Wed, 03 Oct 2018 16:16:00 -0000 Message-ID: References: <20180923040814.27941-1-tom@tromey.com> <29c17639-6ee6-b089-be95-227f98ac0ccf@ericsson.com> In-Reply-To: <29c17639-6ee6-b089-be95-227f98ac0ccf@ericsson.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 Return-Path: simon.marchi@ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00071.txt.bz2 Content-length: 2453 T24gMjAxOC0xMC0wMyAxMTowMSBBTSwgU2ltb24gTWFyY2hpIHdyb3RlOg0K PiBPbiAyMDE4LTA5LTIzIDEyOjA4IEFNLCBUb20gVHJvbWV5IHdyb3RlOg0K Pj4gVGhpcyBzZXJpZXMgZW5hYmxlcyAtV3NoYWRvdz1sb2NhbCBmb3IgZ2Ri Lg0KPj4NCj4+IEkgdGhpbmsgdGhhdCBzaGFkb3dpbmcgaXMgbWlsZGx5IGNv bmZ1c2luZywgYW5kIEkgbm9ybWFsbHkgdHJ5IHRvDQo+PiBhdm9pZCBpdC4g IEhvd2V2ZXIsIGZvciBhIGxvbmcgdGltZSwgaXQgd2Fzbid0IGZlYXNpYmxl IHRvIGVuYWJsZSBhbnkNCj4+IHNoYWRvd2luZyB3YXJuaW5ncywgYmVjYXVz ZSBnY2Mgd291bGQgd2FybiBhYm91dCBzaGFkb3dpbmcgdGhhdCB3YXMNCj4+ ICJ1bmludGVyZXN0aW5nIiAtLSB0aGUgY2xhc3NpYyBleGFtcGxlIGJlaW5n IHRoZSB1c2Ugb2YgYSBsb2NhbA0KPj4gdmFyaWFibGUgbmFtZWQgImluZGV4 Ii4NCj4+DQo+PiBJbiB0aGlzIHNlcmllcyBJIGNob3NlIHRvIHVzZSAtV3No YWRvdz1sb2NhbCwgdG8gZm9yYmlkIHNoYWRvd2luZw0KPj4gd2l0aGluIGEg ZnVuY3Rpb24uICAtV3NoYWRvdz1jb21wYXRpYmxlLWxvY2FsIGlzIGFub3Ro ZXIgY2hvaWNlLCBidXQgSQ0KPj4gdGhpbmsgdGhhdCB0aGUgc3RhdGVkIHNl bWFudGljczoNCj4+DQo+PiAgICAgSW4gQysrLCB0eXBlIGNvbXBhdGliaWxp dHkgaGVyZSBtZWFucyB0aGUgdHlwZSBvZiB0aGUgc2hhZG93aW5nDQo+PiAg ICAgdmFyaWFibGUgY2FuIGJlIGNvbnZlcnRlZCB0byB0aGF0IG9mIHRoZSBz aGFkb3dlZCB2YXJpYWJsZS4NCj4+DQo+PiAuLi4gaXMgbWF5YmUgaW5zdWZm aWNpZW50LiAgRm9yIGV4YW1wbGUgYSBzaXR1YXRpb24gd2hlcmUgdGhlIHR3 bw0KPj4gZGlmZmVyZW50IHR5cGVzIGFyZSBib3RoIGNvbnZlcnRpYmxlIHRv IGEgdGhpcmQgdHlwZSBjb3VsZCBiZSBlbm91Z2gNCj4+IHRvIGNhdXNlIGEg YnVnLiAgVGhhdCdzIGEgYml0IG9mIGEgcmVhY2ggbWF5YmUsIGJ1dCBpdCBz ZWVtZWQgdG8gbWUNCj4+IHRoYXQgaXQncyBub3Qgc3VjaCBhIGJpZyBkZWFs LCBhbmQgY2VydGFpbmx5IGFsd2F5cyBzYWZlciwgdG8ganVzdA0KPj4gZGlz YWxsb3cgc2hhZG93aW5nIGVudGlyZWx5Lg0KPj4NCj4+IEFkZGluZyB0aGlz IHdhcm5pbmcgZm91bmQgYSBmZXcgbGF0ZW50IGJ1Z3MgaW4gZ2RiLg0KPj4N Cj4+IFJlZ3Jlc3Npb24gdGVzdGVkIGJ5IHRoZSBidWlsZGJvdC4gIFRoYW5r cywgU2VyZ2lvLCBmb3IgeW91ciB3b3JrDQo+PiBydW5uaW5nIHRoaXMgLS0g aXQgaXMgYSBncmVhdCBzZXJ2aWNlLg0KPj4NCj4+IExldCBtZSBrbm93IHdo YXQgeW91IHRoaW5rLiAgSSBmZWVsIHRoYXQgYSBjaGFuZ2UgbGlrZSB0aGlz IHNob3VsZA0KPj4gaW52b2x2ZSBzb21lIGZlZWRiYWNrLg0KPiANCj4gSSB0 aGluayB0aGF0J3MgYSBnb29kIGlkZWEsIEkgdGhpbmsgdmFyaWFibGUgc2hh ZG93aW5nIGlzIG1vcmUgbGlrZWx5DQo+IGRvbmUgYnkgbWlzdGFrZSB0aGFu IGFueXRoaW5nIGVsc2UuDQo+IA0KPiBTaW1vbg0KPiANCg0KSSBsb29rZWQg YXQgdGhlIGNvZGUsIGl0IGFsbCBMR1RNLiAgQXMgSSBzYWlkIGluIG15IG90 aGVyIG1lc3NhZ2UsIEkgdGhpbmsNCml0IHdvdWxkIGJlIGVhc3kgdG8gbWlz cyBzdWJ0bGUgbWlzdGFrZXMgd2hlbiByZXZpZXdpbmcsIGdpdmVuIHRoZSBy ZXBldGl0aXZlDQpuYXR1cmUgb2YgdGhlIHBhdGNoLCBidXQgSSBkb24ndCBy ZWFsbHkgc2VlIGEgYmV0dGVyL3NhZmVyIGFwcHJvYWNoIHRvIGRvIHRoZQ0K Y2hhbmdlLiAgSSB0aGluayBpdCB3aWxsIGJlIGEgbmV0IHBvc2l0aXZlLg0K DQpTaW1vbg0K >From gdb-patches-return-151354-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Oct 03 16:34:39 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 38558 invoked by alias); 3 Oct 2018 16:34:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 38544 invoked by uid 89); 3 Oct 2018 16:34:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:586 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Oct 2018 16:34:37 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8FE503082A22; Wed, 3 Oct 2018 16:34:36 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id B48EA87C1; Wed, 3 Oct 2018 16:34:35 +0000 (UTC) Subject: Re: [PATCH 0/8] Add -Wshadow=local To: Simon Marchi , Tom Tromey , "gdb-patches@sourceware.org" References: <20180923040814.27941-1-tom@tromey.com> <29c17639-6ee6-b089-be95-227f98ac0ccf@ericsson.com> From: Pedro Alves Message-ID: <04748d1d-0fe6-76ad-31f1-68657f8e0d56@redhat.com> Date: Wed, 03 Oct 2018 16:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-10/txt/msg00072.txt.bz2 Content-length: 554 On 10/03/2018 05:15 PM, Simon Marchi wrote: > I looked at the code, it all LGTM. As I said in my other message, I think > it would be easy to miss subtle mistakes when reviewing, given the repetitive > nature of the patch, but I don't really see a better/safer approach to do the > change. I think it will be a net positive. I agree. If this causes bugs not caught by the testsuite, I guess you could say that the problem is that we're missing some tests. I quickly skimmed the patches and it all looked reasonable to me too. Thanks, Pedro Alves