From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7108 invoked by alias); 30 Oct 2008 21:53:37 -0000 Received: (qmail 6837 invoked by uid 22791); 30 Oct 2008 21:53:35 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 30 Oct 2008 21:51:25 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id C57BA13428; Thu, 30 Oct 2008 08:55:53 -0700 (PDT) Received: from pa-excaht03.vmware.com (pa-excaht03.vmware.com [10.113.81.154]) by mailhost3.vmware.com (Postfix) with ESMTP id AD31BC9A36; Thu, 30 Oct 2008 08:55:53 -0700 (PDT) Received: from pa-excaht12.vmware.com (10.113.81.205) by pa-excaht03.vmware.com (10.113.81.154) with Microsoft SMTP Server (TLS) id 8.1.263.0; Thu, 30 Oct 2008 08:55:53 -0700 Received: from PA-EXMBX14.vmware.com ([10.113.81.216]) by pa-excaht12.vmware.com ([10.113.81.205]) with mapi; Thu, 30 Oct 2008 08:55:53 -0700 From: Michael Snyder To: Pedro Alves , "gdb-patches@sourceware.org" CC: teawater Date: Thu, 30 Oct 2008 22:06:00 -0000 Subject: RE: [reverse/record] adjust_pc_after_break in reverse execution mode? Message-ID: <29E9E827072C404C88A05DDC42B4599717BBECC4E1@PA-EXMBX14.vmware.com> References: <200810180210.16346.pedro@codesourcery.com> <49079788.6000702@vmware.com>,<200810301107.23536.pedro@codesourcery.com> In-Reply-To: <200810301107.23536.pedro@codesourcery.com> Accept-Language: en-US Content-Language: en-US acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00714.txt.bz2 Pedro, yes, but I can no longer get it to exhibit that behavior. Can you? Remember, there've been changes since then. ________________________________________ From: Pedro Alves [pedro@codesourcery.com] Sent: Thursday, October 30, 2008 4:07 AM To: gdb-patches@sourceware.org Cc: Michael Snyder; teawater Subject: Re: [reverse/record] adjust_pc_after_break in reverse execution mo= de? On Tuesday 28 October 2008 22:51:52, Michael Snyder wrote: > Well, before I can evaluate the patch, I need a test case > to see what behavior it is fixing. Doesn't have to be a > formal DEJAGNU script, just something like the printf example > that you posted for the other bug. > > Right now, I am unable to get the reverse-20080930-branch > to exhibit any bad behavior that I could attribute to this > issue. It seems to work just fine... Wouldn't that be the extended nop+goto example I posted? http://sourceware.org/ml/gdb-patches/2008-10/msg00599.html Hui, I'm now lost in this huge thread that never seems to end, but I think that the last patch I saw, you still missed that you should check for software_breakpoint_inserted_here_p before doing the adjustment (see adjust_pc_after_break) --- it was there in the first patch I posted to address this issue. This decr after break business sucks. For remote targets implementing software breakpoints, it would probably be best if we had a remote protocol feature with a corresponding property for this at the target_ops level that overrides the gdbarch setting. There are probably many targets out there implementing Z0 breakpoints that do the adjustment themselves. It's just that it's not common to trip on it, so it gets by. -- Pedro Alves