From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WNLFI9oj2GNHkyUAWB0awg (envelope-from ) for ; Mon, 30 Jan 2023 15:08:58 -0500 Received: by simark.ca (Postfix, from userid 112) id 8EDB41E128; Mon, 30 Jan 2023 15:08:58 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=GB1G3kfc; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 453931E112 for ; Mon, 30 Jan 2023 15:08:58 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CECA33858C5F for ; Mon, 30 Jan 2023 20:08:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CECA33858C5F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1675109337; bh=Oxx0fZybzPoYuIOsEKM5lbwBQJihX4GTES5FNjqYrl4=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=GB1G3kfcd03yG0N+ZViyXx3EN06NiE0Xuw8IZm8//bnp/mJY8eyAMIO364iy56Yew +OdiJwBHnShcoamkbj9TM/CoiIK2TwYJWdVKWtPW7mkJIy6q42uZnDVupdwjpOwdfi 8A/XzyjllX60LgaOfAMA0qpXb9y90AGhclwtkZI8= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id F32733858C2F for ; Mon, 30 Jan 2023 20:08:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F32733858C2F Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 30UK8VaO008240 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Jan 2023 15:08:36 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 30UK8VaO008240 Received: from [172.16.0.192] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B49CD1E112; Mon, 30 Jan 2023 15:08:31 -0500 (EST) Message-ID: <298ffaf1-6d15-5ee1-b730-19c6adf99a1a@polymtl.ca> Date: Mon, 30 Jan 2023 15:08:30 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2] gdb/dwarf: dump cooked index contents in cooked_index_functions::dump Content-Language: fr To: Tom Tromey , Simon Marchi via Gdb-patches Cc: Simon Marchi References: <20230130160337.55890-1-simon.marchi@efficios.com> <875ycnon8i.fsf@tromey.com> In-Reply-To: <875ycnon8i.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 30 Jan 2023 20:08:31 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 1/30/23 14:07, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> From: Simon Marchi > Simon> New in v2: > > Simon> - move the implementation to the cooked_index_vector class > Simon> - use the gdbarch from the objfile > Simon> - add some QUIT macro calls > Simon> - add call to wait, to ensure the index is finished > > Thanks, this looks good to me. > > I don't really know which trailer to use but -- > > Approved-By: Tom Tromey Gah, I forgot applying the trailer before pushing, sorry about that. Simon