From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aCVxKWnsSWfdgAQAWB0awg (envelope-from ) for ; Fri, 29 Nov 2024 11:31:37 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=aA4hVDBy; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Bfl30PAL; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=aA4hVDBy; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Bfl30PAL; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A58511E097; Fri, 29 Nov 2024 11:31:37 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C840F1E05C for ; Fri, 29 Nov 2024 11:31:36 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 63E7A3858CDA for ; Fri, 29 Nov 2024 16:31:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 63E7A3858CDA Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=aA4hVDBy; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Bfl30PAL; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=aA4hVDBy; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Bfl30PAL Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 6BCD83858D26 for ; Fri, 29 Nov 2024 16:30:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6BCD83858D26 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6BCD83858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732897855; cv=none; b=MVHKFqzPyjy2DHK0RqFLNWqdYq43MPiN15qWYOC84s0rgmERkXjaZhXwn+CQNeXvfCKtd+cKTWyqV7Zx7PlnggepOlLg/cM6IJ1kdOzvpI0GitxBuQz4Np948vd6w9q2uob6EyD7I/0+9BYW4wo3v9ZaVb988sxOSBpOtQfFG1M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732897855; c=relaxed/simple; bh=i7yws/4tBUEMpa8bxsyK4PeMq4txLJST9sjQJQpr1F0=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=J51YxprbIXVxuijdlcR109Yop2LXop3brRehCl4w1UeYFXUUAvNhSJnmIwhIimRDLX3b9s+rl85kscZeBKRTUI3ktjasXPAD7Hz4tbsTQZaNgtMLf0/9OCyOqabpLvRBrekYl9O9Cmj7N+Kgo9P1BlOhEvVY6tZvJ8OndIWPfzw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6BCD83858D26 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 46DF221190; Fri, 29 Nov 2024 16:30:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1732897854; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wmLptsQtQ5SSIMeO16a2VgY87youbnsJdXxWOIwjQDk=; b=aA4hVDByp3ipBNWHTjDC2u/QzlIy2i7/CfuZd3Z0O8YaFPftpR5IDsQQVO/KfER1Gv4hnE Kz8CAZckqbRP+kt7af2P0GcPHCH7AUZ5mWwTZMi26oXsXK8QLHHtCHTF6OxlMoFbps2hay 0UAzfkWfodnSa3/P4z3Z8QC9kh6GaSE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1732897854; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wmLptsQtQ5SSIMeO16a2VgY87youbnsJdXxWOIwjQDk=; b=Bfl30PAL69da06uohweXUM4s1YH5WGK6H6oufMwK8X61rOh++HiuR81RSEW2+5QfLd6ATy VCyz7AsWLqR/ZIDg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=aA4hVDBy; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Bfl30PAL DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1732897854; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wmLptsQtQ5SSIMeO16a2VgY87youbnsJdXxWOIwjQDk=; b=aA4hVDByp3ipBNWHTjDC2u/QzlIy2i7/CfuZd3Z0O8YaFPftpR5IDsQQVO/KfER1Gv4hnE Kz8CAZckqbRP+kt7af2P0GcPHCH7AUZ5mWwTZMi26oXsXK8QLHHtCHTF6OxlMoFbps2hay 0UAzfkWfodnSa3/P4z3Z8QC9kh6GaSE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1732897854; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wmLptsQtQ5SSIMeO16a2VgY87youbnsJdXxWOIwjQDk=; b=Bfl30PAL69da06uohweXUM4s1YH5WGK6H6oufMwK8X61rOh++HiuR81RSEW2+5QfLd6ATy VCyz7AsWLqR/ZIDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 29140133F3; Fri, 29 Nov 2024 16:30:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id gchxCD7sSWdRWwAAD6G6ig (envelope-from ); Fri, 29 Nov 2024 16:30:54 +0000 Message-ID: <2958b8ef-32e0-421a-9016-523332d986f4@suse.de> Date: Fri, 29 Nov 2024 17:32:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] [gdbsupport] Add gdb::{waitpid,read,write,close} To: Simon Marchi , Tom Tromey Cc: gdb-patches@sourceware.org References: <20241028174913.27056-1-tdevries@suse.de> <87y122501s.fsf@tromey.com> <9b20eea0-0f14-47d9-ad7f-39e197d2e521@suse.de> <70b41955-4a06-47db-a467-ef8f24ca030a@suse.de> <2a0ca637-82c7-4194-9b5e-6ce6802e3415@suse.de> <2ca59a8a-6d37-4338-83a5-ce613f8d2663@simark.ca> Content-Language: en-US From: Tom de Vries In-Reply-To: <2ca59a8a-6d37-4338-83a5-ce613f8d2663@simark.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 46DF221190 X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCPT_COUNT_THREE(0.00)[3]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:dkim,suse.de:mid,opensuse.org:url]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 11/29/24 17:27, Simon Marchi wrote: > > > On 2024-11-29 11:23, Tom de Vries wrote: >> On 11/29/24 17:15, Simon Marchi wrote: >>> >>> >>> On 2024-11-22 11:46, Tom de Vries wrote: >>>> On 11/5/24 13:07, Tom de Vries wrote: >>>>> On 11/1/24 18:35, Tom Tromey wrote: >>>>>>>>>>> "Tom" == Tom de Vries writes: >>>>>> >>>>>> Tom> +namespace gdb { >>>>>> Tom> + >>>>>> Tom> +extern "C" { >>>>>> >>>>>> I didn't even know this was valid ... but is it really needed? >>>>>> It seems wrong. >>>>>> >>>>> >>>>> It seemed to work: >>>>> ... >>>>> $ cat test.c >>>>> namespace gdb { >>>>> >>>>> extern "C" { >>>>> int foo (void) { return 1; }; >>>>> } >>>>> } >>>>> >>>>> $ cat test2.c >>>>> namespace gdb { >>>>> extern "C" { >>>>> int foo (void); >>>>> } >>>>> } >>>>> >>>>> int >>>>> main (void) >>>>> { >>>>> return gdb::foo (); >>>>> } >>>>> $ g++ test.c test2.c >>>>> ... >>>>> but the linkage symbol is plain foo: >>>>> ... >>>>> $ nm ./a.out | grep foo >>>>> 00000000004004c7 T foo >>>>> ... >>>>> >>>>> So, you're right, this is wrong. >>>>> >>>>> I seem to have ended up with gdb_waitpid instead of gdb::waitpid in v2, similar to gdb_select, but thinking about it now I slightly prefer gdb::waitpid. I suppose it doesn't matter that much. >>>>> >>>> >>>> When looking at this again today, it bugged me enough rewrite v2 in the gdb::waitpid style. Committed after retesting. >>> >>> When building for mingw-w64, I see this, which seems related: >>> >>> CXX cli/cli-cmds.o >>> In file included from /home/simark/src/binutils-gdb/gdb/cli/cli-cmds.c:58: >>> /home/simark/src/binutils-gdb/gdb/../gdbsupport/eintr.h: In function ‘pid_t gdb::waitpid(pid_t, int*, int)’: >>> /home/simark/src/binutils-gdb/gdb/../gdbsupport/eintr.h:77:35: error: ‘::waitpid’ has not been declared; did you mean ‘gdb::waitpid’? >>> 77 | return gdb::handle_eintr (-1, ::waitpid, pid, wstatus, options); >>> | ^~~~~~~ >>> | gdb::waitpid >>> /home/simark/src/binutils-gdb/gdb/../gdbsupport/eintr.h:75:1: note: ‘gdb::waitpid’ declared here >>> 75 | waitpid (pid_t pid, int *wstatus, int options) >>> | ^~~~~~~ >>> >>> Note that to get to it, you have to step past this other build error in >>> gdbserver (by doing `make all-gdb` for instance): >>> >>> https://inbox.sourceware.org/gdb-patches/75926446-4c8a-40ee-8ed8-ab55f38e1520@simark.ca/T/#m194744b18419e37dfb4ec82c8e0ce73fb017ba17 >> >> Hi Simon, >> >> thanks for reporting this. >> >> I don't have a windows setup unfortunately, so I have no way of reproducing this, and at this point I have no idea why waitpid is not declared. > > For just build testing, I cross-compile with a mingw-w64 cross compiler, > which is available on most distros, looks like it is on Suse: > > https://en.opensuse.org/MinGW > > The problem is that you might have to cross build the packages gdb > requires. If you're lucky, your distro also packages them for > mingw-w64. For instance, it looks like Suse packages libgmp: > > https://software.opensuse.org/package/mingw64-gmp?locale=ro > > These are the configure flags I currently use for this build: > > '--host=x86_64-w64-mingw32' \ > 'CFLAGS=-g3 -O0' \ > 'CC=ccache x86_64-w64-mingw32-gcc' \ > 'CXXFLAGS=-g3 -O0 -fmax-errors=1' \ > 'CXX=ccache x86_64-w64-mingw32-g++' \ > '--disable-source-highlight' \ > '--disable-gold' \ > '--disable-ld' \ > '--disable-binutils' \ > '--disable-gprof' \ > '--disable-gas' \ > '--without-python' \ > '--disable-nls' > > I'll try to get it to build inside a Suse container. > Oh, I see, that's a good idea, thanks, I'll try that. - Tom