From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8292 invoked by alias); 5 Dec 2001 17:47:58 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8220 invoked from network); 5 Dec 2001 17:47:52 -0000 Received: from unknown (HELO thor.inter.net.il) (192.114.186.11) by sources.redhat.com with SMTP; 5 Dec 2001 17:47:52 -0000 Received: from zaretsky ([192.116.55.139]) by thor.inter.net.il (Mirapoint) with ESMTP id ACP69847; Wed, 5 Dec 2001 19:47:40 +0200 (IST) Date: Wed, 05 Dec 2001 09:47:00 -0000 From: "Eli Zaretskii" To: muller@cerbere.u-strasbg.fr Message-Id: <2950-Wed05Dec2001194620+0200-eliz@is.elta.co.il> X-Mailer: emacs 21.1.50 (via feedmail 8 I) and Blat ver 1.8.9 CC: gdb-patches@sources.redhat.com In-reply-to: <4.2.0.58.20011205154816.01412080@ics.u-strasbg.fr> (message from Pierre Muller on Wed, 05 Dec 2001 15:49:52 +0100) Subject: Re: [RFA] get go32 target to compile again. Reply-to: Eli Zaretskii References: <3C0CFC7C.4030205@cygnus.com> <4.2.0.58.20011204161305.014f35e0@ics.u-strasbg.fr> <3C0CFC7C.4030205@cygnus.com> <4.2.0.58.20011205154816.01412080@ics.u-strasbg.fr> X-SW-Source: 2001-12/txt/msg00140.txt.bz2 > Date: Wed, 05 Dec 2001 15:49:52 +0100 > From: Pierre Muller > > > > > > Oops. Eli's approval, but thanks! > > > >I didn't approve the original patch, and I don't think I needed to. > > But you are the go32 target maintainer, > so you should always approve or refuse > patches that concerns go32. With the exception of the obvious ones. Andrew checked in this change as an obvious. And since I knew that Andrew builds GDB after each change for several targets, including DJGPP, I didn't see any reason to demand that I approve the change. Your change is even more obvious than Andrew's, since it fixes a problem that prevents compilation.