From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28056 invoked by alias); 4 Sep 2003 17:04:05 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28048 invoked from network); 4 Sep 2003 17:04:04 -0000 Received: from unknown (HELO aragorn.inter.net.il) (192.114.186.23) by sources.redhat.com with SMTP; 4 Sep 2003 17:04:04 -0000 Received: from zaretski (pns03-196-195.inter.net.il [80.230.196.195]) by aragorn.inter.net.il (Mirapoint Messaging Server MOS 3.3.5-GR) with ESMTP id BJG27075; Thu, 4 Sep 2003 19:54:30 +0300 (IDT) Date: Thu, 04 Sep 2003 17:04:00 -0000 From: "Eli Zaretskii" To: Corinna Vinschen Message-Id: <2950-Thu04Sep2003195339+0300-eliz@elta.co.il> CC: gdb-patches@sources.redhat.com In-reply-to: <20030903111828.GT1859@cygbert.vinschen.de> (message from Corinna Vinschen on Wed, 3 Sep 2003 13:18:28 +0200) Subject: Re: [RFA] breakpoint.c, scanning epilogue if frame chain is invalid Reply-to: Eli Zaretskii References: <20030903093815.GQ1859@cygbert.vinschen.de> <20030903111828.GT1859@cygbert.vinschen.de> X-SW-Source: 2003-09/txt/msg00037.txt.bz2 > Date: Wed, 3 Sep 2003 13:18:28 +0200 > From: Corinna Vinschen > > if (!within_current_scope || <== fr == NULL > fr == get_current_frame ()) <== or fr != NULL and > current frame == watchpoint frame > then call gdbarch_in_function_epilogue_p(current pc). > > So after the change gdbarch_in_function_epilogue_p() is also called if the > watchpoint frame couldn't be found because the frame chain is temporarily > broken. Since this is very likely occuring in an epilogue, it's pretty > naturally to call gdbarch_in_function_epilogue_p(). Thanks for the explanations, I think this patch is correct.