From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3535 invoked by alias); 28 Sep 2017 09:24:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2750 invoked by uid 89); 28 Sep 2017 09:23:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Sep 2017 09:23:58 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8201CC0D5A48; Thu, 28 Sep 2017 09:23:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8201CC0D5A48 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id D3FC317A60; Thu, 28 Sep 2017 09:23:56 +0000 (UTC) Subject: Re: [RFA 02/11] Remove cleanups from mi_cmd_break_insert_1 To: Tom Tromey , gdb-patches@sourceware.org References: <20170912185736.20436-1-tom@tromey.com> <20170912185736.20436-3-tom@tromey.com> From: Pedro Alves Message-ID: <294ad0fc-6500-2871-42c7-b0414dbdf563@redhat.com> Date: Thu, 28 Sep 2017 09:24:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170912185736.20436-3-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00852.txt.bz2 On 09/12/2017 07:57 PM, Tom Tromey wrote: > * target.h (make_scoped_defer_target_commit_resume): Update. > * target.c (make_scoped_defer_target_commit_resume): Rename from > make_cleanup_defer_target_commit_resume. Return a > diff --git a/gdb/mi/mi-cmd-break.c b/gdb/mi/mi-cmd-break.c > index bae8711..4cd134c 100644 > --- a/gdb/mi/mi-cmd-break.c > +++ b/gdb/mi/mi-cmd-break.c > @@ -86,12 +86,11 @@ setup_breakpoint_reporting (void) > /* Convert arguments in ARGV to the string in "format",argv,argv... > and return it. */ > > -static char * > +static std::string > mi_argv_to_format (char **argv, int argc) > { > int i; > - struct obstack obstack; > - char *ret; > + auto_obstack obstack; > > obstack_init (&obstack); Remove the obstack_init call too. > > @@ -152,10 +151,7 @@ mi_argv_to_format (char **argv, int argc) > } > obstack_1grow (&obstack, '\0'); > > - ret = xstrdup ((const char *) obstack_finish (&obstack)); > - obstack_free (&obstack, NULL); > - > - return ret; > + return (const char *) obstack_finish (&obstack); > } OK. IMO, it'd be even better to build the std::string directly instead of building an obstack and then dupping the string. Thanks, Pedro Alves