From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129292 invoked by alias); 18 Apr 2017 16:53:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129235 invoked by uid 89); 18 Apr 2017 16:53:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=stock X-HELO: mail.baldwin.cx Received: from bigwig.baldwin.cx (HELO mail.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Apr 2017 16:53:36 +0000 Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id 9532510A7DB; Tue, 18 Apr 2017 12:53:36 -0400 (EDT) From: John Baldwin To: gdb-patches@sourceware.org Cc: Simon Marchi , Luis Machado Subject: Re: [PATCH v2] PR threads/20743: Don't attempt to suspend or resume exited threads. Date: Tue, 18 Apr 2017 16:53:00 -0000 Message-ID: <2948452.rHjuhJKomY@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.0-STABLE; KDE/4.14.10; amd64; ; ) In-Reply-To: References: <20170404173258.6512-1-jhb@FreeBSD.org> <14140503.xzYTI4WuLb@ralph.baldwin.cx> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00514.txt.bz2 On Tuesday, April 18, 2017 10:27:51 AM Simon Marchi wrote: > On 2017-04-17 14:27, John Baldwin wrote: > > On Friday, April 14, 2017 08:01:25 PM Luis Machado wrote: > >> On 04/14/2017 05:40 PM, John Baldwin wrote: > >> >> Otherwise i have no further comments. I assume you ran gdb's testsuite > >> >> against this change and verified the results are sane? > >> > > >> > There were no regressions at least. With the stock tree there are > >> > several unexpected failures already which I will get to at some point. > >> > > >> > >> Great. I have no further comments. > > > > To be clear (since I believe I messed this up before), I still need > > approval > > from an approver? > > I read both the v1 and v2 threads to get the context, the patch looks > good to me. Pedro was fine with the ALL_NON_EXITED_THREADS approach as > well, so go ahead and push. I think it should go in the 8.0 branch as > well. Thanks, pushed to both. -- John Baldwin