From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22433 invoked by alias); 30 Oct 2017 00:16:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22417 invoked by uid 89); 30 Oct 2017 00:16:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Oct 2017 00:16:54 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v9U0GliL006920 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 29 Oct 2017 20:16:52 -0400 Received: by simark.ca (Postfix, from userid 112) id EE5AD1E533; Sun, 29 Oct 2017 20:16:45 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 23BD51E4C4; Sun, 29 Oct 2017 20:16:45 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 30 Oct 2017 00:16:00 -0000 From: Simon Marchi To: Pedro Alves Cc: Tom Tromey , Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] Introduce string_appendf/string_vappendf (Re: [RFA 4/6] Simple cleanup removals in remote.c) In-Reply-To: <6f25988500a233845974f3b99e47a8f9@polymtl.ca> References: <20171016030427.21349-1-tom@tromey.com> <20171016030427.21349-5-tom@tromey.com> <07804bc3-a6c5-2c0f-5730-5dd12fccafbe@ericsson.com> <87fuaipzgg.fsf@tromey.com> <97a40149-a30f-b2af-4441-6945b1d29cf1@redhat.com> <87vajesnor.fsf@tromey.com> <83461717578f600a349e7b308c840047@polymtl.ca> <6f25988500a233845974f3b99e47a8f9@polymtl.ca> Message-ID: <29353d541728ec98b62a1622dc3acb38@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 30 Oct 2017 00:16:47 +0000 X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00871.txt.bz2 On 2017-10-18 23:12, Simon Marchi wrote: > On 2017-10-18 23:11, Simon Marchi wrote: >>> + >>> +/* See documentation in common-utils.h. */ >>> + >>> +void >>> +string_appendf (std::string &str, const char *fmt, ...) >>> +{ >>> + va_list vp; >>> + int grow_size; >>> + >>> + va_start (vp, fmt); >>> + grow_size = vsnprintf (NULL, 0, fmt, vp); >>> + va_end (vp); >>> + >>> + size_t curr_size = str.size (); >>> + str.resize (curr_size + grow_size); >>> + >>> + /* C++11 and later guarantee std::string uses contiguous memory >>> and >>> + always includes the terminating '\0'. */ >>> + va_start (vp, fmt); >>> + vsprintf (&str[curr_size], fmt, vp); >>> + va_end (vp); >>> +} >>> + >>> + >>> +/* See documentation in common-utils.h. */ >>> + >>> +void >>> +string_vappendf (std::string &str, const char *fmt, va_list args) >>> +{ >>> + va_list vp; >>> + int grow_size; >>> + >>> + va_copy (vp, args); >>> + grow_size = vsnprintf (NULL, 0, fmt, vp); >>> + va_end (vp); >>> + >>> + size_t curr_size = str.size (); >>> + str.resize (curr_size + grow_size); >>> + >>> + /* C++11 and later guarantee std::string uses contiguous memory >>> and >>> + always includes the terminating '\0'. */ >>> + vsprintf (&str[curr_size], fmt, args); >>> +} >>> + >> >> string_appendf can be implemented using string_vappendf, to reduce >> duplication. It would basically be like string_vappendf_wrapper is. >> In the tests, we can probably just test string_appendf then. >> >> Unless there's a good reason for them not sharing code? > > Actually the same comment would apply to string_{v,}printf. > > Simon Hi Pedro, I came across a case where string_appendf would be useful, so I was wondering if you intended to push this patch. If you don't have the time, I would be happy to take care of it, just tell me if you agree with my comments and I'll make the changes & push. Simon