From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id tSG2F+3/mmqP8ygAWB0awg (envelope-from ) for ; Fri, 04 Sep 2026 13:29:17 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=palves.net header.i=@palves.net header.a=rsa-sha256 header.s=dreamhost header.b=Msib3Jsp; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3ECCF1E033; Fri, 04 Sep 2026 13:29:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C693E1E033 for ; Fri, 04 Sep 2026 13:29:15 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 431824B9DB67 for ; Fri, 4 Sep 2026 17:29:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 431824B9DB67 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=palves.net header.i=@palves.net header.a=rsa-sha256 header.s=dreamhost header.b=Msib3Jsp Received: from tiger.tulip.relay.mailchannels.net (tiger.tulip.relay.mailchannels.net [23.83.218.248]) by sourceware.org (Postfix) with ESMTPS id 100D94BB3B9A for ; Fri, 4 Sep 2026 17:28:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 100D94BB3B9A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=palves.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 100D94BB3B9A Authentication-Results: sourceware.org; arc=none smtp.remote-ip=23.83.218.248 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788542920; cv=none; b=fh43kPylJNQ7Yi8ep0ofKABydNXm0Lm2/DUwGHFIpHzpfkbYH/kPALN/GifLkSVlMZcCXrFW+RKZkKRH304xGc3VkHRb+hsZBlj5N6aAxdIz5jriX/iuzZPDc7oUVPqJ17x1PgrV91IXtkJqAOjHNbIWPECKmEezCKedFztGSXA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788542920; c=relaxed/simple; bh=/HT54GL1o5E8yqDzwfnE3bFKM7yNUGmdIeds5y0zy38=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=A6y8c+00X/o3XkLOgzC38PnkjFn34C40nREmKR0eOCXXxrTZ/DNOkZNfMOtC6yjhqsY1u5V2FDd9rAwL6ZMLvX836+R5hm8puMN30kP4JpBpiUarad7hdnAmkUxEN++Q23g1W8CN/D7Kzh9cCbjlKUIwrksC5CgrqXDGHez7FZo= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=palves.net header.i=@palves.net header.a=rsa-sha256 header.s=dreamhost header.b=Msib3Jsp DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 100D94BB3B9A X-Sender-Id: dreamhost|x-authsender|pedro@palves.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 5FEC54C6A3C; Fri, 04 Sep 2026 17:16:59 +0000 (UTC) Received: from pdx1-sub0-mail-a209.dreamhost.com (100-97-96-252.trex-nlb.outbound.svc.cluster.local [100.97.96.252]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 230E64C6039; Fri, 04 Sep 2026 17:16:59 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|pedro@palves.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|pedro@palves.net X-MailChannels-Auth-Id: dreamhost X-Shrill-Callous: 259bb6ee3ad0db46_1788542219218_1854202579 X-MC-Loop-Signature: 1788542219218:1726574356 X-MC-Ingress-Time: 1788542219217 Received: from pdx1-sub0-mail-a209.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.97.96.252 (trex/8.0.2); Fri, 04 Sep 2026 17:16:59 +0000 Received: from [192.168.0.201] (bl22-81-37.dsl.telepac.pt [2.83.81.37]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pedro@palves.net) by pdx1-sub0-mail-a209.dreamhost.com (Postfix) with ESMTPSA id 4hc36f1lxgz34; Fri, 4 Sep 2026 10:16:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=palves.net; s=dreamhost; t=1788542218; bh=vKzFZUnVIGaJ2naD2oZ2zoZilsulvmkey7+gAx+zAp8=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=Msib3JspbzRsF3YcVzgrr6emX73f+jbiVZZE3WoQeOrSCVc2ap8n/KNbKzpkvXjHj X0avfsF7VbQNUBkDC1gF/bO0NtDnuRWpkaNC7QHk57Z/ewIr86/DOc6Wq5VbsVJWVa bWFv7QGivCFH0Aysa12JrhiSqT+R1+lw/VkcJvpTJfJ7bJTtpkdVDnU7SWiymN123d gt7N/YSDOs9y0tRSu97xE6Fei9C3qgFJN+XCrx41HZeedBzkrGAsjwSmzdGlJ/gGgv dour9EqcuGIpedZqLT3NkAi9ovhlLlkNEUIvmwJPzrmENIDkJZCKgItVipgx6sbZ1y pZDHKwGhTML/w== Message-ID: <292ec56d-a457-43f3-8525-474932433342@palves.net> Date: Fri, 4 Sep 2026 18:16:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH] gdb/testsuite: Always close '-x hip' with '-x none' (was: Re: [PATCH v2] gdb/testsuite: replace hipcc with amdclang++ as the HIP compiler) To: gdb-patches@sourceware.org, "Six, Lancelot" Cc: Sarang Patrange References: <20260715094533.3093704-1-spatrang@amd.com> <20260806112951.1322605-1-spatrang@amd.com> From: Pedro Alves Content-Language: en-US In-Reply-To: <20260806112951.1322605-1-spatrang@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi! On 2026-08-06 12:29, Sarang Patrange wrote: > + # amdclang++ infers the input language from the file extension and > + # compiles .cpp as C++, not HIP. Since the HIP testcases are named > + # .cpp, explicitly tag each input: "-x hip" before C/C++/HIP source > + # files, and "-x none" before everything else (object files, > + # archives, shared libraries), so the compiler does not try to > + # parse those as HIP source. This lets a single amdclang++ > + # invocation correctly handle a mix of sources and non-source > + # inputs (e.g. when set_unbuffered_mode.o is appended via ldflags > + # later in the command line). Turns out this part about set_unbuffered_mode.o isn't working as intended. Testing on Windows still revealed breakage. See patch below for proposed fix. > + if {[lsearch -exact $options hip] != -1 && !$getting_compiler_info} { > + set new_source {} > + foreach src $source { > + set ext [string tolower [file extension $src]] > + if {$ext in {".c" ".cc" ".cp" ".cxx" ".cpp" ".c++" ".hip"}} { > + lappend new_source "-x" "hip" $src > + } else { > + lappend new_source "-x" "none" $src > + } > + } > + set source $new_source > + } > + >From 1b251b00f8dc2bfeff83871739bb2a2d14f8470c Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Fri, 31 Jul 2026 14:54:15 +0100 Subject: [PATCH] gdb/testsuite: Always close '-x hip' with '-x none' When compiling a HIP testcase on Windows, we see: ... Executing on host: clang++ --hip-link -mllvm=-amdgpu-spill-cfi-saved-regs -Wno-unused-command-line-argument -x hip /c/msys2/home/alves/gdb/build-testsuite-windows-msvc/temp/4415/device_enumerator.cpp -fdiagnostics-color=never -Wno-unknown-warning-option -Wno-deprecated-declarations -w -g /c/msys2/home/alves/gdb/build-testsuite-windows-msvc/set_unbuffered_mode_saved.o /c/msys2/home/alves/gdb/build-testsuite-windows-msvc/windows-manifest.o -o /c/msys2/home/alves/gdb/build-testsuite-windows-msvc/temp/4415/device_enumerator.x (timeout = 300) ... C:/msys2/home/alves/gdb/build-testsuite-windows-msvc/set_unbuffered_mode_saved.o:1:2: error: source file is not valid UTF-8 1 | d<86><95><9A>jxD.textN$r