From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17507 invoked by alias); 6 May 2004 18:02:23 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17461 invoked from network); 6 May 2004 18:02:21 -0000 Received: from unknown (HELO legolas.inter.net.il) (192.114.186.24) by sources.redhat.com with SMTP; 6 May 2004 18:02:21 -0000 Received: from zaretski ([80.230.142.26]) by legolas.inter.net.il (MOS 3.4.6-GR) with ESMTP id BSK04828; Thu, 6 May 2004 20:59:44 +0300 (IDT) Date: Thu, 06 May 2004 18:02:00 -0000 From: "Eli Zaretskii" To: Daniel Jacobowitz Message-Id: <2914-Thu06May2004205906+0300-eliz@gnu.org> CC: orjan.friberg@axis.com, weigand@i1.informatik.uni-erlangen.de, kettenis@chello.nl, gdb-patches@sources.redhat.com In-reply-to: <20040506142146.GA24608@nevyn.them.org> (message from Daniel Jacobowitz on Thu, 6 May 2004 10:21:46 -0400) Subject: Re: Display of read/access watchpoints when HAVE_NONSTEPPABLE_WATCHPOINT Reply-to: Eli Zaretskii References: <200405042208.AAA07379@faui1d.informatik.uni-erlangen.de> <4098A4F6.5020106@axis.com> <20040506142146.GA24608@nevyn.them.org> X-SW-Source: 2004-05/txt/msg00153.txt.bz2 > Date: Thu, 6 May 2004 10:21:46 -0400 > From: Daniel Jacobowitz > > > > Thus, for the STOPPED_BY_WATCHPOINT trick to work, bpstat_stop_status > > needs to have access to the relevant parts of the inferior's struct > > execution_control_state variable. It doesn't seem to me too hard to > > pass that as an additional argument. > > This is the point where I want to go back to the "design" bit that Mark > was talking about. Redesigning watchpoint handling doesn't mean we should abandon fixing bugs in the meantime, IMHO. > execution_control_state is private to infrun.c, and > I would prefer to leave it that way; the more localized it is, the > easier it is to clean up and maintain, without having to rip tentacles > out of other parts of GDB. Sorry, I don't understand: bpstat_stop_status is called by infrun, so passing it execution_control_state doesn't violate its being private to infrun.c.