Re: [PATCH ver 2] Fix the gdb.ada/inline-section-gc.exp test

Tom Tromey
2023-11-08T16:54:47Z

>>>>> "Carl" == Carl Love <cel@linux.ibm.com> writes:

Carl> GDB maintainers, Luis, Tom:
Carl> Version 2, fixed the name of the test the patch fixes in the email.
Carl> Mixed it up with another patch I am working on sorry about that.

No worries.

Carl> Here is the patch to fix test gdb.ada/inline-section-gc.exp on
Carl> PowerPC as discussed on IRC.

I think it looks good, but I have one nit.

Carl> +set bp_location1 [gdb_get_line_number "BREAK" ${testdir}/callee.adb]
Carl> +set bp_location2 [expr $bp_location1 - 1]

It would be better to just stick some comment on the relevant line in
caller.adb and then use gdb_get_line_number to fetch it.

thanks,
Tom